Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] JOIN command parser support #202749

Merged
merged 3 commits into from
Dec 4, 2024
Merged

[ES|QL] JOIN command parser support #202749

merged 3 commits into from
Dec 4, 2024

Conversation

vadimkibana
Copy link
Contributor

@vadimkibana vadimkibana commented Dec 3, 2024 •
edited by kibanamachine
Loading

Summary

Partially addresses #200858

  • Adds JOIN command support in Kibana ES|QL AST and parser.
  • Adds commandType to AST nodes, to support <TYPE> JOIN ... in join commands.
  • Adds AS binary expression, to support target aliassing in JOIN commands: LEFT JOIN a AS b

Checklist

@vadimkibana vadimkibana requested a review from a team as a code owner December 3, 2024 14:47
@vadimkibana vadimkibana added review release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana v8.18.0 labels Dec 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@vadimkibana vadimkibana mentioned this pull request Dec 3, 2024
Merged
1 task
stratoula
stratoula approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, there is a jest test failing but it looks good so I approve as there is no need to review again

@vadimkibana vadimkibana enabled auto-merge (squash) December 4, 2024 10:46
@vadimkibana vadimkibana merged commit df37092 into elastic:main Dec 4, 2024
8 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-ast 222 223 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.5MB 3.5MB +509.0B
Unknown metric groups

API count

id before after diff
@kbn/esql-ast 283 285 +2

History

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12159601149

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 4, 2024
@vadimkibana
[ES|QL] JOIN command parser support (elastic#202749)
5e15002 
## Summary

Partially addresses elastic#200858

- Adds `JOIN` command support in Kibana ES|QL AST and parser.
- Adds `commandType` to AST nodes, to support `<TYPE> JOIN ...` in join
commands.
- Adds `AS` binary expression, to support *target* aliassing in `JOIN`
commands: `LEFT JOIN a AS b`

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit df37092)
@kibanamachine kibanamachine mentioned this pull request Dec 4, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 4, 2024
@kibanamachine @vadimkibana
[8.x] [ES|QL] &#x60;JOIN&#x60; command parser support (#202749) (#202905
d3730c6 
)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] &#x60;JOIN&#x60; command parser support
(#202749)](#202749)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Vadim
Kibana","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-04T12:19:59Z","message":"[ES|QL]
`JOIN` command parser support (#202749)\n\n## Summary\r\n\r\nPartially
addresses https://github.com/elastic/kibana/issues/200858\r\n\r\n- Adds
`JOIN` command support in Kibana ES|QL AST and parser.\r\n- Adds
`commandType` to AST nodes, to support `<TYPE> JOIN ...` in
join\r\ncommands.\r\n- Adds `AS` binary expression, to support *target*
aliassing in `JOIN`\r\ncommands: `LEFT JOIN a AS b`\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"df37092b20b49b536fe541cc1dfcd294922ee7e7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.18.0"],"title":"[ES|QL]
`JOIN` command parser
support","number":202749,"url":"https://github.com/elastic/kibana/pull/202749","mergeCommit":{"message":"[ES|QL]
`JOIN` command parser support (#202749)\n\n## Summary\r\n\r\nPartially
addresses https://github.com/elastic/kibana/issues/200858\r\n\r\n- Adds
`JOIN` command support in Kibana ES|QL AST and parser.\r\n- Adds
`commandType` to AST nodes, to support `<TYPE> JOIN ...` in
join\r\ncommands.\r\n- Adds `AS` binary expression, to support *target*
aliassing in `JOIN`\r\ncommands: `LEFT JOIN a AS b`\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"df37092b20b49b536fe541cc1dfcd294922ee7e7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202749","number":202749,"mergeCommit":{"message":"[ES|QL]
`JOIN` command parser support (#202749)\n\n## Summary\r\n\r\nPartially
addresses https://github.com/elastic/kibana/issues/200858\r\n\r\n- Adds
`JOIN` command support in Kibana ES|QL AST and parser.\r\n- Adds
`commandType` to AST nodes, to support `<TYPE> JOIN ...` in
join\r\ncommands.\r\n- Adds `AS` binary expression, to support *target*
aliassing in `JOIN`\r\ncommands: `LEFT JOIN a AS b`\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"df37092b20b49b536fe541cc1dfcd294922ee7e7"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Vadim Kibana <[email protected]>
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Dec 5, 2024
@vadimkibana @hop-dev
[ES|QL] JOIN command parser support (elastic#202749)
0ff2e17 
## Summary

Partially addresses elastic#200858

- Adds `JOIN` command support in Kibana ES|QL AST and parser.
- Adds `commandType` to AST nodes, to support `<TYPE> JOIN ...` in join
commands.
- Adds `AS` binary expression, to support *target* aliassing in `JOIN`
commands: `LEFT JOIN a AS b`


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@vadimkibana @SoniaSanzV
[ES|QL] JOIN command parser support (elastic#202749)
c5370b2 
## Summary

Partially addresses elastic#200858

- Adds `JOIN` command support in Kibana ES|QL AST and parser.
- Adds `commandType` to AST nodes, to support `<TYPE> JOIN ...` in join
commands.
- Adds `AS` binary expression, to support *target* aliassing in `JOIN`
commands: `LEFT JOIN a AS b`


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@vadimkibana @SoniaSanzV
[ES|QL] JOIN command parser support (elastic#202749)
622be73 
## Summary

Partially addresses elastic#200858

- Adds `JOIN` command support in Kibana ES|QL AST and parser.
- Adds `commandType` to AST nodes, to support `<TYPE> JOIN ...` in join
commands.
- Adds `AS` binary expression, to support *target* aliassing in `JOIN`
commands: `LEFT JOIN a AS b`


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
@vadimkibana @CAWilson94
[ES|QL] JOIN command parser support (elastic#202749)
e9e2f63 
## Summary

Partially addresses elastic#200858

- Adds `JOIN` command support in Kibana ES|QL AST and parser.
- Adds `commandType` to AST nodes, to support `<TYPE> JOIN ...` in join
commands.
- Adds `AS` binary expression, to support *target* aliassing in `JOIN`
commands: `LEFT JOIN a AS b`


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@vadimkibana @CAWilson94
[ES|QL] JOIN command parser support (elastic#202749)
53574fa 
## Summary

Partially addresses elastic#200858

- Adds `JOIN` command support in Kibana ES|QL AST and parser.
- Adds `commandType` to AST nodes, to support `<TYPE> JOIN ...` in join
commands.
- Adds `AS` binary expression, to support *target* aliassing in `JOIN`
commands: `LEFT JOIN a AS b`


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes review Team:ESQL ES|QL related features in Kibana v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vadimkibana @elasticmachine @kibanamachine @stratoula