Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] JOIN command support #200858

Open
10 of 15 tasks
stratoula opened this issue Nov 20, 2024 · 2 comments
Open
10 of 15 tasks

[ES|QL] JOIN command support #200858

stratoula opened this issue Nov 20, 2024 · 2 comments
Assignees
@vadimkibana
Labels
enhancement New value added to drive a business result epic Feature:ES|QL ES|QL related features in Kibana impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana

Comments

@stratoula
Copy link
Contributor

stratoula commented Nov 20, 2024 •
edited by vadimkibana
Loading

ES recently merged this elastic/elasticsearch#116515 which contains the changes we need to add JOIN support in Kibana.

In @kbn/esql-ast:

  • Grammar
  • AST
  • Parser
  • Walker
  • Visitor
  • Pretty-printer

In @kbn/validation-and-autocomplete:

  • Definitions
    • AS binary expression
    • JOIN command
  • REST API for suggesting lookup indices
  • Validation
    • Pass validation
  • Autocomplete
    • Suggest command type
    • Suggest lookup indices
@stratoula stratoula changed the title JOIN autocomplete [ES|QL] JOIN validation and autocomplete Nov 20, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 20, 2024
@stratoula stratoula added enhancement New value added to drive a business result Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana and removed needs-team Issues missing a team label labels Nov 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Nov 20, 2024
@stratoula stratoula mentioned this issue Nov 25, 2024
Merged
@stratoula
Copy link
Contributor Author

With this PR #201514 we are adding the join family to the theme and validation

Image

stratoula added a commit that referenced this issue Nov 25, 2024
@kibanamachine @stratoula
[ES|QL] Update grammars (#201514)
a41017e 
Part of #200858

This PR updates the ES|QL grammars (lexer and parser) to match the
latest version in Elasticsearch.

---------

Co-authored-by: Stratoula Kalafateli <[email protected]>
kibanamachine added a commit to kibanamachine/kibana that referenced this issue Nov 25, 2024
@kibanamachine
[ES|QL] Update grammars (elastic#201514)
b75debc 
Part of elastic#200858

This PR updates the ES|QL grammars (lexer and parser) to match the
latest version in Elasticsearch.

---------

Co-authored-by: Stratoula Kalafateli <[email protected]>
(cherry picked from commit a41017e)
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this issue Nov 26, 2024
@kibanamachine @stratoula @paulinashakirova
[ES|QL] Update grammars (elastic#201514)
1251fa3 
Part of elastic#200858

This PR updates the ES|QL grammars (lexer and parser) to match the
latest version in Elasticsearch.

---------

Co-authored-by: Stratoula Kalafateli <[email protected]>
@vadimkibana vadimkibana changed the title [ES|QL] JOIN validation and autocomplete [ES|QL] JOIN command support Dec 3, 2024
This was referenced Dec 3, 2024
Merged
Merged
vadimkibana added a commit that referenced this issue Dec 4, 2024
@vadimkibana
[ES|QL] JOIN command parser support (#202749)
df37092 
## Summary

Partially addresses #200858

- Adds `JOIN` command support in Kibana ES|QL AST and parser.
- Adds `commandType` to AST nodes, to support `<TYPE> JOIN ...` in join
commands.
- Adds `AS` binary expression, to support *target* aliassing in `JOIN`
commands: `LEFT JOIN a AS b`


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 4, 2024
@vadimkibana
[ES|QL] JOIN command parser support (elastic#202749)
5e15002 
## Summary

Partially addresses elastic#200858

- Adds `JOIN` command support in Kibana ES|QL AST and parser.
- Adds `commandType` to AST nodes, to support `<TYPE> JOIN ...` in join
commands.
- Adds `AS` binary expression, to support *target* aliassing in `JOIN`
commands: `LEFT JOIN a AS b`

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit df37092)
hop-dev pushed a commit to hop-dev/kibana that referenced this issue Dec 5, 2024
@vadimkibana @hop-dev
[ES|QL] JOIN command parser support (elastic#202749)
0ff2e17 
## Summary

Partially addresses elastic#200858

- Adds `JOIN` command support in Kibana ES|QL AST and parser.
- Adds `commandType` to AST nodes, to support `<TYPE> JOIN ...` in join
commands.
- Adds `AS` binary expression, to support *target* aliassing in `JOIN`
commands: `LEFT JOIN a AS b`


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
vadimkibana added a commit that referenced this issue Dec 6, 2024
@vadimkibana
[ES|QL] JOIN command Traversal API and prety-printing support (#202750
79c0827 
)

## Summary

Partially addresses #200858

- Add support for the new `JOIN` command and `AS` expression in
Traversal API: `Walker` and `Visitor`
- Adds support for the new `JOIN`command and `AS` expression in the
pretty-printer.
- Fixes some parser bugs related to the `JOIN` command.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 6, 2024
@vadimkibana
[ES|QL] JOIN command Traversal API and prety-printing support (elas…
fba4277 
…tic#202750)

## Summary

Partially addresses elastic#200858

- Add support for the new `JOIN` command and `AS` expression in
Traversal API: `Walker` and `Visitor`
- Adds support for the new `JOIN`command and `AS` expression in the
pretty-printer.
- Fixes some parser bugs related to the `JOIN` command.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 79c0827)
markov00 pushed a commit to markov00/kibana that referenced this issue Dec 7, 2024
@vadimkibana @markov00
[ES|QL] JOIN command Traversal API and prety-printing support (elas…
f6e52bc 
…tic#202750)

## Summary

Partially addresses elastic#200858

- Add support for the new `JOIN` command and `AS` expression in
Traversal API: `Walker` and `Visitor`
- Adds support for the new `JOIN`command and `AS` expression in the
pretty-printer.
- Fixes some parser bugs related to the `JOIN` command.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this issue Dec 9, 2024
@vadimkibana @SoniaSanzV
[ES|QL] JOIN command parser support (elastic#202749)
c5370b2 
## Summary

Partially addresses elastic#200858

- Adds `JOIN` command support in Kibana ES|QL AST and parser.
- Adds `commandType` to AST nodes, to support `<TYPE> JOIN ...` in join
commands.
- Adds `AS` binary expression, to support *target* aliassing in `JOIN`
commands: `LEFT JOIN a AS b`


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this issue Dec 9, 2024
@vadimkibana @SoniaSanzV
[ES|QL] JOIN command Traversal API and prety-printing support (elas…
ac8a81d 
…tic#202750)

## Summary

Partially addresses elastic#200858

- Add support for the new `JOIN` command and `AS` expression in
Traversal API: `Walker` and `Visitor`
- Adds support for the new `JOIN`command and `AS` expression in the
pretty-printer.
- Fixes some parser bugs related to the `JOIN` command.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this issue Dec 9, 2024
@vadimkibana @SoniaSanzV
[ES|QL] JOIN command parser support (elastic#202749)
622be73 
## Summary

Partially addresses elastic#200858

- Adds `JOIN` command support in Kibana ES|QL AST and parser.
- Adds `commandType` to AST nodes, to support `<TYPE> JOIN ...` in join
commands.
- Adds `AS` binary expression, to support *target* aliassing in `JOIN`
commands: `LEFT JOIN a AS b`


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this issue Dec 9, 2024
@vadimkibana @SoniaSanzV
[ES|QL] JOIN command Traversal API and prety-printing support (elas…
60383e1 
…tic#202750)

## Summary

Partially addresses elastic#200858

- Add support for the new `JOIN` command and `AS` expression in
Traversal API: `Walker` and `Visitor`
- Adds support for the new `JOIN`command and `AS` expression in the
pretty-printer.
- Fixes some parser bugs related to the `JOIN` command.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 9, 2024
@vadimkibana @CAWilson94
[ES|QL] JOIN command parser support (elastic#202749)
e9e2f63 
## Summary

Partially addresses elastic#200858

- Adds `JOIN` command support in Kibana ES|QL AST and parser.
- Adds `commandType` to AST nodes, to support `<TYPE> JOIN ...` in join
commands.
- Adds `AS` binary expression, to support *target* aliassing in `JOIN`
commands: `LEFT JOIN a AS b`


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 9, 2024
@vadimkibana @CAWilson94
[ES|QL] JOIN command Traversal API and prety-printing support (elas…
311ed58 
…tic#202750)

## Summary

Partially addresses elastic#200858

- Add support for the new `JOIN` command and `AS` expression in
Traversal API: `Walker` and `Visitor`
- Adds support for the new `JOIN`command and `AS` expression in the
pretty-printer.
- Fixes some parser bugs related to the `JOIN` command.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this issue Dec 10, 2024
@vadimkibana @Samiul-TheSoccerFan
[ES|QL] JOIN command Traversal API and prety-printing support (elas…
1fec9be 
…tic#202750)

## Summary

Partially addresses elastic#200858

- Add support for the new `JOIN` command and `AS` expression in
Traversal API: `Walker` and `Visitor`
- Adds support for the new `JOIN`command and `AS` expression in the
pretty-printer.
- Fixes some parser bugs related to the `JOIN` command.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this issue Dec 11, 2024
@vadimkibana @mykolaharmash
[ES|QL] JOIN command Traversal API and prety-printing support (elas…
f4a4998 
…tic#202750)

## Summary

Partially addresses elastic#200858

- Add support for the new `JOIN` command and `AS` expression in
Traversal API: `Walker` and `Visitor`
- Adds support for the new `JOIN`command and `AS` expression in the
pretty-printer.
- Fixes some parser bugs related to the `JOIN` command.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@kibanamachine @stratoula @CAWilson94
[ES|QL] Update grammars (elastic#201514)
cb43a07 
Part of elastic#200858

This PR updates the ES|QL grammars (lexer and parser) to match the
latest version in Elasticsearch.

---------

Co-authored-by: Stratoula Kalafateli <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@vadimkibana @CAWilson94
[ES|QL] JOIN command parser support (elastic#202749)
53574fa 
## Summary

Partially addresses elastic#200858

- Adds `JOIN` command support in Kibana ES|QL AST and parser.
- Adds `commandType` to AST nodes, to support `<TYPE> JOIN ...` in join
commands.
- Adds `AS` binary expression, to support *target* aliassing in `JOIN`
commands: `LEFT JOIN a AS b`


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@vadimkibana @CAWilson94
[ES|QL] JOIN command Traversal API and prety-printing support (elas…
9e107fb 
…tic#202750)

## Summary

Partially addresses elastic#200858

- Add support for the new `JOIN` command and `AS` expression in
Traversal API: `Walker` and `Visitor`
- Adds support for the new `JOIN`command and `AS` expression in the
pretty-printer.
- Fixes some parser bugs related to the `JOIN` command.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vadimkibana vadimkibana

Labels
enhancement New value added to drive a business result epic Feature:ES|QL ES|QL related features in Kibana impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@timductive @elasticmachine @stratoula @vadimkibana