Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Exclude frozen/cold data tiers from source queries #201804

Merged

Conversation

Bluefinger
Copy link
Contributor

@Bluefinger Bluefinger commented Nov 26, 2024

Closes #201568

Summary

Adds the exclude data tiers settings to the /api/metrics/source/hasData and /api/metrics/source/{sourceId} requests. Also applies it to the getIndexStatus API call.

@Bluefinger Bluefinger added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.16.0 labels Nov 26, 2024
@Bluefinger
Copy link
Contributor Author

@elasticmachine merge upstream

@Bluefinger
Copy link
Contributor Author

/ci

@Bluefinger Bluefinger marked this pull request as ready for review November 27, 2024 13:14
@Bluefinger Bluefinger requested review from a team as code owners November 27, 2024 13:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we're now using the searchExcludeDataTiers parameter in Infra, we need to update the description of this parameter here, adding "Infrastructure" to the "Affected apps" list

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 27, 2024
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@Bluefinger Bluefinger requested a review from a team as a code owner November 27, 2024 14:56
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Nov 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner November 27, 2024 17:31
@Bluefinger Bluefinger merged commit ac3b60e into elastic:main Dec 3, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12145850931

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 3, 2024
…01804)

Closes elastic#201568

## Summary

Adds the exclude data tiers settings to the
`/api/metrics/source/hasData` and `/api/metrics/source/{sourceId}`
requests. Also applies it to the `getIndexStatus` API call.

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit ac3b60e)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 3, 2024
…01804)

Closes elastic#201568

## Summary

Adds the exclude data tiers settings to the
`/api/metrics/source/hasData` and `/api/metrics/source/{sourceId}`
requests. Also applies it to the `getIndexStatus` API call.

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit ac3b60e)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.16 Backport failed because of merge conflicts
8.17
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 201804

Questions ?

Please refer to the Backport tool documentation

@Bluefinger
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Bluefinger added a commit to Bluefinger/kibana that referenced this pull request Dec 4, 2024
…01804)

Closes elastic#201568

Adds the exclude data tiers settings to the
`/api/metrics/source/hasData` and `/api/metrics/source/{sourceId}`
requests. Also applies it to the `getIndexStatus` API call.

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit ac3b60e)
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Dec 5, 2024
…01804)

Closes elastic#201568  

## Summary

Adds the exclude data tiers settings to the
`/api/metrics/source/hasData` and `/api/metrics/source/{sourceId}`
requests. Also applies it to the `getIndexStatus` API call.

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 5, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Bluefinger added a commit that referenced this pull request Dec 5, 2024
…01804) (#202924)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Infra] Exclude frozen/cold data tiers from source queries
(#201804)](#201804)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da
Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-03T18:23:13Z","message":"[Infra]
Exclude frozen/cold data tiers from source queries (#201804)\n\nCloses
#201568 \r\n\r\n## Summary\r\n\r\nAdds the exclude data tiers settings
to the\r\n`/api/metrics/source/hasData` and
`/api/metrics/source/{sourceId}`\r\nrequests. Also applies it to the
`getIndexStatus` API call.\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ac3b60ee907436aeee35fc59df7c30bcb9d66bc8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.16.0"],"number":201804,"url":"https://github.com/elastic/kibana/pull/201804","mergeCommit":{"message":"[Infra]
Exclude frozen/cold data tiers from source queries (#201804)\n\nCloses
#201568 \r\n\r\n## Summary\r\n\r\nAdds the exclude data tiers settings
to the\r\n`/api/metrics/source/hasData` and
`/api/metrics/source/{sourceId}`\r\nrequests. Also applies it to the
`getIndexStatus` API call.\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ac3b60ee907436aeee35fc59df7c30bcb9d66bc8"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201804","number":201804,"mergeCommit":{"message":"[Infra]
Exclude frozen/cold data tiers from source queries (#201804)\n\nCloses
#201568 \r\n\r\n## Summary\r\n\r\nAdds the exclude data tiers settings
to the\r\n`/api/metrics/source/hasData` and
`/api/metrics/source/{sourceId}`\r\nrequests. Also applies it to the
`getIndexStatus` API call.\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ac3b60ee907436aeee35fc59df7c30bcb9d66bc8"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"url":"https://github.com/elastic/kibana/pull/202788","number":202788,"branch":"8.17","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/202789","number":202789,"branch":"8.x","state":"OPEN"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: jennypavlova <[email protected]>
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
…01804)

Closes elastic#201568  

## Summary

Adds the exclude data tiers settings to the
`/api/metrics/source/hasData` and `/api/metrics/source/{sourceId}`
requests. Also applies it to the `getIndexStatus` API call.

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…01804)

Closes elastic#201568  

## Summary

Adds the exclude data tiers settings to the
`/api/metrics/source/hasData` and `/api/metrics/source/{sourceId}`
requests. Also applies it to the `getIndexStatus` API call.

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
kibanamachine added a commit that referenced this pull request Dec 12, 2024
…01804) (#202788)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Infra] Exclude frozen/cold data tiers from source queries
(#201804)](#201804)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da
Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-03T18:23:13Z","message":"[Infra]
Exclude frozen/cold data tiers from source queries (#201804)\n\nCloses
#201568 \r\n\r\n## Summary\r\n\r\nAdds the exclude data tiers settings
to the\r\n`/api/metrics/source/hasData` and
`/api/metrics/source/{sourceId}`\r\nrequests. Also applies it to the
`getIndexStatus` API call.\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ac3b60ee907436aeee35fc59df7c30bcb9d66bc8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.16.0"],"title":"[Infra]
Exclude frozen/cold data tiers from source
queries","number":201804,"url":"https://github.com/elastic/kibana/pull/201804","mergeCommit":{"message":"[Infra]
Exclude frozen/cold data tiers from source queries (#201804)\n\nCloses
#201568 \r\n\r\n## Summary\r\n\r\nAdds the exclude data tiers settings
to the\r\n`/api/metrics/source/hasData` and
`/api/metrics/source/{sourceId}`\r\nrequests. Also applies it to the
`getIndexStatus` API call.\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ac3b60ee907436aeee35fc59df7c30bcb9d66bc8"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201804","number":201804,"mergeCommit":{"message":"[Infra]
Exclude frozen/cold data tiers from source queries (#201804)\n\nCloses
#201568 \r\n\r\n## Summary\r\n\r\nAdds the exclude data tiers settings
to the\r\n`/api/metrics/source/hasData` and
`/api/metrics/source/{sourceId}`\r\nrequests. Also applies it to the
`getIndexStatus` API call.\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ac3b60ee907436aeee35fc59df7c30bcb9d66bc8"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Gonçalo Rica Pais da Silva <[email protected]>
kibanamachine added a commit that referenced this pull request Dec 12, 2024
…1804) (#202789)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Infra] Exclude frozen/cold data tiers from source queries
(#201804)](#201804)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da
Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-03T18:23:13Z","message":"[Infra]
Exclude frozen/cold data tiers from source queries (#201804)\n\nCloses
#201568 \r\n\r\n## Summary\r\n\r\nAdds the exclude data tiers settings
to the\r\n`/api/metrics/source/hasData` and
`/api/metrics/source/{sourceId}`\r\nrequests. Also applies it to the
`getIndexStatus` API call.\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ac3b60ee907436aeee35fc59df7c30bcb9d66bc8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.16.0"],"title":"[Infra]
Exclude frozen/cold data tiers from source
queries","number":201804,"url":"https://github.com/elastic/kibana/pull/201804","mergeCommit":{"message":"[Infra]
Exclude frozen/cold data tiers from source queries (#201804)\n\nCloses
#201568 \r\n\r\n## Summary\r\n\r\nAdds the exclude data tiers settings
to the\r\n`/api/metrics/source/hasData` and
`/api/metrics/source/{sourceId}`\r\nrequests. Also applies it to the
`getIndexStatus` API call.\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ac3b60ee907436aeee35fc59df7c30bcb9d66bc8"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201804","number":201804,"mergeCommit":{"message":"[Infra]
Exclude frozen/cold data tiers from source queries (#201804)\n\nCloses
#201568 \r\n\r\n## Summary\r\n\r\nAdds the exclude data tiers settings
to the\r\n`/api/metrics/source/hasData` and
`/api/metrics/source/{sourceId}`\r\nrequests. Also applies it to the
`getIndexStatus` API call.\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ac3b60ee907436aeee35fc59df7c30bcb9d66bc8"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Gonçalo Rica Pais da Silva <[email protected]>
@kibanamachine kibanamachine added v8.18.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Dec 12, 2024
@mistic
Copy link
Member

mistic commented Dec 12, 2024

This PR didn't make it on time for the latest v8.17.0 BC. Updating the labels.

@mistic mistic added v8.17.1 and removed v8.17.0 labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team v8.16.0 v8.16.2 v8.17.1 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infra] Filter out frozen and cold tiers from source endpoint queries
7 participants