[Logs] Deprecate configuration settings #201625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyghiani
added
release_note:deprecation
Team:obs-ux-logs
…tonyghiani/kibana into 200898-deprecate-configuration-settings
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
cauemarcondes
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
LGTM, @tonyghiani do you really want to backport it to 8.x and 8.17?
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Thanks for the review @cauemarcondes
I just asked to the core team regarding this kind of deprecations and it si correct to backport them to 8.x 👌 |
afharo
reviewed
Nov 26, 2024
...rvability_solution/observability_onboarding/public/application/shared/header_action_menu.tsx
Outdated
Show resolved
Hide resolved
mykolaharmash
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Onboarding changes are looking good ✨ Thank you @tonyghiani!
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12176815618 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
tonyghiani
added a commit
to tonyghiani/kibana
that referenced
this pull request
Dec 5, 2024
## 📓 Summary Closes elastic#200898 These changes deprecate some unused configurations and update the implementation where required in preparation for the Kibana v9 upgrade. <img width="3004" alt="Screenshot 2024-11-25 at 12 54 14" src="https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4"> --------- Co-authored-by: Marco Antonio Ghiani <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 2994b00) # Conflicts: # x-pack/plugins/observability_solution/infra/tsconfig.json
tonyghiani
added a commit
that referenced
this pull request
Dec 5, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Logs] Deprecate configuration settings (#201625)](#201625) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Antonio Ghiani","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T09:23:54Z","message":"[Logs] Deprecate configuration settings (#201625)\n\n## 📓 Summary\r\n\r\nCloses #200898 \r\n\r\nThese changes deprecate some unused configurations and update the\r\nimplementation where required in preparation for the Kibana v9 upgrade.\r\n\r\n<img width=\"3004\" alt=\"Screenshot 2024-11-25 at 12 54 14\"\r\nsrc=\"https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4\">\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"2994b0001cbae6bc1528bc1ad77c435597e0d5a2","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:deprecation","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs"],"number":201625,"url":"https://github.com/elastic/kibana/pull/201625","mergeCommit":{"message":"[Logs] Deprecate configuration settings (#201625)\n\n## 📓 Summary\r\n\r\nCloses #200898 \r\n\r\nThese changes deprecate some unused configurations and update the\r\nimplementation where required in preparation for the Kibana v9 upgrade.\r\n\r\n<img width=\"3004\" alt=\"Screenshot 2024-11-25 at 12 54 14\"\r\nsrc=\"https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4\">\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"2994b0001cbae6bc1528bc1ad77c435597e0d5a2"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201625","number":201625,"mergeCommit":{"message":"[Logs] Deprecate configuration settings (#201625)\n\n## 📓 Summary\r\n\r\nCloses #200898 \r\n\r\nThese changes deprecate some unused configurations and update the\r\nimplementation where required in preparation for the Kibana v9 upgrade.\r\n\r\n<img width=\"3004\" alt=\"Screenshot 2024-11-25 at 12 54 14\"\r\nsrc=\"https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4\">\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"2994b0001cbae6bc1528bc1ad77c435597e0d5a2"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
## 📓 Summary Closes elastic#200898 These changes deprecate some unused configurations and update the implementation where required in preparation for the Kibana v9 upgrade. <img width="3004" alt="Screenshot 2024-11-25 at 12 54 14" src="https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4"> --------- Co-authored-by: Marco Antonio Ghiani <[email protected]> Co-authored-by: kibanamachine <[email protected]>
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
## 📓 Summary Closes elastic#200898 These changes deprecate some unused configurations and update the implementation where required in preparation for the Kibana v9 upgrade. <img width="3004" alt="Screenshot 2024-11-25 at 12 54 14" src="https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4"> --------- Co-authored-by: Marco Antonio Ghiani <[email protected]> Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
## 📓 Summary Closes elastic#200898 These changes deprecate some unused configurations and update the implementation where required in preparation for the Kibana v9 upgrade. <img width="3004" alt="Screenshot 2024-11-25 at 12 54 14" src="https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4"> --------- Co-authored-by: Marco Antonio Ghiani <[email protected]> Co-authored-by: kibanamachine <[email protected]>
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/kibana
that referenced
this pull request
Dec 10, 2024
## 📓 Summary Closes elastic#200898 These changes deprecate some unused configurations and update the implementation where required in preparation for the Kibana v9 upgrade. <img width="3004" alt="Screenshot 2024-11-25 at 12 54 14" src="https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4"> --------- Co-authored-by: Marco Antonio Ghiani <[email protected]> Co-authored-by: kibanamachine <[email protected]>
mykolaharmash
pushed a commit
to mykolaharmash/kibana
that referenced
this pull request
Dec 11, 2024
## 📓 Summary Closes elastic#200898 These changes deprecate some unused configurations and update the implementation where required in preparation for the Kibana v9 upgrade. <img width="3004" alt="Screenshot 2024-11-25 at 12 54 14" src="https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4"> --------- Co-authored-by: Marco Antonio Ghiani <[email protected]> Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## 📓 Summary Closes elastic#200898 These changes deprecate some unused configurations and update the implementation where required in preparation for the Kibana v9 upgrade. <img width="3004" alt="Screenshot 2024-11-25 at 12 54 14" src="https://github.com/user-attachments/assets/cfa56d25-a270-4ec5-a97a-e72e7a7478a4"> --------- Co-authored-by: Marco Antonio Ghiani <[email protected]> Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 Summary
Closes #200898
These changes deprecate some unused configurations and update the implementation where required in preparation for the Kibana v9 upgrade.