fix: [Search:AppSearch:Users and roles page]Copy button missing name from announcement #201763
+25
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from announcement Closes: elastic#200982
alexwizp
added
v9.0.0
backport:prev-minor
|
/ci |
|
/ci |
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
sphilipse
approved these changes
Nov 27, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12049054486 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 27, 2024
…from announcement (elastic#201763) Closes: elastic#200982 ### Description Button names should be announced for users using assistive technology to understand what button it is, for what it is used. ### What was changed?: 1. `aria-label` attribute was added to EuiCopy.EuiButtonIcon ### Screen <img width="1328" alt="Screenshot 2024-11-26 at 13 24 26" src="https://github.com/user-attachments/assets/18cc5fcf-8279-4120-98b7-4380578ff678"> (cherry picked from commit ec3dd55)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 27, 2024
… name from announcement (#201763) (#201943) # Backport This will backport the following commits from `main` to `8.x`: - [fix: [Search:AppSearch:Users and roles page]Copy button missing name from announcement (#201763)](#201763) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-27T11:08:44Z","message":"fix: [Search:AppSearch:Users and roles page]Copy button missing name from announcement (#201763)\n\nCloses: #200982\r\n\r\n### Description\r\nButton names should be announced for users using assistive technology to\r\nunderstand what button it is, for what it is used.\r\n\r\n### What was changed?:\r\n1. `aria-label` attribute was added to EuiCopy.EuiButtonIcon \r\n\r\n### Screen\r\n\r\n<img width=\"1328\" alt=\"Screenshot 2024-11-26 at 13 24 26\"\r\nsrc=\"https://github.com/user-attachments/assets/18cc5fcf-8279-4120-98b7-4380578ff678\">","sha":"ec3dd55fddb34603bf74c2135846769a47a60fad","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"fix: [Search:AppSearch:Users and roles page]Copy button missing name from announcement","number":201763,"url":"https://github.com/elastic/kibana/pull/201763","mergeCommit":{"message":"fix: [Search:AppSearch:Users and roles page]Copy button missing name from announcement (#201763)\n\nCloses: #200982\r\n\r\n### Description\r\nButton names should be announced for users using assistive technology to\r\nunderstand what button it is, for what it is used.\r\n\r\n### What was changed?:\r\n1. `aria-label` attribute was added to EuiCopy.EuiButtonIcon \r\n\r\n### Screen\r\n\r\n<img width=\"1328\" alt=\"Screenshot 2024-11-26 at 13 24 26\"\r\nsrc=\"https://github.com/user-attachments/assets/18cc5fcf-8279-4120-98b7-4380578ff678\">","sha":"ec3dd55fddb34603bf74c2135846769a47a60fad"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201763","number":201763,"mergeCommit":{"message":"fix: [Search:AppSearch:Users and roles page]Copy button missing name from announcement (#201763)\n\nCloses: #200982\r\n\r\n### Description\r\nButton names should be announced for users using assistive technology to\r\nunderstand what button it is, for what it is used.\r\n\r\n### What was changed?:\r\n1. `aria-label` attribute was added to EuiCopy.EuiButtonIcon \r\n\r\n### Screen\r\n\r\n<img width=\"1328\" alt=\"Screenshot 2024-11-26 at 13 24 26\"\r\nsrc=\"https://github.com/user-attachments/assets/18cc5fcf-8279-4120-98b7-4380578ff678\">","sha":"ec3dd55fddb34603bf74c2135846769a47a60fad"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #200982
Description
Button names should be announced for users using assistive technology to understand what button it is, for what it is used.
What was changed?:
aria-labelattribute was added to EuiCopy.EuiButtonIconScreen