Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search:AppSearch:Users and roles page]Copy button missing name from announcement #200982

Closed
L1nBra opened this issue Nov 20, 2024 · 1 comment · Fixed by #201763
Closed

[Search:AppSearch:Users and roles page]Copy button missing name from announcement #200982

L1nBra opened this issue Nov 20, 2024 · 1 comment · Fixed by #201763
Assignees
@alexwizp
Labels
defect-level-3 Moderate UX disruption or potentially confusing Project:Accessibility Team:Search WCAG A

Comments

@L1nBra
Copy link

L1nBra commented Nov 20, 2024 •
edited
Loading

Description
Button names should be announced for users using assistive technology to understand what button it is, for what it is used.

Preconditions
Stateful App Search -> Users and roles page is opened.
Engine is added.
Use Screen Reader (NVDA).

Steps to reproduce

1.Using only keyboard navigate to Add a new user button by pressing Tab key.
2.Fill correctly the form.
3.Navigate to Add user button.
4.Press Enter.
5.Navigate to Copy button.
6.Observe screen reader.

NVDA Speech Viewer + UI elements
Image

Actual Result

  • Button is announced only as "button".

Expected Result

  • Button is announced as "Copy button".

Meta Issue

Kibana Version: 8.17.0-SNAPSHOT

OS: Windows 11 Pro

Browser: Chrome Version 130.0.6723.70 (Official Build) (64-bit)

Screen reader: NVDA

WCAG or Vendor Guidance (optional)

Related to: https://github.com/elastic/search-team/issues/8256
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 20, 2024
@L1nBra L1nBra added WCAG A Team:Search defect-level-3 Moderate UX disruption or potentially confusing and removed needs-team Issues missing a team label labels Nov 20, 2024
@alexwizp alexwizp self-assigned this Nov 26, 2024
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 26, 2024
@alexwizp
fix: [Search:AppSearch:Users and roles page]Copy button missing name …
c00be39 
…from announcement

Closes: elastic#200982
@alexwizp alexwizp mentioned this issue Nov 26, 2024
Merged
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 26, 2024
@alexwizp
fix: [Search:AppSearch:Users and roles page]Copy button missing name …
508cabc 
…from announcement

Closes: elastic#200982
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 26, 2024
@alexwizp
Merge branch 'main' into elastic#200982
ca3c3f8
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 26, 2024
@alexwizp
Merge branch 'main' into elastic#200982
c521b3d
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 27, 2024
@alexwizp
Merge branch 'main' into elastic#200982
9d37251
alexwizp added a commit that referenced this issue Nov 27, 2024
@alexwizp
fix: [Search:AppSearch:Users and roles page]Copy button missing name …
ec3dd55 
…from announcement (#201763)

Closes: #200982

### Description
Button names should be announced for users using assistive technology to
understand what button it is, for what it is used.

### What was changed?:
1. `aria-label` attribute was added to EuiCopy.EuiButtonIcon 

### Screen

<img width="1328" alt="Screenshot 2024-11-26 at 13 24 26"
src="https://github.com/user-attachments/assets/18cc5fcf-8279-4120-98b7-4380578ff678">
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 27, 2024
@alexwizp
fix: [Search:AppSearch:Users and roles page]Copy button missing name …
6c036a3 
…from announcement (elastic#201763)

Closes: elastic#200982

### Description
Button names should be announced for users using assistive technology to
understand what button it is, for what it is used.

### What was changed?:
1. `aria-label` attribute was added to EuiCopy.EuiButtonIcon

### Screen

<img width="1328" alt="Screenshot 2024-11-26 at 13 24 26"
src="https://github.com/user-attachments/assets/18cc5fcf-8279-4120-98b7-4380578ff678">

(cherry picked from commit ec3dd55)
kibanamachine added a commit that referenced this issue Nov 27, 2024
@kibanamachine @alexwizp
[8.x] fix: [Search:AppSearch:Users and roles page]Copy button missing…
32688fb 
… name from announcement (#201763) (#201943)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Search:AppSearch:Users and roles page]Copy button missing name
from announcement
(#201763)](#201763)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-27T11:08:44Z","message":"fix:
[Search:AppSearch:Users and roles page]Copy button missing name from
announcement (#201763)\n\nCloses: #200982\r\n\r\n###
Description\r\nButton names should be announced for users using
assistive technology to\r\nunderstand what button it is, for what it is
used.\r\n\r\n### What was changed?:\r\n1. `aria-label` attribute was
added to EuiCopy.EuiButtonIcon \r\n\r\n### Screen\r\n\r\n<img
width=\"1328\" alt=\"Screenshot 2024-11-26 at 13 24
26\"\r\nsrc=\"https://github.com/user-attachments/assets/18cc5fcf-8279-4120-98b7-4380578ff678\">","sha":"ec3dd55fddb34603bf74c2135846769a47a60fad","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"fix:
[Search:AppSearch:Users and roles page]Copy button missing name from
announcement","number":201763,"url":"https://github.com/elastic/kibana/pull/201763","mergeCommit":{"message":"fix:
[Search:AppSearch:Users and roles page]Copy button missing name from
announcement (#201763)\n\nCloses: #200982\r\n\r\n###
Description\r\nButton names should be announced for users using
assistive technology to\r\nunderstand what button it is, for what it is
used.\r\n\r\n### What was changed?:\r\n1. `aria-label` attribute was
added to EuiCopy.EuiButtonIcon \r\n\r\n### Screen\r\n\r\n<img
width=\"1328\" alt=\"Screenshot 2024-11-26 at 13 24
26\"\r\nsrc=\"https://github.com/user-attachments/assets/18cc5fcf-8279-4120-98b7-4380578ff678\">","sha":"ec3dd55fddb34603bf74c2135846769a47a60fad"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201763","number":201763,"mergeCommit":{"message":"fix:
[Search:AppSearch:Users and roles page]Copy button missing name from
announcement (#201763)\n\nCloses: #200982\r\n\r\n###
Description\r\nButton names should be announced for users using
assistive technology to\r\nunderstand what button it is, for what it is
used.\r\n\r\n### What was changed?:\r\n1. `aria-label` attribute was
added to EuiCopy.EuiButtonIcon \r\n\r\n### Screen\r\n\r\n<img
width=\"1328\" alt=\"Screenshot 2024-11-26 at 13 24
26\"\r\nsrc=\"https://github.com/user-attachments/assets/18cc5fcf-8279-4120-98b7-4380578ff678\">","sha":"ec3dd55fddb34603bf74c2135846769a47a60fad"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
defect-level-3 Moderate UX disruption or potentially confusing Project:Accessibility Team:Search WCAG A
Projects
None yet
Milestone
No milestone
3 participants
@elasticmachine @alexwizp @L1nBra