[Rules migration] Add possibility to navigate to a specific migration (#11264) #201597
+154
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e40pud
added
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
# Conflicts: # x-pack/plugins/security_solution/public/siem_migrations/rules/pages/index.tsx
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @e40pud |
semd
reviewed
Nov 26, 2024
| import { EuiEmptyPrompt, EuiFlexGroup, EuiFlexItem } from '@elastic/eui'; | ||
| import * as i18n from './translations'; | ||
|
|
||
| const UnknownMigrationComponent = () => { |
There was a problem hiding this comment.
Could we export the memo component directly everywhere? It's shorter and it makes it easier to find the references in the IDE.
export const UnknownMigration = React.memo(() => {
// [...]
});
UnknownMigration.displayName = 'UnknownMigration';
There was a problem hiding this comment.
Sounds good, will update our components in one of the next PRs.
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12027790276 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 26, 2024
…elastic#11264) (elastic#201597) ## Summary [Internal link](elastic/security-team#10820) to the feature details With these changes we: * allow user to navigate to a specific migration by its id * handle different possible states on migrations rules page: * `no migrations`: if there are no existing migrations we will redirect user to the landing page * `unknown selected migration`: if unknown migration id is specified in the URL, then "Unknown Migration" page will be shown * `no selected migration`: if user lands on the root "SIEM migrations rules" page, then most recent migration will be shown * `show existing migration`: selected migration will be shown ### Screenshots **Unknown migration** <img width="1312" alt="Screenshot 2024-11-25 at 14 46 56" src="https://github.com/user-attachments/assets/45f51489-e4f8-496f-86e6-d19130bd6769"> **Show existing migration** <img width="1312" alt="Screenshot 2024-11-25 at 15 03 53" src="https://github.com/user-attachments/assets/ca866432-5a61-44c7-8bec-7aa95ba73156"> (cherry picked from commit 17410c3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 26, 2024
…ration (#11264) (#201597) (#201735) # Backport This will backport the following commits from `main` to `8.x`: - [[Rules migration] Add possibility to navigate to a specific migration (#11264) (#201597)](#201597) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T09:39:17Z","message":"[Rules migration] Add possibility to navigate to a specific migration (#11264) (#201597)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nWith these changes we:\r\n* allow user to navigate to a specific migration by its id\r\n* handle different possible states on migrations rules page:\r\n* `no migrations`: if there are no existing migrations we will redirect\r\nuser to the landing page\r\n* `unknown selected migration`: if unknown migration id is specified in\r\nthe URL, then \"Unknown Migration\" page will be shown\r\n* `no selected migration`: if user lands on the root \"SIEM migrations\r\nrules\" page, then most recent migration will be shown\r\n * `show existing migration`: selected migration will be shown\r\n\r\n### Screenshots\r\n\r\n**Unknown migration**\r\n\r\n<img width=\"1312\" alt=\"Screenshot 2024-11-25 at 14 46 56\"\r\nsrc=\"https://github.com/user-attachments/assets/45f51489-e4f8-496f-86e6-d19130bd6769\">\r\n\r\n**Show existing migration**\r\n\r\n<img width=\"1312\" alt=\"Screenshot 2024-11-25 at 15 03 53\"\r\nsrc=\"https://github.com/user-attachments/assets/ca866432-5a61-44c7-8bec-7aa95ba73156\">","sha":"17410c39279fcca551d3af7299b04d1ccf8ceefa","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","backport:prev-minor"],"title":"[Rules migration] Add possibility to navigate to a specific migration (#11264)","number":201597,"url":"https://github.com/elastic/kibana/pull/201597","mergeCommit":{"message":"[Rules migration] Add possibility to navigate to a specific migration (#11264) (#201597)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nWith these changes we:\r\n* allow user to navigate to a specific migration by its id\r\n* handle different possible states on migrations rules page:\r\n* `no migrations`: if there are no existing migrations we will redirect\r\nuser to the landing page\r\n* `unknown selected migration`: if unknown migration id is specified in\r\nthe URL, then \"Unknown Migration\" page will be shown\r\n* `no selected migration`: if user lands on the root \"SIEM migrations\r\nrules\" page, then most recent migration will be shown\r\n * `show existing migration`: selected migration will be shown\r\n\r\n### Screenshots\r\n\r\n**Unknown migration**\r\n\r\n<img width=\"1312\" alt=\"Screenshot 2024-11-25 at 14 46 56\"\r\nsrc=\"https://github.com/user-attachments/assets/45f51489-e4f8-496f-86e6-d19130bd6769\">\r\n\r\n**Show existing migration**\r\n\r\n<img width=\"1312\" alt=\"Screenshot 2024-11-25 at 15 03 53\"\r\nsrc=\"https://github.com/user-attachments/assets/ca866432-5a61-44c7-8bec-7aa95ba73156\">","sha":"17410c39279fcca551d3af7299b04d1ccf8ceefa"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201597","number":201597,"mergeCommit":{"message":"[Rules migration] Add possibility to navigate to a specific migration (#11264) (#201597)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nWith these changes we:\r\n* allow user to navigate to a specific migration by its id\r\n* handle different possible states on migrations rules page:\r\n* `no migrations`: if there are no existing migrations we will redirect\r\nuser to the landing page\r\n* `unknown selected migration`: if unknown migration id is specified in\r\nthe URL, then \"Unknown Migration\" page will be shown\r\n* `no selected migration`: if user lands on the root \"SIEM migrations\r\nrules\" page, then most recent migration will be shown\r\n * `show existing migration`: selected migration will be shown\r\n\r\n### Screenshots\r\n\r\n**Unknown migration**\r\n\r\n<img width=\"1312\" alt=\"Screenshot 2024-11-25 at 14 46 56\"\r\nsrc=\"https://github.com/user-attachments/assets/45f51489-e4f8-496f-86e6-d19130bd6769\">\r\n\r\n**Show existing migration**\r\n\r\n<img width=\"1312\" alt=\"Screenshot 2024-11-25 at 15 03 53\"\r\nsrc=\"https://github.com/user-attachments/assets/ca866432-5a61-44c7-8bec-7aa95ba73156\">","sha":"17410c39279fcca551d3af7299b04d1ccf8ceefa"}}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…elastic#11264) (elastic#201597) ## Summary [Internal link](elastic/security-team#10820) to the feature details With these changes we: * allow user to navigate to a specific migration by its id * handle different possible states on migrations rules page: * `no migrations`: if there are no existing migrations we will redirect user to the landing page * `unknown selected migration`: if unknown migration id is specified in the URL, then "Unknown Migration" page will be shown * `no selected migration`: if user lands on the root "SIEM migrations rules" page, then most recent migration will be shown * `show existing migration`: selected migration will be shown ### Screenshots **Unknown migration** <img width="1312" alt="Screenshot 2024-11-25 at 14 46 56" src="https://github.com/user-attachments/assets/45f51489-e4f8-496f-86e6-d19130bd6769"> **Show existing migration** <img width="1312" alt="Screenshot 2024-11-25 at 15 03 53" src="https://github.com/user-attachments/assets/ca866432-5a61-44c7-8bec-7aa95ba73156">
e40pud
added a commit
that referenced
this pull request
Dec 4, 2024
## Summary These are the followup updated to address feedback from my previous PRs: * Make sure to use descriptive names specific to the `siem_migrations` subdomain ([comment](#200978 (review))): > Make sure you use descriptive names specific to the siem_migrations subdomain. Names like RulesPage, RulesTable, useRulesColumns etc are way too generic and conflict with the rule management terminology, which would make code search more difficult. * Export the memo component directly everywhere ([comment](#201597 (comment))): > Could we export the memo component directly everywhere? It's shorter and it makes it easier to find the references in the IDE. * Use one hook to access APIs instead of two ([comment](#202494 (comment))): > I see that for every API request we have to implement 2 separate hooks. Why don't we add error handling to the same hook that does the useQuery? so we have everything in one hook. Or is there a reason to have them separate?
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 4, 2024
## Summary These are the followup updated to address feedback from my previous PRs: * Make sure to use descriptive names specific to the `siem_migrations` subdomain ([comment](elastic#200978 (review))): > Make sure you use descriptive names specific to the siem_migrations subdomain. Names like RulesPage, RulesTable, useRulesColumns etc are way too generic and conflict with the rule management terminology, which would make code search more difficult. * Export the memo component directly everywhere ([comment](elastic#201597 (comment))): > Could we export the memo component directly everywhere? It's shorter and it makes it easier to find the references in the IDE. * Use one hook to access APIs instead of two ([comment](elastic#202494 (comment))): > I see that for every API request we have to implement 2 separate hooks. Why don't we add error handling to the same hook that does the useQuery? so we have everything in one hook. Or is there a reason to have them separate? (cherry picked from commit 4d8f711)
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
## Summary These are the followup updated to address feedback from my previous PRs: * Make sure to use descriptive names specific to the `siem_migrations` subdomain ([comment](elastic#200978 (review))): > Make sure you use descriptive names specific to the siem_migrations subdomain. Names like RulesPage, RulesTable, useRulesColumns etc are way too generic and conflict with the rule management terminology, which would make code search more difficult. * Export the memo component directly everywhere ([comment](elastic#201597 (comment))): > Could we export the memo component directly everywhere? It's shorter and it makes it easier to find the references in the IDE. * Use one hook to access APIs instead of two ([comment](elastic#202494 (comment))): > I see that for every API request we have to implement 2 separate hooks. Why don't we add error handling to the same hook that does the useQuery? so we have everything in one hook. Or is there a reason to have them separate?
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
## Summary These are the followup updated to address feedback from my previous PRs: * Make sure to use descriptive names specific to the `siem_migrations` subdomain ([comment](elastic#200978 (review))): > Make sure you use descriptive names specific to the siem_migrations subdomain. Names like RulesPage, RulesTable, useRulesColumns etc are way too generic and conflict with the rule management terminology, which would make code search more difficult. * Export the memo component directly everywhere ([comment](elastic#201597 (comment))): > Could we export the memo component directly everywhere? It's shorter and it makes it easier to find the references in the IDE. * Use one hook to access APIs instead of two ([comment](elastic#202494 (comment))): > I see that for every API request we have to implement 2 separate hooks. Why don't we add error handling to the same hook that does the useQuery? so we have everything in one hook. Or is there a reason to have them separate?
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
## Summary These are the followup updated to address feedback from my previous PRs: * Make sure to use descriptive names specific to the `siem_migrations` subdomain ([comment](elastic#200978 (review))): > Make sure you use descriptive names specific to the siem_migrations subdomain. Names like RulesPage, RulesTable, useRulesColumns etc are way too generic and conflict with the rule management terminology, which would make code search more difficult. * Export the memo component directly everywhere ([comment](elastic#201597 (comment))): > Could we export the memo component directly everywhere? It's shorter and it makes it easier to find the references in the IDE. * Use one hook to access APIs instead of two ([comment](elastic#202494 (comment))): > I see that for every API request we have to implement 2 separate hooks. Why don't we add error handling to the same hook that does the useQuery? so we have everything in one hook. Or is there a reason to have them separate?
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/kibana
that referenced
this pull request
Dec 10, 2024
## Summary These are the followup updated to address feedback from my previous PRs: * Make sure to use descriptive names specific to the `siem_migrations` subdomain ([comment](elastic#200978 (review))): > Make sure you use descriptive names specific to the siem_migrations subdomain. Names like RulesPage, RulesTable, useRulesColumns etc are way too generic and conflict with the rule management terminology, which would make code search more difficult. * Export the memo component directly everywhere ([comment](elastic#201597 (comment))): > Could we export the memo component directly everywhere? It's shorter and it makes it easier to find the references in the IDE. * Use one hook to access APIs instead of two ([comment](elastic#202494 (comment))): > I see that for every API request we have to implement 2 separate hooks. Why don't we add error handling to the same hook that does the useQuery? so we have everything in one hook. Or is there a reason to have them separate?
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…elastic#11264) (elastic#201597) ## Summary [Internal link](elastic/security-team#10820) to the feature details With these changes we: * allow user to navigate to a specific migration by its id * handle different possible states on migrations rules page: * `no migrations`: if there are no existing migrations we will redirect user to the landing page * `unknown selected migration`: if unknown migration id is specified in the URL, then "Unknown Migration" page will be shown * `no selected migration`: if user lands on the root "SIEM migrations rules" page, then most recent migration will be shown * `show existing migration`: selected migration will be shown ### Screenshots **Unknown migration** <img width="1312" alt="Screenshot 2024-11-25 at 14 46 56" src="https://github.com/user-attachments/assets/45f51489-e4f8-496f-86e6-d19130bd6769"> **Show existing migration** <img width="1312" alt="Screenshot 2024-11-25 at 15 03 53" src="https://github.com/user-attachments/assets/ca866432-5a61-44c7-8bec-7aa95ba73156">
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary These are the followup updated to address feedback from my previous PRs: * Make sure to use descriptive names specific to the `siem_migrations` subdomain ([comment](elastic#200978 (review))): > Make sure you use descriptive names specific to the siem_migrations subdomain. Names like RulesPage, RulesTable, useRulesColumns etc are way too generic and conflict with the rule management terminology, which would make code search more difficult. * Export the memo component directly everywhere ([comment](elastic#201597 (comment))): > Could we export the memo component directly everywhere? It's shorter and it makes it easier to find the references in the IDE. * Use one hook to access APIs instead of two ([comment](elastic#202494 (comment))): > I see that for every API request we have to implement 2 separate hooks. Why don't we add error handling to the same hook that does the useQuery? so we have everything in one hook. Or is there a reason to have them separate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Internal link to the feature details
With these changes we:
no migrations: if there are no existing migrations we will redirect user to the landing pageunknown selected migration: if unknown migration id is specified in the URL, then "Unknown Migration" page will be shownno selected migration: if user lands on the root "SIEM migrations rules" page, then most recent migration will be shownshow existing migration: selected migration will be shownScreenshots
Unknown migration
Show existing migration