[Rules migration] Post merge feedback followups (elastic#202815)

## Summary These are the followup updated to address feedback from my previous PRs: * Make sure to use descriptive names specific to the `siem_migrations` subdomain ([comment](elastic#200978 (review))): > Make sure you use descriptive names specific to the siem_migrations subdomain. Names like RulesPage, RulesTable, useRulesColumns etc are way too generic and conflict with the rule management terminology, which would make code search more difficult. * Export the memo component directly everywhere ([comment](elastic#201597 (comment))): > Could we export the memo component directly everywhere? It's shorter and it makes it easier to find the references in the IDE. * Use one hook to access APIs instead of two ([comment](elastic#202494 (comment))): > I see that for every API request we have to implement 2 separate hooks. Why don't we add error handling to the same hook that does the useQuery? so we have everything in one hook. Or is there a reason to have them separate?
SoniaSanzV · Dec 9, 2024 · 0ed26d3 · 0ed26d3
1 parent abb61c9
commit 0ed26d3
Show file tree

Hide file tree

Showing 35 changed files with 730 additions and 848 deletions.
diff --git a/x-pack/plugins/security_solution/common/siem_migrations/constants.ts b/x-pack/plugins/security_solution/common/siem_migrations/constants.ts
@@ -46,3 +46,11 @@ export enum SiemMigrationRuleTranslationResult {
 
 export const DEFAULT_TRANSLATION_RISK_SCORE = 21;
 export const DEFAULT_TRANSLATION_SEVERITY: Severity = 'low';
+
+export const DEFAULT_TRANSLATION_FIELDS = {
+  risk_score: DEFAULT_TRANSLATION_RISK_SCORE,
+  severity: DEFAULT_TRANSLATION_SEVERITY,
+  from: 'now-360s',
+  to: 'now',
+  interval: '5m',
+} as const;
diff --git a/x-pack/plugins/security_solution/public/siem_migrations/routes.tsx b/x-pack/plugins/security_solution/public/siem_migrations/routes.tsx
@@ -10,16 +10,19 @@ import { Routes, Route } from '@kbn/shared-ux-router';
 
 import type { SecuritySubPluginRoutes } from '../app/types';
 import { SIEM_MIGRATIONS_RULES_PATH, SecurityPageName } from '../../common/constants';
-import { RulesPage } from './rules/pages';
+import { MigrationRulesPage } from './rules/pages';
 import { PluginTemplateWrapper } from '../common/components/plugin_template_wrapper';
 import { SecurityRoutePageWrapper } from '../common/components/security_route_page_wrapper';
 
-export const RulesRoutes = () => {
+export const SiemMigrationsRoutes = () => {
   return (
     <PluginTemplateWrapper>
       <SecurityRoutePageWrapper pageName={SecurityPageName.siemMigrationsRules}>
         <Routes>
-          <Route path={`${SIEM_MIGRATIONS_RULES_PATH}/:migrationId?`} component={RulesPage} />
+          <Route
+            path={`${SIEM_MIGRATIONS_RULES_PATH}/:migrationId?`}
+            component={MigrationRulesPage}
+          />
         </Routes>
       </SecurityRoutePageWrapper>
     </PluginTemplateWrapper>
@@ -29,6 +32,6 @@ export const RulesRoutes = () => {
 export const routes: SecuritySubPluginRoutes = [
   {
     path: SIEM_MIGRATIONS_RULES_PATH,
-    component: RulesRoutes,
+    component: SiemMigrationsRoutes,
   },
 ];
diff --git a/...security_solution/public/siem_migrations/rules/api/hooks/use_get_migration_rules_query.ts b/...security_solution/public/siem_migrations/rules/api/hooks/use_get_migration_rules_query.ts
diff --git a/...ution/public/siem_migrations/rules/api/hooks/use_get_migration_translation_stats_query.ts b/...ution/public/siem_migrations/rules/api/hooks/use_get_migration_translation_stats_query.ts
diff --git a/...y_solution/public/siem_migrations/rules/api/hooks/use_install_migration_rules_mutation.ts b/...y_solution/public/siem_migrations/rules/api/hooks/use_install_migration_rules_mutation.ts
diff --git a/...public/siem_migrations/rules/api/hooks/use_install_translated_migration_rules_mutation.ts b/...public/siem_migrations/rules/api/hooks/use_install_translated_migration_rules_mutation.ts
diff --git a/...n/public/siem_migrations/rules/api/api.ts → ...public/siem_migrations/rules/api/index.ts b/...n/public/siem_migrations/rules/api/api.ts → ...public/siem_migrations/rules/api/index.ts
@@ -25,7 +25,6 @@ import type {
   InstallMigrationRulesResponse,
   StartRuleMigrationRequestBody,
 } from '../../../../common/siem_migrations/model/api/rules/rule_migration.gen';
-import type { InstallTranslatedRulesProps, InstallRulesProps } from '../types';
 
 /**
  * Retrieves the stats for all the existing migrations, aggregated by `migration_id`.
@@ -134,7 +133,11 @@ export const installMigrationRules = async ({
   migrationId,
   ids,
   signal,
-}: InstallRulesProps): Promise<InstallMigrationRulesResponse> => {
+}: {
+  migrationId: string;
+  ids: string[];
+  signal?: AbortSignal;
+}): Promise<InstallMigrationRulesResponse> => {
   return KibanaServices.get().http.fetch<InstallMigrationRulesResponse>(
     replaceParams(SIEM_RULE_MIGRATION_INSTALL_PATH, { migration_id: migrationId }),
     {
@@ -149,7 +152,10 @@ export const installMigrationRules = async ({
 export const installTranslatedMigrationRules = async ({
   migrationId,
   signal,
-}: InstallTranslatedRulesProps): Promise<InstallTranslatedMigrationRulesResponse> => {
+}: {
+  migrationId: string;
+  signal?: AbortSignal;
+}): Promise<InstallTranslatedMigrationRulesResponse> => {
   return KibanaServices.get().http.fetch<InstallTranslatedMigrationRulesResponse>(
     replaceParams(SIEM_RULE_MIGRATION_INSTALL_TRANSLATED_PATH, { migration_id: migrationId }),
     {