Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Marks tech preview functions in the editor #199631

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Nov 11, 2024

Summary

Closes #194062

Indicates tech preview functions in the editor.

image (62)

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #2 / Indicator match execution logic API @ess @serverless Indicator match type rules, alert suppression Code execution path: events count is smaller than threats count deduplicates new alerts if they were previously created without suppression

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-validation-autocomplete 190 191 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.4MB 13.4MB +1.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.4MB 3.4MB +1.4KB
Unknown metric groups

API count

id before after diff
@kbn/esql-validation-autocomplete 202 203 +1

@stratoula stratoula added v9.0.0 v8.17.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes labels Nov 11, 2024
@stratoula stratoula marked this pull request as ready for review November 11, 2024 14:10
@stratoula stratoula requested a review from a team as a code owner November 11, 2024 14:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula added the backport:version Backport to applied version labels label Nov 11, 2024
@stratoula stratoula merged commit dbc9e31 into elastic:main Nov 12, 2024
37 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11793072242

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 12, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 12, 2024
…199732)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Marks tech preview functions in the editor
(#199631)](#199631)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T08:04:01Z","message":"[ES|QL]
Marks tech preview functions in the editor (#199631)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/194062\r\n\r\nIndicates tech
preview functions in the
editor.\r\n\r\n![image\r\n(62)](https://github.com/user-attachments/assets/a6d2b1e8-f7c7-4bee-8a9f-3c9d5026c79e)","sha":"dbc9e31dbccd5a743c85b3a52692fd950c0aa292","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.17.0"],"title":"[ES|QL]
Marks tech preview functions in the
editor","number":199631,"url":"https://github.com/elastic/kibana/pull/199631","mergeCommit":{"message":"[ES|QL]
Marks tech preview functions in the editor (#199631)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/194062\r\n\r\nIndicates tech
preview functions in the
editor.\r\n\r\n![image\r\n(62)](https://github.com/user-attachments/assets/a6d2b1e8-f7c7-4bee-8a9f-3c9d5026c79e)","sha":"dbc9e31dbccd5a743c85b3a52692fd950c0aa292"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199631","number":199631,"mergeCommit":{"message":"[ES|QL]
Marks tech preview functions in the editor (#199631)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/194062\r\n\r\nIndicates tech
preview functions in the
editor.\r\n\r\n![image\r\n(62)](https://github.com/user-attachments/assets/a6d2b1e8-f7c7-4bee-8a9f-3c9d5026c79e)","sha":"dbc9e31dbccd5a743c85b3a52692fd950c0aa292"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <[email protected]>
@ryankeairns
Copy link
Contributor

I love nice, simple solutions like this :)

tkajtoch pushed a commit to tkajtoch/kibana that referenced this pull request Nov 12, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ES|QL] indicate technical preview functions in the editor
5 participants