Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] indicate technical preview functions in the editor #194062

Closed
drewdaemon opened this issue Sep 25, 2024 · 6 comments · Fixed by #199631
Closed

[ES|QL] indicate technical preview functions in the editor #194062

drewdaemon opened this issue Sep 25, 2024 · 6 comments · Fixed by #199631
Assignees
@stratoula
Labels
enhancement New value added to drive a business result Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana

Comments

@drewdaemon
Copy link
Contributor

drewdaemon commented Sep 25, 2024 •
edited
Loading

Describe the feature:
Some functions are available, but still in technical preview. We should indicate this somehow in the editor (possibly the suggestions list)? We should also consider indicating this in our inline documentation.

Elasticsearch is attaching this information to the function metadata as of elastic/elasticsearch#112792.

It is up to us to figure out how we want to translate this into editor signifiers.
@drewdaemon drewdaemon added enhancement New value added to drive a business result Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana labels Sep 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula
Copy link
Contributor

stratoula commented Sep 26, 2024 •
edited
Loading

On the suggestions list we can't do a lot of things rather than a text. Do we even have the space?

We can be more creative on the field popover though

Image

@drewdaemon
Copy link
Contributor Author

drewdaemon commented Sep 26, 2024 •
edited
Loading

This could be an application for font-based icons like I played with here (not sure if it would go in the suggestions list or elsewhere).

@drewdaemon drewdaemon mentioned this issue Sep 30, 2024
Closed
@stratoula
Copy link
Contributor

@ryankeairns what do you suggest to do here?

Now it looks like that Image

and we want to mark this as a tech preview with some way.

The icons that Drew PoCed is not so simple as we need to transform an icon as a font to work. Maybe we can explore an easier avenue? As easy as adding a [Technical Preview] in front as we also do in the Advanced settings section for example? It is easier to do and more self explanatory than an icon.

@ryankeairns
Copy link
Contributor

@ryankeairns what do you suggest to do here?

Now it looks like that

and we want to mark this as a tech preview with some way.

The icons that Drew PoCed is not so simple as we need to transform an icon as a font to work. Maybe we can explore an easier avenue? As easy as adding a [Technical Preview] in front as we also do in the Advanced settings section for example? It is easier to do and more self explanatory than an icon.

+1 that seems like the most practical thing to do.
In effect, you would see [Technical Preview] Performs a match... on the right end, correct?

@stratoula
Copy link
Contributor

yy exactly, thanx Ryan

@stratoula stratoula mentioned this issue Nov 11, 2024
Merged
@stratoula stratoula self-assigned this Nov 11, 2024
stratoula added a commit that referenced this issue Nov 12, 2024
@stratoula
[ES|QL] Marks tech preview functions in the editor (#199631)
dbc9e31 
## Summary

Closes #194062

Indicates tech preview functions in the editor.

![image
(62)](https://github.com/user-attachments/assets/a6d2b1e8-f7c7-4bee-8a9f-3c9d5026c79e)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 12, 2024
@stratoula
[ES|QL] Marks tech preview functions in the editor (elastic#199631)
99ea310 
## Summary

Closes elastic#194062

Indicates tech preview functions in the editor.

![image
(62)](https://github.com/user-attachments/assets/a6d2b1e8-f7c7-4bee-8a9f-3c9d5026c79e)

(cherry picked from commit dbc9e31)
tkajtoch pushed a commit to tkajtoch/kibana that referenced this issue Nov 12, 2024
@stratoula @tkajtoch
[ES|QL] Marks tech preview functions in the editor (elastic#199631)
e7e0f78 
## Summary

Closes elastic#194062

Indicates tech preview functions in the editor.

![image
(62)](https://github.com/user-attachments/assets/a6d2b1e8-f7c7-4bee-8a9f-3c9d5026c79e)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Nov 18, 2024
@stratoula @CAWilson94
[ES|QL] Marks tech preview functions in the editor (elastic#199631)
6ff6eec 
## Summary

Closes elastic#194062

Indicates tech preview functions in the editor.

![image
(62)](https://github.com/user-attachments/assets/a6d2b1e8-f7c7-4bee-8a9f-3c9d5026c79e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stratoula stratoula

Labels
enhancement New value added to drive a business result Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ES|QL] Marks tech preview functions in the editor stratoula/kibana
4 participants
@drewdaemon @ryankeairns @elasticmachine @stratoula