[Fleet] Ignore missing policies when fetching agent data #199325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
bug
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
added
the
release_note:skip
kpollich
approved these changes
Nov 7, 2024
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11727209788 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 7, 2024
) (cherry picked from commit 52d7eaf)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 7, 2024
) (cherry picked from commit 52d7eaf)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 7, 2024
) (#199348) # Backport This will backport the following commits from `main` to `8.16`: - [[Fleet] Ignore missing policies when fetching agent data (#199325)](#199325) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-07T16:29:37Z","message":"[Fleet] Ignore missing policies when fetching agent data (#199325)","sha":"52d7eaf6d71775f7e25f5661175e2d4603164f00","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Fleet] Ignore missing policies when fetching agent data","number":199325,"url":"https://github.com/elastic/kibana/pull/199325","mergeCommit":{"message":"[Fleet] Ignore missing policies when fetching agent data (#199325)","sha":"52d7eaf6d71775f7e25f5661175e2d4603164f00"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199325","number":199325,"mergeCommit":{"message":"[Fleet] Ignore missing policies when fetching agent data (#199325)","sha":"52d7eaf6d71775f7e25f5661175e2d4603164f00"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 7, 2024
…) (#199349) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Ignore missing policies when fetching agent data (#199325)](#199325) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-07T16:29:37Z","message":"[Fleet] Ignore missing policies when fetching agent data (#199325)","sha":"52d7eaf6d71775f7e25f5661175e2d4603164f00","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Fleet] Ignore missing policies when fetching agent data","number":199325,"url":"https://github.com/elastic/kibana/pull/199325","mergeCommit":{"message":"[Fleet] Ignore missing policies when fetching agent data (#199325)","sha":"52d7eaf6d71775f7e25f5661175e2d4603164f00"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199325","number":199325,"mergeCommit":{"message":"[Fleet] Ignore missing policies when fetching agent data (#199325)","sha":"52d7eaf6d71775f7e25f5661175e2d4603164f00"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 8, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 8, 2024
|
This PR didn't make it on time to the latest 8.16.0 BC. Updating the labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #191661 we changed the way we fetch agent policies, we do not fetch all policies with all package policies anymore but do a bulk get call to load the needed policies.
That PR fix that call to still be able to render the agent list table if a policy is missing.
Test
How to test? You can enroll an agent and delete the related agent policies saved objects