[Fleet] Stop fetching all full or with agentCount agent policies #191661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
/ci |
nchaulet
force-pushed
the
feature-remove-fetching-all-policies-server-side
branch
from
36fca6b to
df8b1ce
Compare
|
/ci |
|
/ci |
nchaulet
added
release_note:skip
nchaulet
force-pushed
the
feature-remove-fetching-all-policies-server-side
branch
from
3216a30 to
1fec585
Compare
|
/ci |
|
Pinging @elastic/fleet (Team:Fleet) |
x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/index.tsx
Outdated
Show resolved
Hide resolved
…policy/list_page/index.tsx Co-authored-by: Julia Bardi <[email protected]>
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @nchaulet |
kibanamachine
added
v8.16.0
backport:skip
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to https://github.com/elastic/ingest-dev/issues/3343
Currently the Fleet UI is really slow with 500 agents policies, 1 minute loading the agent tab, same for the enrollment api keys, to be able to fully support 500 agent policies (and in the future more), we should stop fetching all the agent policies with the full flag or with agent count from the UI, as this cause very long API request and make the UI not usable. (we could still fetch them using the perPage flag).
That PR does that, by making fetching agent policies without agent count the default.
As part of that PR I also added a small script that allow to quickly generate a big number of agent policies bypassing Fleet APIs that usefull for testing.
It could be called from the Fleet plugin folder with
Why that change matter?
This is the performance of calling the agent policies endpoint with 500 agent policies (on a macbook)
With ?full and agentCount => 49s
Without ?full and no agentCount => 266ms
Questions
How can we prevent call to get all the agent policies with agent count or full to be introduced in the future?
Should we introduce a maximum validation to the
perPageon the API side iffullornoAgentCount=false?