Increase GCP button size to match Azure and AWS #199228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyracho
force-pushed
the
gcloud_shell_button_size
branch
from
d0ff537 to
24e588a
Compare
kyracho
changed the title
maxcold
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
|
/ci |
💚 Build Succeeded
Metrics [docs]
|
1 task
|
@elasticmachine run docs-build |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11729326631 |
|
CI checks passed successfully, merging the Pull Request Thank you for your contribution @kyracho! |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 7, 2024
## Summary Hi! this PR deals with issue elastic#198878 . The `RadioGroup` size for GCP was changed from `"s"` to `"m"` to match the buttons for Azure and AWS. Thanks! <img width="751" alt="Screenshot 2024-11-06 at 12 39 09 PM" src="https://github.com/user-attachments/assets/43d9c51b-1519-4065-90ca-a957a8cdbae1"> <img width="746" alt="Screenshot 2024-11-06 at 12 39 20 PM" src="https://github.com/user-attachments/assets/dced0d76-9430-43ea-a0dd-141665def411"> ### Checklist - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) (https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) - [ ] This will appear in the **Release Notes** and follow the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 074abe9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 7, 2024
) # Backport This will backport the following commits from `main` to `8.x`: - [Increase GCP button size to match Azure and AWS (#199228)](#199228) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kyra Cho","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-07T18:44:43Z","message":"Increase GCP button size to match Azure and AWS (#199228)\n\n## Summary\r\n\r\nHi! this PR deals with issue #198878 .\r\n\r\nThe `RadioGroup` size for GCP was changed from `\"s\"` to `\"m\"` to match\r\nthe buttons for Azure and AWS.\r\n\r\nThanks!\r\n\r\n<img width=\"751\" alt=\"Screenshot 2024-11-06 at 12 39 09 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/43d9c51b-1519-4065-90ca-a957a8cdbae1\">\r\n<img width=\"746\" alt=\"Screenshot 2024-11-06 at 12 39 20 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/dced0d76-9430-43ea-a0dd-141665def411\">\r\n\r\n\r\n\r\n### Checklist\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n\r\n(https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n### For maintainers\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n- [ ] This will appear in the **Release Notes** and follow the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"074abe94a1f8202b57903d5c23adf99c28fe3262","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","💝community","v9.0.0","Team:Cloud Security","backport:prev-minor","v8.17.0"],"title":"Increase GCP button size to match Azure and AWS","number":199228,"url":"https://github.com/elastic/kibana/pull/199228","mergeCommit":{"message":"Increase GCP button size to match Azure and AWS (#199228)\n\n## Summary\r\n\r\nHi! this PR deals with issue #198878 .\r\n\r\nThe `RadioGroup` size for GCP was changed from `\"s\"` to `\"m\"` to match\r\nthe buttons for Azure and AWS.\r\n\r\nThanks!\r\n\r\n<img width=\"751\" alt=\"Screenshot 2024-11-06 at 12 39 09 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/43d9c51b-1519-4065-90ca-a957a8cdbae1\">\r\n<img width=\"746\" alt=\"Screenshot 2024-11-06 at 12 39 20 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/dced0d76-9430-43ea-a0dd-141665def411\">\r\n\r\n\r\n\r\n### Checklist\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n\r\n(https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n### For maintainers\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n- [ ] This will appear in the **Release Notes** and follow the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"074abe94a1f8202b57903d5c23adf99c28fe3262"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199228","number":199228,"mergeCommit":{"message":"Increase GCP button size to match Azure and AWS (#199228)\n\n## Summary\r\n\r\nHi! this PR deals with issue #198878 .\r\n\r\nThe `RadioGroup` size for GCP was changed from `\"s\"` to `\"m\"` to match\r\nthe buttons for Azure and AWS.\r\n\r\nThanks!\r\n\r\n<img width=\"751\" alt=\"Screenshot 2024-11-06 at 12 39 09 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/43d9c51b-1519-4065-90ca-a957a8cdbae1\">\r\n<img width=\"746\" alt=\"Screenshot 2024-11-06 at 12 39 20 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/dced0d76-9430-43ea-a0dd-141665def411\">\r\n\r\n\r\n\r\n### Checklist\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n\r\n(https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n### For maintainers\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n- [ ] This will appear in the **Release Notes** and follow the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"074abe94a1f8202b57903d5c23adf99c28fe3262"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kyra Cho <[email protected]>
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 8, 2024
## Summary Hi! this PR deals with issue elastic#198878 . The `RadioGroup` size for GCP was changed from `"s"` to `"m"` to match the buttons for Azure and AWS. Thanks! <img width="751" alt="Screenshot 2024-11-06 at 12 39 09 PM" src="https://github.com/user-attachments/assets/43d9c51b-1519-4065-90ca-a957a8cdbae1"> <img width="746" alt="Screenshot 2024-11-06 at 12 39 20 PM" src="https://github.com/user-attachments/assets/dced0d76-9430-43ea-a0dd-141665def411"> ### Checklist - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) (https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) - [ ] This will appear in the **Release Notes** and follow the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 8, 2024
## Summary Hi! this PR deals with issue elastic#198878 . The `RadioGroup` size for GCP was changed from `"s"` to `"m"` to match the buttons for Azure and AWS. Thanks! <img width="751" alt="Screenshot 2024-11-06 at 12 39 09 PM" src="https://github.com/user-attachments/assets/43d9c51b-1519-4065-90ca-a957a8cdbae1"> <img width="746" alt="Screenshot 2024-11-06 at 12 39 20 PM" src="https://github.com/user-attachments/assets/dced0d76-9430-43ea-a0dd-141665def411"> ### Checklist - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) (https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) - [ ] This will appear in the **Release Notes** and follow the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi! this PR deals with issue #198878 .
The
RadioGroupsize for GCP was changed from"s"to"m"to match the buttons for Azure and AWS.Thanks!
Checklist
(https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
For maintainers