Skip to content

Commit

Permalink
[8.x] Increase GCP button size to match Azure and AWS (#199228) (#199367
Browse files Browse the repository at this point in the history
)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Increase GCP button size to match Azure and AWS
(#199228)](#199228)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kyra
Cho","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-07T18:44:43Z","message":"Increase
GCP button size to match Azure and AWS (#199228)\n\n##
Summary\r\n\r\nHi! this PR deals with issue #198878 .\r\n\r\nThe
`RadioGroup` size for GCP was changed from `\"s\"` to `\"m\"` to
match\r\nthe buttons for Azure and AWS.\r\n\r\nThanks!\r\n\r\n<img
width=\"751\" alt=\"Screenshot 2024-11-06 at 12 39
09 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/43d9c51b-1519-4065-90ca-a957a8cdbae1\">\r\n<img
width=\"746\" alt=\"Screenshot 2024-11-06 at 12 39
20 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/dced0d76-9430-43ea-a0dd-141665def411\">\r\n\r\n\r\n\r\n###
Checklist\r\n- [x] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n\r\n(https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"074abe94a1f8202b57903d5c23adf99c28fe3262","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","💝community","v9.0.0","Team:Cloud
Security","backport:prev-minor","v8.17.0"],"title":"Increase GCP button
size to match Azure and
AWS","number":199228,"url":"https://github.com/elastic/kibana/pull/199228","mergeCommit":{"message":"Increase
GCP button size to match Azure and AWS (#199228)\n\n##
Summary\r\n\r\nHi! this PR deals with issue #198878 .\r\n\r\nThe
`RadioGroup` size for GCP was changed from `\"s\"` to `\"m\"` to
match\r\nthe buttons for Azure and AWS.\r\n\r\nThanks!\r\n\r\n<img
width=\"751\" alt=\"Screenshot 2024-11-06 at 12 39
09 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/43d9c51b-1519-4065-90ca-a957a8cdbae1\">\r\n<img
width=\"746\" alt=\"Screenshot 2024-11-06 at 12 39
20 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/dced0d76-9430-43ea-a0dd-141665def411\">\r\n\r\n\r\n\r\n###
Checklist\r\n- [x] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n\r\n(https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"074abe94a1f8202b57903d5c23adf99c28fe3262"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199228","number":199228,"mergeCommit":{"message":"Increase
GCP button size to match Azure and AWS (#199228)\n\n##
Summary\r\n\r\nHi! this PR deals with issue #198878 .\r\n\r\nThe
`RadioGroup` size for GCP was changed from `\"s\"` to `\"m\"` to
match\r\nthe buttons for Azure and AWS.\r\n\r\nThanks!\r\n\r\n<img
width=\"751\" alt=\"Screenshot 2024-11-06 at 12 39
09 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/43d9c51b-1519-4065-90ca-a957a8cdbae1\">\r\n<img
width=\"746\" alt=\"Screenshot 2024-11-06 at 12 39
20 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/dced0d76-9430-43ea-a0dd-141665def411\">\r\n\r\n\r\n\r\n###
Checklist\r\n- [x] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n\r\n(https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n-
[ ] This will appear in the **Release Notes** and follow
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"074abe94a1f8202b57903d5c23adf99c28fe3262"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Kyra Cho <[email protected]>
  • Loading branch information
kibanamachine and kyracho authored Nov 7, 2024
1 parent ca3aa4d commit 51c3d76
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ export const GcpCredentialsForm = ({
<EuiSpacer size="l" />
<RadioGroup
disabled={disabled}
size="s"
size="m"
options={getSetupFormatOptions()}
idSelected={setupFormat}
onChange={(idSelected: SetupFormatGCP) =>
Expand Down

0 comments on commit 51c3d76

Please sign in to comment.