Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [SecuritySolution] Fix issue with duplicate timeline reloading (#198652) #199144

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

janmonschke
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…ic#198652)

Fixes: elastic#173240

Unsaved duplicated timelines will now show the save notification when
the user is trying to leave security solution without saving.

The PR also re-enables the `unsaved_timelines` cypress tests.

https://github.com/user-attachments/assets/429d23fc-0cd5-4f0a-bcc9-0fd025856b6e

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit bde5e11)
@janmonschke janmonschke merged commit 5194e64 into elastic:8.x Nov 6, 2024
37 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #2 / ShowMoreButton calls onShowMoreClick on button click

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.0MB 21.0MB -20.0B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants