[SecuritySolution] Fix issue with duplicate timeline reloading #198652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if not, we might lose the duplicated timeline when not saved and trying to reload
janmonschke
added
release_note:fix
Team:Threat Hunting:Investigations
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
|
@elasticmachine merge upstream |
….com/janmonschke/kibana into securitiy/fix-duplicate-reload-issue
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
There was a problem hiding this comment.
the code looks good, but I looked at the ticket and this does not really fix that specific issue (though is related). I think the behavior mentioned in the ticket was fixed between December 2023 and now, as I cannot reproduce on main.
Would you be ok changing the fixes to related to in the PR description to be super specific?
Also I feel like it would be safer to run the flaky test runner for the file that re-enables the Cypress tests? Wdyt?
|
Flaky test runner (❌ ) @PhilippeOberti yep, there was some confusion there because the original ticket wasn't closed and this fix should've been its own ticket. More context: #173240 (comment) |
|
The flaky test runner is all red, but it seems that it's because of issues unrelated to any actual tests. Can you run it again? |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7340[✅] Security Solution Investigations - Cypress: 25/25 tests passed. |
This reverts commit d774ff4.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7332[❌] Security Solution Investigations - Cypress: 0/25 tests passed. |
PhilippeOberti
approved these changes
Nov 5, 2024
|
Approved even if the last flaky test runner failed. It failed for a different reason |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11699372202 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
janmonschke
added a commit
to janmonschke/kibana
that referenced
this pull request
Nov 6, 2024
…ic#198652) Fixes: elastic#173240 Unsaved duplicated timelines will now show the save notification when the user is trying to leave security solution without saving. The PR also re-enables the `unsaved_timelines` cypress tests. https://github.com/user-attachments/assets/429d23fc-0cd5-4f0a-bcc9-0fd025856b6e - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit bde5e11)
janmonschke
added a commit
that referenced
this pull request
Nov 6, 2024
…198652) (#199144) # Backport This will backport the following commits from `main` to `8.x`: - [[SecuritySolution] Fix issue with duplicate timeline reloading (#198652)](#198652) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jan Monschke","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-06T07:55:19Z","message":"[SecuritySolution] Fix issue with duplicate timeline reloading (#198652)\n\n## Summary\r\n\r\nFixes: https://github.com/elastic/kibana/issues/173240\r\n\r\nUnsaved duplicated timelines will now show the save notification when\r\nthe user is trying to leave security solution without saving.\r\n\r\nThe PR also re-enables the `unsaved_timelines` cypress tests.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/429d23fc-0cd5-4f0a-bcc9-0fd025856b6e\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"bde5e11526c222dd0697dbeb092b8f53dbd2c859","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Threat Hunting:Investigations","backport:prev-minor"],"number":198652,"url":"https://github.com/elastic/kibana/pull/198652","mergeCommit":{"message":"[SecuritySolution] Fix issue with duplicate timeline reloading (#198652)\n\n## Summary\r\n\r\nFixes: https://github.com/elastic/kibana/issues/173240\r\n\r\nUnsaved duplicated timelines will now show the save notification when\r\nthe user is trying to leave security solution without saving.\r\n\r\nThe PR also re-enables the `unsaved_timelines` cypress tests.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/429d23fc-0cd5-4f0a-bcc9-0fd025856b6e\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"bde5e11526c222dd0697dbeb092b8f53dbd2c859"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198652","number":198652,"mergeCommit":{"message":"[SecuritySolution] Fix issue with duplicate timeline reloading (#198652)\n\n## Summary\r\n\r\nFixes: https://github.com/elastic/kibana/issues/173240\r\n\r\nUnsaved duplicated timelines will now show the save notification when\r\nthe user is trying to leave security solution without saving.\r\n\r\nThe PR also re-enables the `unsaved_timelines` cypress tests.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/429d23fc-0cd5-4f0a-bcc9-0fd025856b6e\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"bde5e11526c222dd0697dbeb092b8f53dbd2c859"}}]}] BACKPORT-->
mgadewoll
pushed a commit
to mgadewoll/kibana
that referenced
this pull request
Nov 7, 2024
…ic#198652) ## Summary Fixes: elastic#173240 Unsaved duplicated timelines will now show the save notification when the user is trying to leave security solution without saving. The PR also re-enables the `unsaved_timelines` cypress tests. https://github.com/user-attachments/assets/429d23fc-0cd5-4f0a-bcc9-0fd025856b6e ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <[email protected]>
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #173240
Unsaved duplicated timelines will now show the save notification when the user is trying to leave security solution without saving.
The PR also re-enables the
unsaved_timelinescypress tests.Screen.Recording.2024-11-01.at.20.15.36.mov
Checklist