[Observability] Fix integrations detected twice #198670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomheymann
added
release_note:skip
flash1293
reviewed
Nov 4, 2024
| @@ -34,9 +34,9 @@ patterns= | |||
| title=PostgreSQL | |||
| patterns= | |||
| /var/log/postgresql/postgresql-*-*.log* | |||
| /var/log/postgresql/postgresql-*-*.csv* | |||
There was a problem hiding this comment.
why is this change important?
There was a problem hiding this comment.
postres integration has this pattern in its data stream manifest, we need to detect it as well
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Pinging @elastic/obs-ux-onboarding-team (Feature: Observability Onboarding) |
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
mykolaharmash
approved these changes
Nov 6, 2024
⏳ Build in-progress
History
|
flash1293
added
release_note:fix
and removed
release_note:skip
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11708248378 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 6, 2024
Resolves [elastic#195912](elastic#195912) ## Summary Fixes an issue where integrations were displayed twice in the list of detected log files. Co-authored-by: Joe Reuter <[email protected]> (cherry picked from commit f410085)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 6, 2024
Resolves [elastic#195912](elastic#195912) ## Summary Fixes an issue where integrations were displayed twice in the list of detected log files. Co-authored-by: Joe Reuter <[email protected]> (cherry picked from commit f410085)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 6, 2024
) # Backport This will backport the following commits from `main` to `8.x`: - [[Observability] Fix integrations detected twice (#198670)](#198670) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Thom Heymann","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-06T16:55:33Z","message":"[Observability] Fix integrations detected twice (#198670)\n\nResolves [#195912](https://github.com/elastic/kibana/issues/195912)\r\n\r\n## Summary\r\n\r\nFixes an issue where integrations were displayed twice in the list of\r\ndetected log files.\r\n\r\nCo-authored-by: Joe Reuter <[email protected]>","sha":"f410085ffc6e37f284ff72b034ca177f536f7121","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs","Feature: Observability Onboarding","v8.16.0","v8.17.0"],"title":"[Observability] Fix integrations detected twice","number":198670,"url":"https://github.com/elastic/kibana/pull/198670","mergeCommit":{"message":"[Observability] Fix integrations detected twice (#198670)\n\nResolves [#195912](https://github.com/elastic/kibana/issues/195912)\r\n\r\n## Summary\r\n\r\nFixes an issue where integrations were displayed twice in the list of\r\ndetected log files.\r\n\r\nCo-authored-by: Joe Reuter <[email protected]>","sha":"f410085ffc6e37f284ff72b034ca177f536f7121"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198670","number":198670,"mergeCommit":{"message":"[Observability] Fix integrations detected twice (#198670)\n\nResolves [#195912](https://github.com/elastic/kibana/issues/195912)\r\n\r\n## Summary\r\n\r\nFixes an issue where integrations were displayed twice in the list of\r\ndetected log files.\r\n\r\nCo-authored-by: Joe Reuter <[email protected]>","sha":"f410085ffc6e37f284ff72b034ca177f536f7121"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Thom Heymann <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 6, 2024
…9183) # Backport This will backport the following commits from `main` to `8.16`: - [[Observability] Fix integrations detected twice (#198670)](#198670) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Thom Heymann","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-06T16:55:33Z","message":"[Observability] Fix integrations detected twice (#198670)\n\nResolves [#195912](https://github.com/elastic/kibana/issues/195912)\r\n\r\n## Summary\r\n\r\nFixes an issue where integrations were displayed twice in the list of\r\ndetected log files.\r\n\r\nCo-authored-by: Joe Reuter <[email protected]>","sha":"f410085ffc6e37f284ff72b034ca177f536f7121","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs","Feature: Observability Onboarding","v8.16.0","v8.17.0"],"title":"[Observability] Fix integrations detected twice","number":198670,"url":"https://github.com/elastic/kibana/pull/198670","mergeCommit":{"message":"[Observability] Fix integrations detected twice (#198670)\n\nResolves [#195912](https://github.com/elastic/kibana/issues/195912)\r\n\r\n## Summary\r\n\r\nFixes an issue where integrations were displayed twice in the list of\r\ndetected log files.\r\n\r\nCo-authored-by: Joe Reuter <[email protected]>","sha":"f410085ffc6e37f284ff72b034ca177f536f7121"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198670","number":198670,"mergeCommit":{"message":"[Observability] Fix integrations detected twice (#198670)\n\nResolves [#195912](https://github.com/elastic/kibana/issues/195912)\r\n\r\n## Summary\r\n\r\nFixes an issue where integrations were displayed twice in the list of\r\ndetected log files.\r\n\r\nCo-authored-by: Joe Reuter <[email protected]>","sha":"f410085ffc6e37f284ff72b034ca177f536f7121"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Thom Heymann <[email protected]>
mgadewoll
pushed a commit
to mgadewoll/kibana
that referenced
this pull request
Nov 7, 2024
Resolves [elastic#195912](elastic#195912) ## Summary Fixes an issue where integrations were displayed twice in the list of detected log files. Co-authored-by: Joe Reuter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #195912
Summary
Fixes an issue where integrations were displayed twice in the list of detected log files.