Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability Onboarding] Auto-detect flow: Postgres detected twice #195912

Closed
flash1293 opened this issue Oct 11, 2024 · 5 comments · Fixed by #198670 or #199237
Closed

[Observability Onboarding] Auto-detect flow: Postgres detected twice #195912

flash1293 opened this issue Oct 11, 2024 · 5 comments · Fixed by #198670 or #199237
Assignees
@thomheymann
Labels
bug Fixes for quality problems that affect the customer experience Feature: Observability Onboarding Team:obs-ux-logs Observability Logs User Experience Team

Comments

@flash1293
Copy link
Contributor

When going through the onboarding flow on 8.16 snapshot on a debian with postgres installed, it seems like postgres logs are detected as both custom logs and via the integration:
Image

If it's about the same paths, it should only detect one, not both at the same time
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 11, 2024
@flash1293 flash1293 added Team:obs-ux-logs Observability Logs User Experience Team Feature: Observability Onboarding and removed needs-team Issues missing a team label labels Oct 11, 2024
@flash1293 flash1293 self-assigned this Oct 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-onboarding-team (Feature: Observability Onboarding)

@flash1293 flash1293 added the bug Fixes for quality problems that affect the customer experience label Oct 11, 2024
@thomheymann
Copy link
Contributor

@flash1293 What log files do you have in your Postgres root folder? The PostgreSQL integration is only detecting the following patterns:

paths:
  - /var/log/postgresql/postgresql-*-*.log*
  - /var/log/postgresql/postgresql-*-*.csv*

@thomheymann thomheymann mentioned this issue Nov 1, 2024
Merged
@thomheymann thomheymann self-assigned this Nov 1, 2024
@flash1293
Copy link
Contributor Author

@thomheymann I have this kind of files in there:

  • postgresql-15-main.log
  • postgresql-15-main.log.2.gz
  • postgresql-15-main.log.1
  • postgresql-15-main.log.3.gz

flash1293 added a commit that referenced this issue Nov 6, 2024
@thomheymann @flash1293
[Observability] Fix integrations detected twice (#198670)
f410085 
Resolves [#195912](#195912)

## Summary

Fixes an issue where integrations were displayed twice in the list of
detected log files.

Co-authored-by: Joe Reuter <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 6, 2024
@thomheymann
[Observability] Fix integrations detected twice (elastic#198670)
9be9647 
Resolves [elastic#195912](elastic#195912)

## Summary

Fixes an issue where integrations were displayed twice in the list of
detected log files.

Co-authored-by: Joe Reuter <[email protected]>
(cherry picked from commit f410085)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 6, 2024
@thomheymann
[Observability] Fix integrations detected twice (elastic#198670)
e5aad9a 
Resolves [elastic#195912](elastic#195912)

## Summary

Fixes an issue where integrations were displayed twice in the list of
detected log files.

Co-authored-by: Joe Reuter <[email protected]>
(cherry picked from commit f410085)
kibanamachine added a commit that referenced this issue Nov 6, 2024
@kibanamachine @thomheymann
[8.x] [Observability] Fix integrations detected twice (#198670) (#199184
d8b6009 
)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Observability] Fix integrations detected twice
(#198670)](#198670)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Thom
Heymann","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-06T16:55:33Z","message":"[Observability]
Fix integrations detected twice (#198670)\n\nResolves
[#195912](https://github.com/elastic/kibana/issues/195912)\r\n\r\n##
Summary\r\n\r\nFixes an issue where integrations were displayed twice in
the list of\r\ndetected log files.\r\n\r\nCo-authored-by: Joe Reuter
<[email protected]>","sha":"f410085ffc6e37f284ff72b034ca177f536f7121","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs","Feature:
Observability Onboarding","v8.16.0","v8.17.0"],"title":"[Observability]
Fix integrations detected
twice","number":198670,"url":"https://github.com/elastic/kibana/pull/198670","mergeCommit":{"message":"[Observability]
Fix integrations detected twice (#198670)\n\nResolves
[#195912](https://github.com/elastic/kibana/issues/195912)\r\n\r\n##
Summary\r\n\r\nFixes an issue where integrations were displayed twice in
the list of\r\ndetected log files.\r\n\r\nCo-authored-by: Joe Reuter
<[email protected]>","sha":"f410085ffc6e37f284ff72b034ca177f536f7121"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198670","number":198670,"mergeCommit":{"message":"[Observability]
Fix integrations detected twice (#198670)\n\nResolves
[#195912](https://github.com/elastic/kibana/issues/195912)\r\n\r\n##
Summary\r\n\r\nFixes an issue where integrations were displayed twice in
the list of\r\ndetected log files.\r\n\r\nCo-authored-by: Joe Reuter
<[email protected]>","sha":"f410085ffc6e37f284ff72b034ca177f536f7121"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Thom Heymann <[email protected]>
kibanamachine added a commit that referenced this issue Nov 6, 2024
@kibanamachine @thomheymann
[8.16] [Observability] Fix integrations detected twice (#198670) (#19…
e3e6bd7 
…9183)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Observability] Fix integrations detected twice
(#198670)](#198670)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Thom
Heymann","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-06T16:55:33Z","message":"[Observability]
Fix integrations detected twice (#198670)\n\nResolves
[#195912](https://github.com/elastic/kibana/issues/195912)\r\n\r\n##
Summary\r\n\r\nFixes an issue where integrations were displayed twice in
the list of\r\ndetected log files.\r\n\r\nCo-authored-by: Joe Reuter
<[email protected]>","sha":"f410085ffc6e37f284ff72b034ca177f536f7121","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs","Feature:
Observability Onboarding","v8.16.0","v8.17.0"],"title":"[Observability]
Fix integrations detected
twice","number":198670,"url":"https://github.com/elastic/kibana/pull/198670","mergeCommit":{"message":"[Observability]
Fix integrations detected twice (#198670)\n\nResolves
[#195912](https://github.com/elastic/kibana/issues/195912)\r\n\r\n##
Summary\r\n\r\nFixes an issue where integrations were displayed twice in
the list of\r\ndetected log files.\r\n\r\nCo-authored-by: Joe Reuter
<[email protected]>","sha":"f410085ffc6e37f284ff72b034ca177f536f7121"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198670","number":198670,"mergeCommit":{"message":"[Observability]
Fix integrations detected twice (#198670)\n\nResolves
[#195912](https://github.com/elastic/kibana/issues/195912)\r\n\r\n##
Summary\r\n\r\nFixes an issue where integrations were displayed twice in
the list of\r\ndetected log files.\r\n\r\nCo-authored-by: Joe Reuter
<[email protected]>","sha":"f410085ffc6e37f284ff72b034ca177f536f7121"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Thom Heymann <[email protected]>
@flash1293
Copy link
Contributor Author

After some more testing I noticed that this isn't completely fixed - it still detects each docker container log as a separate log group:

Image

@flash1293 flash1293 reopened this Nov 6, 2024
@flash1293 flash1293 mentioned this issue Nov 6, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 7, 2024
@flash1293
[Observability Onboarding] fix docker integration double detection (e…
d578967 
…lastic#199237)

Closes elastic#195912

See:
elastic#195912 (comment)
(cherry picked from commit 4c61876)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 7, 2024
@flash1293
[Observability Onboarding] fix docker integration double detection (e…
303274f 
…lastic#199237)

Closes elastic#195912

See:
elastic#195912 (comment)
(cherry picked from commit 4c61876)
mgadewoll pushed a commit to mgadewoll/kibana that referenced this issue Nov 7, 2024
@thomheymann @flash1293 @mgadewoll
[Observability] Fix integrations detected twice (elastic#198670)
6e1551c 
Resolves [elastic#195912](elastic#195912)

## Summary

Fixes an issue where integrations were displayed twice in the list of
detected log files.

Co-authored-by: Joe Reuter <[email protected]>
mbondyra pushed a commit to mbondyra/kibana that referenced this issue Nov 8, 2024
@flash1293 @mbondyra
[Observability Onboarding] fix docker integration double detection (e…
8ac1014 
…lastic#199237)

Closes elastic#195912

See:
elastic#195912 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomheymann thomheymann

Labels
bug Fixes for quality problems that affect the customer experience Feature: Observability Onboarding Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
3 participants
@thomheymann @flash1293 @elasticmachine