[Automatic Import] Fix yarn draw-graphs command #198229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyannn
added
release_note:skip
|
Pinging @elastic/security-scalability (Team:Security-Scalability) |
💚 Build Succeeded
Metrics [docs]
cc @ilyannn |
|
@elasticmachine merge upstream |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11630261121 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 1, 2024
## Summary Fixes elastic#196425. It turns out the reason `yarn draw-graphs` produced the three-box graphs was because `.withConfig` creates an instance of RunnableInput which does not have a good way to draw itself other than as three boxes. The solution was to makes sure we are calling the original version without `.withConfig` when drawing the graphs. We still call the new version when invoking them, as demonstrated by the run names here. We are now able to generate the correct graphs for all chains. --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 0ecef0a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 1, 2024
) # Backport This will backport the following commits from `main` to `8.x`: - [[Automatic Import] Fix yarn draw-graphs command (#198229)](#198229) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ilya Nikokoshev","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-01T13:38:07Z","message":"[Automatic Import] Fix yarn draw-graphs command (#198229)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/196425.\r\n\r\nIt turns out the reason `yarn draw-graphs` produced the three-box graphs\r\nwas because `.withConfig` creates an instance of RunnableInput which does \r\nnot have a good way to draw itself other than as three boxes.\r\n\r\nThe solution was to makes sure we are calling the original version\r\nwithout `.withConfig` when drawing the graphs. We still call the new\r\nversion when invoking them, as demonstrated by the run names here.\r\n\r\nWe are now able to generate the correct graphs for all chains.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"0ecef0ab60db28d41da69a414f7db31f278261ab","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:Security-Scalability","Feature:AutomaticImport"],"title":"[Automatic Import] Fix yarn draw-graphs command","number":198229,"url":"https://github.com/elastic/kibana/pull/198229","mergeCommit":{"message":"[Automatic Import] Fix yarn draw-graphs command (#198229)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/196425.\r\n\r\nIt turns out the reason `yarn draw-graphs` produced the three-box graphs\r\nwas because `.withConfig` creates an instance of RunnableInput which does \r\nnot have a good way to draw itself other than as three boxes.\r\n\r\nThe solution was to makes sure we are calling the original version\r\nwithout `.withConfig` when drawing the graphs. We still call the new\r\nversion when invoking them, as demonstrated by the run names here.\r\n\r\nWe are now able to generate the correct graphs for all chains.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"0ecef0ab60db28d41da69a414f7db31f278261ab"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198229","number":198229,"mergeCommit":{"message":"[Automatic Import] Fix yarn draw-graphs command (#198229)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/196425.\r\n\r\nIt turns out the reason `yarn draw-graphs` produced the three-box graphs\r\nwas because `.withConfig` creates an instance of RunnableInput which does \r\nnot have a good way to draw itself other than as three boxes.\r\n\r\nThe solution was to makes sure we are calling the original version\r\nwithout `.withConfig` when drawing the graphs. We still call the new\r\nversion when invoking them, as demonstrated by the run names here.\r\n\r\nWe are now able to generate the correct graphs for all chains.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"0ecef0ab60db28d41da69a414f7db31f278261ab"}}]}] BACKPORT--> Co-authored-by: Ilya Nikokoshev <[email protected]>
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Nov 1, 2024
## Summary Fixes elastic#196425. It turns out the reason `yarn draw-graphs` produced the three-box graphs was because `.withConfig` creates an instance of RunnableInput which does not have a good way to draw itself other than as three boxes. The solution was to makes sure we are calling the original version without `.withConfig` when drawing the graphs. We still call the new version when invoking them, as demonstrated by the run names here. We are now able to generate the correct graphs for all chains. --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #196425.
It turns out the reason
yarn draw-graphsproduced the three-box graphs was because.withConfigcreates an instance of RunnableInput which does not have a good way to draw itself other than as three boxes.The solution was to makes sure we are calling the original version without
.withConfigwhen drawing the graphs. We still call the new version when invoking them, as demonstrated by the run names here:We are now able to generate the correct graphs for all chains.
Test result: ai_postgres_202410300002-1.0.0.zip
Checklist