[Automatic Import] Bug: broken yarn draw-graphs #196425
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:AutomaticImport
Team:Security-Scalability
Team label for Security Integrations Scalability Team
Comments
ilyannn
added
bug
|
Pinging @elastic/security-scalability (Team:Security-Scalability) |
1 task
ilyannn
changed the title
ilyannn
changed the title
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Nov 1, 2024
## Summary Fixes elastic#196425. It turns out the reason `yarn draw-graphs` produced the three-box graphs was because `.withConfig` creates an instance of RunnableInput which does not have a good way to draw itself other than as three boxes. The solution was to makes sure we are calling the original version without `.withConfig` when drawing the graphs. We still call the new version when invoking them, as demonstrated by the run names here. We are now able to generate the correct graphs for all chains. --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 0ecef0a)
nreese
pushed a commit
to nreese/kibana
that referenced
this issue
Nov 1, 2024
## Summary Fixes elastic#196425. It turns out the reason `yarn draw-graphs` produced the three-box graphs was because `.withConfig` creates an instance of RunnableInput which does not have a good way to draw itself other than as three boxes. The solution was to makes sure we are calling the original version without `.withConfig` when drawing the graphs. We still call the new version when invoking them, as demonstrated by the run names here. We are now able to generate the correct graphs for all chains. --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
yarn draw-graphsmysteriously stopped working (Slack discussion). We should look into that.The text was updated successfully, but these errors were encountered: