[Spaces UI] Role Editor Flyout Should Match in Roles Mgmt #198182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
release_note:skip
tsullivan
force-pushed
the
spaces/spaces-grid-fixes-iii
branch
3 times, most recently
from
f1fa117 to
ca4073a
Compare
tsullivan
changed the title
tsullivan
force-pushed
the
spaces/spaces-grid-fixes-iii
branch
8 times, most recently
from
bf7a8c4 to
29ef71e
Compare
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11935619351 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
TattdCodeMonkey
pushed a commit
to TattdCodeMonkey/kibana
that referenced
this pull request
Nov 21, 2024
…8182) ## Summary Part of elastic/kibana-team#1242 **Fixes for alignment of the Role editor flyout** 1. Remove the warning callout regarding global privileges that impact other privileges 1. Unify the info callouts regarding combination of privileges 1. set "Customize" as the default selected option when assigning new privileges 1. update placeholders for selector box when assigning privileges 1. Hide privileges controls if no spaces are selected 1. Update button group label text to "Define privileges" and align helper texts below 1. Align headers for assign/edit states 1. Remove descriptions under headers 1. Update size of info callout above button group to small 1. Reduce text size for the "Manage roles" link 1. Remove the "Additional Stack Management permissions can be found outside of this menu..." test for the Spaces Management context. **Polish fixes** 1. Remove features visible column 1. ~~Remove identifier column from spaces grid~~ 1. Fix vertical alignment of non-current space name in table 1. Ordered the listing of assigned roles during and after search 1. Removing a role from the space shows a confirmation modal 1. Update columns widths in the spaces grid 1. Remove the "By default your current view is Classic" callout ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
2 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…8182) ## Summary Part of elastic/kibana-team#1242 **Fixes for alignment of the Role editor flyout** 1. Remove the warning callout regarding global privileges that impact other privileges 1. Unify the info callouts regarding combination of privileges 1. set "Customize" as the default selected option when assigning new privileges 1. update placeholders for selector box when assigning privileges 1. Hide privileges controls if no spaces are selected 1. Update button group label text to "Define privileges" and align helper texts below 1. Align headers for assign/edit states 1. Remove descriptions under headers 1. Update size of info callout above button group to small 1. Reduce text size for the "Manage roles" link 1. Remove the "Additional Stack Management permissions can be found outside of this menu..." test for the Spaces Management context. **Polish fixes** 1. Remove features visible column 1. ~~Remove identifier column from spaces grid~~ 1. Fix vertical alignment of non-current space name in table 1. Ordered the listing of assigned roles during and after search 1. Removing a role from the space shows a confirmation modal 1. Update columns widths in the spaces grid 1. Remove the "By default your current view is Classic" callout ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
4 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
This was referenced Dec 3, 2024
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Dec 3, 2024
…8182) Part of elastic/kibana-team#1242 **Fixes for alignment of the Role editor flyout** 1. Remove the warning callout regarding global privileges that impact other privileges 1. Unify the info callouts regarding combination of privileges 1. set "Customize" as the default selected option when assigning new privileges 1. update placeholders for selector box when assigning privileges 1. Hide privileges controls if no spaces are selected 1. Update button group label text to "Define privileges" and align helper texts below 1. Align headers for assign/edit states 1. Remove descriptions under headers 1. Update size of info callout above button group to small 1. Reduce text size for the "Manage roles" link 1. Remove the "Additional Stack Management permissions can be found outside of this menu..." test for the Spaces Management context. **Polish fixes** 1. Remove features visible column 1. ~~Remove identifier column from spaces grid~~ 1. Fix vertical alignment of non-current space name in table 1. Ordered the listing of assigned roles during and after search 1. Removing a role from the space shows a confirmation modal 1. Update columns widths in the spaces grid 1. Remove the "By default your current view is Classic" callout Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit 226924e)
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Dec 3, 2024
…8182) Part of elastic/kibana-team#1242 **Fixes for alignment of the Role editor flyout** 1. Remove the warning callout regarding global privileges that impact other privileges 1. Unify the info callouts regarding combination of privileges 1. set "Customize" as the default selected option when assigning new privileges 1. update placeholders for selector box when assigning privileges 1. Hide privileges controls if no spaces are selected 1. Update button group label text to "Define privileges" and align helper texts below 1. Align headers for assign/edit states 1. Remove descriptions under headers 1. Update size of info callout above button group to small 1. Reduce text size for the "Manage roles" link 1. Remove the "Additional Stack Management permissions can be found outside of this menu..." test for the Spaces Management context. **Polish fixes** 1. Remove features visible column 1. ~~Remove identifier column from spaces grid~~ 1. Fix vertical alignment of non-current space name in table 1. Ordered the listing of assigned roles during and after search 1. Removing a role from the space shows a confirmation modal 1. Update columns widths in the spaces grid 1. Remove the "By default your current view is Classic" callout Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit 226924e)
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
tsullivan
added a commit
that referenced
this pull request
Dec 5, 2024
) (#202820) # Backport This will backport the following commits from `main` to `8.x`: - [[Spaces UI] Role Editor Flyout Should Match in Roles Mgmt (#198182)](#198182) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T14:39:41Z","message":"[Spaces UI] Role Editor Flyout Should Match in Roles Mgmt (#198182)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana-team/issues/1242\r\n\r\n**Fixes for alignment of the Role editor flyout**\r\n1. Remove the warning callout regarding global privileges that impact\r\nother privileges\r\n1. Unify the info callouts regarding combination of privileges\r\n1. set \"Customize\" as the default selected option when assigning new\r\nprivileges\r\n1. update placeholders for selector box when assigning privileges\r\n1. Hide privileges controls if no spaces are selected\r\n1. Update button group label text to \"Define privileges\" and align\r\nhelper texts below\r\n1. Align headers for assign/edit states\r\n1. Remove descriptions under headers\r\n1. Update size of info callout above button group to small\r\n1. Reduce text size for the \"Manage roles\" link\r\n1. Remove the \"Additional Stack Management permissions can be found\r\noutside of this menu...\" test for the Spaces Management context.\r\n\r\n**Polish fixes**\r\n1. Remove features visible column\r\n1. ~~Remove identifier column from spaces grid~~\r\n1. Fix vertical alignment of non-current space name in table\r\n1. Ordered the listing of assigned roles during and after search\r\n1. Removing a role from the space shows a confirmation modal\r\n1. Update columns widths in the spaces grid\r\n1. Remove the \"By default your current view is Classic\" callout\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"226924eafebff8852a67723a49e8f4fdbb6ed869","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","v9.0.0","ci:cloud-deploy","backport:version","v8.17.0"],"number":198182,"url":"https://github.com/elastic/kibana/pull/198182","mergeCommit":{"message":"[Spaces UI] Role Editor Flyout Should Match in Roles Mgmt (#198182)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana-team/issues/1242\r\n\r\n**Fixes for alignment of the Role editor flyout**\r\n1. Remove the warning callout regarding global privileges that impact\r\nother privileges\r\n1. Unify the info callouts regarding combination of privileges\r\n1. set \"Customize\" as the default selected option when assigning new\r\nprivileges\r\n1. update placeholders for selector box when assigning privileges\r\n1. Hide privileges controls if no spaces are selected\r\n1. Update button group label text to \"Define privileges\" and align\r\nhelper texts below\r\n1. Align headers for assign/edit states\r\n1. Remove descriptions under headers\r\n1. Update size of info callout above button group to small\r\n1. Reduce text size for the \"Manage roles\" link\r\n1. Remove the \"Additional Stack Management permissions can be found\r\noutside of this menu...\" test for the Spaces Management context.\r\n\r\n**Polish fixes**\r\n1. Remove features visible column\r\n1. ~~Remove identifier column from spaces grid~~\r\n1. Fix vertical alignment of non-current space name in table\r\n1. Ordered the listing of assigned roles during and after search\r\n1. Removing a role from the space shows a confirmation modal\r\n1. Update columns widths in the spaces grid\r\n1. Remove the \"By default your current view is Classic\" callout\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"226924eafebff8852a67723a49e8f4fdbb6ed869"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198182","number":198182,"mergeCommit":{"message":"[Spaces UI] Role Editor Flyout Should Match in Roles Mgmt (#198182)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana-team/issues/1242\r\n\r\n**Fixes for alignment of the Role editor flyout**\r\n1. Remove the warning callout regarding global privileges that impact\r\nother privileges\r\n1. Unify the info callouts regarding combination of privileges\r\n1. set \"Customize\" as the default selected option when assigning new\r\nprivileges\r\n1. update placeholders for selector box when assigning privileges\r\n1. Hide privileges controls if no spaces are selected\r\n1. Update button group label text to \"Define privileges\" and align\r\nhelper texts below\r\n1. Align headers for assign/edit states\r\n1. Remove descriptions under headers\r\n1. Update size of info callout above button group to small\r\n1. Reduce text size for the \"Manage roles\" link\r\n1. Remove the \"Additional Stack Management permissions can be found\r\noutside of this menu...\" test for the Spaces Management context.\r\n\r\n**Polish fixes**\r\n1. Remove features visible column\r\n1. ~~Remove identifier column from spaces grid~~\r\n1. Fix vertical alignment of non-current space name in table\r\n1. Ordered the listing of assigned roles during and after search\r\n1. Removing a role from the space shows a confirmation modal\r\n1. Update columns widths in the spaces grid\r\n1. Remove the \"By default your current view is Classic\" callout\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"226924eafebff8852a67723a49e8f4fdbb6ed869"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
tsullivan
added a commit
that referenced
this pull request
Dec 5, 2024
…8182) (#202821) # Backport This will backport the following commits from `main` to `8.17`: - [[Spaces UI] Role Editor Flyout Should Match in Roles Mgmt (#198182)](#198182) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T14:39:41Z","message":"[Spaces UI] Role Editor Flyout Should Match in Roles Mgmt (#198182)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana-team/issues/1242\r\n\r\n**Fixes for alignment of the Role editor flyout**\r\n1. Remove the warning callout regarding global privileges that impact\r\nother privileges\r\n1. Unify the info callouts regarding combination of privileges\r\n1. set \"Customize\" as the default selected option when assigning new\r\nprivileges\r\n1. update placeholders for selector box when assigning privileges\r\n1. Hide privileges controls if no spaces are selected\r\n1. Update button group label text to \"Define privileges\" and align\r\nhelper texts below\r\n1. Align headers for assign/edit states\r\n1. Remove descriptions under headers\r\n1. Update size of info callout above button group to small\r\n1. Reduce text size for the \"Manage roles\" link\r\n1. Remove the \"Additional Stack Management permissions can be found\r\noutside of this menu...\" test for the Spaces Management context.\r\n\r\n**Polish fixes**\r\n1. Remove features visible column\r\n1. ~~Remove identifier column from spaces grid~~\r\n1. Fix vertical alignment of non-current space name in table\r\n1. Ordered the listing of assigned roles during and after search\r\n1. Removing a role from the space shows a confirmation modal\r\n1. Update columns widths in the spaces grid\r\n1. Remove the \"By default your current view is Classic\" callout\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"226924eafebff8852a67723a49e8f4fdbb6ed869","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","v9.0.0","ci:cloud-deploy","backport:version","v8.17.0"],"number":198182,"url":"https://github.com/elastic/kibana/pull/198182","mergeCommit":{"message":"[Spaces UI] Role Editor Flyout Should Match in Roles Mgmt (#198182)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana-team/issues/1242\r\n\r\n**Fixes for alignment of the Role editor flyout**\r\n1. Remove the warning callout regarding global privileges that impact\r\nother privileges\r\n1. Unify the info callouts regarding combination of privileges\r\n1. set \"Customize\" as the default selected option when assigning new\r\nprivileges\r\n1. update placeholders for selector box when assigning privileges\r\n1. Hide privileges controls if no spaces are selected\r\n1. Update button group label text to \"Define privileges\" and align\r\nhelper texts below\r\n1. Align headers for assign/edit states\r\n1. Remove descriptions under headers\r\n1. Update size of info callout above button group to small\r\n1. Reduce text size for the \"Manage roles\" link\r\n1. Remove the \"Additional Stack Management permissions can be found\r\noutside of this menu...\" test for the Spaces Management context.\r\n\r\n**Polish fixes**\r\n1. Remove features visible column\r\n1. ~~Remove identifier column from spaces grid~~\r\n1. Fix vertical alignment of non-current space name in table\r\n1. Ordered the listing of assigned roles during and after search\r\n1. Removing a role from the space shows a confirmation modal\r\n1. Update columns widths in the spaces grid\r\n1. Remove the \"By default your current view is Classic\" callout\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"226924eafebff8852a67723a49e8f4fdbb6ed869"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198182","number":198182,"mergeCommit":{"message":"[Spaces UI] Role Editor Flyout Should Match in Roles Mgmt (#198182)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana-team/issues/1242\r\n\r\n**Fixes for alignment of the Role editor flyout**\r\n1. Remove the warning callout regarding global privileges that impact\r\nother privileges\r\n1. Unify the info callouts regarding combination of privileges\r\n1. set \"Customize\" as the default selected option when assigning new\r\nprivileges\r\n1. update placeholders for selector box when assigning privileges\r\n1. Hide privileges controls if no spaces are selected\r\n1. Update button group label text to \"Define privileges\" and align\r\nhelper texts below\r\n1. Align headers for assign/edit states\r\n1. Remove descriptions under headers\r\n1. Update size of info callout above button group to small\r\n1. Reduce text size for the \"Manage roles\" link\r\n1. Remove the \"Additional Stack Management permissions can be found\r\noutside of this menu...\" test for the Spaces Management context.\r\n\r\n**Polish fixes**\r\n1. Remove features visible column\r\n1. ~~Remove identifier column from spaces grid~~\r\n1. Fix vertical alignment of non-current space name in table\r\n1. Ordered the listing of assigned roles during and after search\r\n1. Removing a role from the space shows a confirmation modal\r\n1. Update columns widths in the spaces grid\r\n1. Remove the \"By default your current view is Classic\" callout\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"226924eafebff8852a67723a49e8f4fdbb6ed869"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kibanamachine
added
v8.18.0
and removed
backport missing
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…8182) ## Summary Part of elastic/kibana-team#1242 **Fixes for alignment of the Role editor flyout** 1. Remove the warning callout regarding global privileges that impact other privileges 1. Unify the info callouts regarding combination of privileges 1. set "Customize" as the default selected option when assigning new privileges 1. update placeholders for selector box when assigning privileges 1. Hide privileges controls if no spaces are selected 1. Update button group label text to "Define privileges" and align helper texts below 1. Align headers for assign/edit states 1. Remove descriptions under headers 1. Update size of info callout above button group to small 1. Reduce text size for the "Manage roles" link 1. Remove the "Additional Stack Management permissions can be found outside of this menu..." test for the Spaces Management context. **Polish fixes** 1. Remove features visible column 1. ~~Remove identifier column from spaces grid~~ 1. Fix vertical alignment of non-current space name in table 1. Ordered the listing of assigned roles during and after search 1. Removing a role from the space shows a confirmation modal 1. Update columns widths in the spaces grid 1. Remove the "By default your current view is Classic" callout ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of https://github.com/elastic/kibana-team/issues/1242
Fixes for alignment of the Role editor flyout
Polish fixes
Remove identifier column from spaces gridChecklist
Delete any items that are not applicable to this PR.