Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes visible features column from spaces grid when in serverless #194438

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Removes visible features column from spaces grid when in serverless #194438

merged 2 commits into from
Oct 3, 2024

Conversation

jeramysoucy
Copy link
Contributor

@jeramysoucy jeramysoucy commented Sep 30, 2024 •
edited
Loading

Closes #194403

Summary

Removes the 'Features visible' column from the Spaces management page grid when in serverless.

Tests

  • x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.test.tsx

Manual tesing

  • Start ES & Kibana in serverless mode, with a xpack.spaces.maxSpaces setting > 1
  • Navigate to spaces management page and verify that the 'Features visible' column is not present
  • Start ES & Kibana in stateful mode
  • Navigate to spaces management page and verify that the 'Features visible' column is present

@jeramysoucy jeramysoucy added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.16.0 labels Sep 30, 2024
@jeramysoucy jeramysoucy marked this pull request as ready for review October 1, 2024 10:36
@jeramysoucy jeramysoucy requested a review from a team as a code owner October 1, 2024 10:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@SiddharthMantri SiddharthMantri self-requested a review October 1, 2024 14:02
SiddharthMantri
SiddharthMantri approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@SiddharthMantri SiddharthMantri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran and confirmed locally

@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 3, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
spaces 254.2KB 254.2KB +25.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
spaces 30.8KB 30.9KB +91.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jeramysoucy jeramysoucy merged commit 22e3611 into elastic:main Oct 3, 2024
20 checks passed
tiansivive pushed a commit to tiansivive/kibana that referenced this pull request Oct 7, 2024
@jeramysoucy @tiansivive
Removes visible features column from spaces grid when in serverless (e…
9448673 
…lastic#194438)

Closes elastic#194403

## Summary
Removes the 'Features visible' column from the Spaces management page
grid when in serverless.

### Tests
-
x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.test.tsx

### Manual tesing
- Start ES & Kibana in serverless mode, with a `xpack.spaces.maxSpaces`
setting > 1
- Navigate to spaces management page and verify that the 'Features
visible' column is not present
- Start ES & Kibana in stateful mode
- Navigate to spaces management page and verify that the 'Features
visible' column is present
@kibanamachine kibanamachine mentioned this pull request Oct 16, 2024
Merged
This was referenced Nov 20, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiddharthMantri SiddharthMantri SiddharthMantri approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "Features visible" column in serverless
5 participants
@jeramysoucy @elasticmachine @kibana-ci @SiddharthMantri @kibanamachine