Allow empty spaces un Gsub processor #197815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoniaSanzV
added
Team:Kibana Management
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
SoniaSanzV
force-pushed
the
ingestPipelines/gsubProcessor_#191920
branch
from
3f4230c to
4e9c771
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @SoniaSanzV |
ElenaStoeva
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Thanks for working on this @SoniaSanzV! Changes lgtm, tested locally.
|
Starting backport for target branches: 8.15, 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11721789794 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 7, 2024
Closes [elastic#191920](elastic#191920) ## Summary In the pattern field of the GSUB processor, we were validating that the field is not empty. But for this case we must allow spaces as values. To fix this, I've added a second parameter `trimString` to the `emptyField` validator. If the parameter is set to true by default so the behavior of the validator doesn't change in all the fields that already use it. But when the parameter is set to false, as in this case, the entry value string is not trimmed, so it only validate to false if the field is actually empty. I also added some unit tests to make sure that this new condition doesn't break the validator. https://github.com/user-attachments/assets/049f7424-00c6-4bb2-ab89-2ce158ac4c4e #### Notes In the video it can be seen that a banner flashes when saving. It is a bug that already happened before this one. I've opened [an issue](elastic#197810) to address it. (cherry picked from commit 2f7f8e3)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 7, 2024
Closes [elastic#191920](elastic#191920) ## Summary In the pattern field of the GSUB processor, we were validating that the field is not empty. But for this case we must allow spaces as values. To fix this, I've added a second parameter `trimString` to the `emptyField` validator. If the parameter is set to true by default so the behavior of the validator doesn't change in all the fields that already use it. But when the parameter is set to false, as in this case, the entry value string is not trimmed, so it only validate to false if the field is actually empty. I also added some unit tests to make sure that this new condition doesn't break the validator. https://github.com/user-attachments/assets/049f7424-00c6-4bb2-ab89-2ce158ac4c4e #### Notes In the video it can be seen that a banner flashes when saving. It is a bug that already happened before this one. I've opened [an issue](elastic#197810) to address it. (cherry picked from commit 2f7f8e3)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 7, 2024
Closes [elastic#191920](elastic#191920) ## Summary In the pattern field of the GSUB processor, we were validating that the field is not empty. But for this case we must allow spaces as values. To fix this, I've added a second parameter `trimString` to the `emptyField` validator. If the parameter is set to true by default so the behavior of the validator doesn't change in all the fields that already use it. But when the parameter is set to false, as in this case, the entry value string is not trimmed, so it only validate to false if the field is actually empty. I also added some unit tests to make sure that this new condition doesn't break the validator. https://github.com/user-attachments/assets/049f7424-00c6-4bb2-ab89-2ce158ac4c4e #### Notes In the video it can be seen that a banner flashes when saving. It is a bug that already happened before this one. I've opened [an issue](elastic#197810) to address it. (cherry picked from commit 2f7f8e3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
ElenaStoeva
added
backport:prev-minor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11722319413 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 7, 2024
Closes [elastic#191920](elastic#191920) ## Summary In the pattern field of the GSUB processor, we were validating that the field is not empty. But for this case we must allow spaces as values. To fix this, I've added a second parameter `trimString` to the `emptyField` validator. If the parameter is set to true by default so the behavior of the validator doesn't change in all the fields that already use it. But when the parameter is set to false, as in this case, the entry value string is not trimmed, so it only validate to false if the field is actually empty. I also added some unit tests to make sure that this new condition doesn't break the validator. https://github.com/user-attachments/assets/049f7424-00c6-4bb2-ab89-2ce158ac4c4e #### Notes In the video it can be seen that a banner flashes when saving. It is a bug that already happened before this one. I've opened [an issue](elastic#197810) to address it. (cherry picked from commit 2f7f8e3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 7, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Allow empty spaces un Gsub processor (#197815)](#197815) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sonia Sanz Vivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-07T11:09:06Z","message":"Allow empty spaces un Gsub processor (#197815)\n\nCloses [#191920](https://github.com/elastic/kibana/issues/191920)\r\n\r\n## Summary\r\nIn the pattern field of the GSUB processor, we were validating that the\r\nfield is not empty. But for this case we must allow spaces as values. To\r\nfix this, I've added a second parameter `trimString` to the `emptyField`\r\nvalidator. If the parameter is set to true by default so the behavior of\r\nthe validator doesn't change in all the fields that already use it. But\r\nwhen the parameter is set to false, as in this case, the entry value\r\nstring is not trimmed, so it only validate to false if the field is\r\nactually empty. I also added some unit tests to make sure that this new\r\ncondition doesn't break the validator.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/049f7424-00c6-4bb2-ab89-2ce158ac4c4e\r\n\r\n\r\n\r\n#### Notes\r\nIn the video it can be seen that a banner flashes when saving. It is a\r\nbug that already happened before this one. I've opened [an\r\nissue](#197810) to address it.","sha":"2f7f8e34db1fe38cc3a587a753533992398df691","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","v9.0.0","Feature:Ingest Node Pipelines","backport:prev-major","v8.17.0"],"title":"Allow empty spaces un Gsub processor","number":197815,"url":"https://github.com/elastic/kibana/pull/197815","mergeCommit":{"message":"Allow empty spaces un Gsub processor (#197815)\n\nCloses [#191920](https://github.com/elastic/kibana/issues/191920)\r\n\r\n## Summary\r\nIn the pattern field of the GSUB processor, we were validating that the\r\nfield is not empty. But for this case we must allow spaces as values. To\r\nfix this, I've added a second parameter `trimString` to the `emptyField`\r\nvalidator. If the parameter is set to true by default so the behavior of\r\nthe validator doesn't change in all the fields that already use it. But\r\nwhen the parameter is set to false, as in this case, the entry value\r\nstring is not trimmed, so it only validate to false if the field is\r\nactually empty. I also added some unit tests to make sure that this new\r\ncondition doesn't break the validator.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/049f7424-00c6-4bb2-ab89-2ce158ac4c4e\r\n\r\n\r\n\r\n#### Notes\r\nIn the video it can be seen that a banner flashes when saving. It is a\r\nbug that already happened before this one. I've opened [an\r\nissue](#197810) to address it.","sha":"2f7f8e34db1fe38cc3a587a753533992398df691"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197815","number":197815,"mergeCommit":{"message":"Allow empty spaces un Gsub processor (#197815)\n\nCloses [#191920](https://github.com/elastic/kibana/issues/191920)\r\n\r\n## Summary\r\nIn the pattern field of the GSUB processor, we were validating that the\r\nfield is not empty. But for this case we must allow spaces as values. To\r\nfix this, I've added a second parameter `trimString` to the `emptyField`\r\nvalidator. If the parameter is set to true by default so the behavior of\r\nthe validator doesn't change in all the fields that already use it. But\r\nwhen the parameter is set to false, as in this case, the entry value\r\nstring is not trimmed, so it only validate to false if the field is\r\nactually empty. I also added some unit tests to make sure that this new\r\ncondition doesn't break the validator.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/049f7424-00c6-4bb2-ab89-2ce158ac4c4e\r\n\r\n\r\n\r\n#### Notes\r\nIn the video it can be seen that a banner flashes when saving. It is a\r\nbug that already happened before this one. I've opened [an\r\nissue](#197810) to address it.","sha":"2f7f8e34db1fe38cc3a587a753533992398df691"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sonia Sanz Vivas <[email protected]>
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 8, 2024
Closes [elastic#191920](elastic#191920) ## Summary In the pattern field of the GSUB processor, we were validating that the field is not empty. But for this case we must allow spaces as values. To fix this, I've added a second parameter `trimString` to the `emptyField` validator. If the parameter is set to true by default so the behavior of the validator doesn't change in all the fields that already use it. But when the parameter is set to false, as in this case, the entry value string is not trimmed, so it only validate to false if the field is actually empty. I also added some unit tests to make sure that this new condition doesn't break the validator. https://github.com/user-attachments/assets/049f7424-00c6-4bb2-ab89-2ce158ac4c4e #### Notes In the video it can be seen that a banner flashes when saving. It is a bug that already happened before this one. I've opened [an issue](elastic#197810) to address it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #191920
Summary
In the pattern field of the GSUB processor, we were validating that the field is not empty. But for this case we must allow spaces as values. To fix this, I've added a second parameter
trimStringto theemptyFieldvalidator. If the parameter is set to true by default so the behavior of the validator doesn't change in all the fields that already use it. But when the parameter is set to false, as in this case, the entry value string is not trimmed, so it only validate to false if the field is actually empty. I also added some unit tests to make sure that this new condition doesn't break the validator.GSUB.mov
Notes
In the video it can be seen that a banner flashes when saving. It is a bug that already happened before this one. I've opened an issue to address it.