Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSUB Processor in UI cannot deal with spaces as values. #191920

Closed
philippkahr opened this issue Sep 2, 2024 · 1 comment · Fixed by #197815
Closed

GSUB Processor in UI cannot deal with spaces as values. #191920

philippkahr opened this issue Sep 2, 2024 · 1 comment · Fixed by #197815
Assignees
@SoniaSanzV
Labels
bug Fixes for quality problems that affect the customer experience Feature:Ingest Node Pipelines Ingest node pipelines management good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@philippkahr
Copy link
Contributor

Kibana version: 8.15.0

Describe the bug:

Cannot create Gsub processor in ingest pipeline with a space as pattern. Over API it works, like this:

 {
        "gsub": {
          "field": "",
          "pattern": " ",
          "replacement": ""
        }
      }

Steps to reproduce:

  1. Create new pipeline
  2. Select GSUB processor
  3. Enter a single space symbol. Try to save.

Expected behavior:
That I can replace space symbols with whatever I want.

Screenshots (if relevant):

Image

Image

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:
@philippkahr philippkahr added the bug Fixes for quality problems that affect the customer experience label Sep 2, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 2, 2024
@sabarasaba sabarasaba added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Ingest Node Pipelines Ingest node pipelines management labels Sep 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 2, 2024
@alisonelizabeth alisonelizabeth added the good first issue low hanging fruit label Sep 19, 2024
@SoniaSanzV SoniaSanzV mentioned this issue Oct 25, 2024
Merged
SoniaSanzV added a commit that referenced this issue Nov 7, 2024
@SoniaSanzV
Allow empty spaces un Gsub processor (#197815)
2f7f8e3 
Closes [#191920](#191920)

## Summary
In the pattern field of the GSUB processor, we were validating that the
field is not empty. But for this case we must allow spaces as values. To
fix this, I've added a second parameter `trimString` to the `emptyField`
validator. If the parameter is set to true by default so the behavior of
the validator doesn't change in all the fields that already use it. But
when the parameter is set to false, as in this case, the entry value
string is not trimmed, so it only validate to false if the field is
actually empty. I also added some unit tests to make sure that this new
condition doesn't break the validator.


https://github.com/user-attachments/assets/049f7424-00c6-4bb2-ab89-2ce158ac4c4e



#### Notes
In the video it can be seen that a banner flashes when saving. It is a
bug that already happened before this one. I've opened [an
issue](#197810) to address it.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 7, 2024
@SoniaSanzV
Allow empty spaces un Gsub processor (elastic#197815)
8b5191e 
Closes [elastic#191920](elastic#191920)

## Summary
In the pattern field of the GSUB processor, we were validating that the
field is not empty. But for this case we must allow spaces as values. To
fix this, I've added a second parameter `trimString` to the `emptyField`
validator. If the parameter is set to true by default so the behavior of
the validator doesn't change in all the fields that already use it. But
when the parameter is set to false, as in this case, the entry value
string is not trimmed, so it only validate to false if the field is
actually empty. I also added some unit tests to make sure that this new
condition doesn't break the validator.

https://github.com/user-attachments/assets/049f7424-00c6-4bb2-ab89-2ce158ac4c4e

#### Notes
In the video it can be seen that a banner flashes when saving. It is a
bug that already happened before this one. I've opened [an
issue](elastic#197810) to address it.

(cherry picked from commit 2f7f8e3)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 7, 2024
@SoniaSanzV
Allow empty spaces un Gsub processor (elastic#197815)
906df14 
Closes [elastic#191920](elastic#191920)

## Summary
In the pattern field of the GSUB processor, we were validating that the
field is not empty. But for this case we must allow spaces as values. To
fix this, I've added a second parameter `trimString` to the `emptyField`
validator. If the parameter is set to true by default so the behavior of
the validator doesn't change in all the fields that already use it. But
when the parameter is set to false, as in this case, the entry value
string is not trimmed, so it only validate to false if the field is
actually empty. I also added some unit tests to make sure that this new
condition doesn't break the validator.

https://github.com/user-attachments/assets/049f7424-00c6-4bb2-ab89-2ce158ac4c4e

#### Notes
In the video it can be seen that a banner flashes when saving. It is a
bug that already happened before this one. I've opened [an
issue](elastic#197810) to address it.

(cherry picked from commit 2f7f8e3)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 7, 2024
@SoniaSanzV
Allow empty spaces un Gsub processor (elastic#197815)
3e04de0 
Closes [elastic#191920](elastic#191920)

## Summary
In the pattern field of the GSUB processor, we were validating that the
field is not empty. But for this case we must allow spaces as values. To
fix this, I've added a second parameter `trimString` to the `emptyField`
validator. If the parameter is set to true by default so the behavior of
the validator doesn't change in all the fields that already use it. But
when the parameter is set to false, as in this case, the entry value
string is not trimmed, so it only validate to false if the field is
actually empty. I also added some unit tests to make sure that this new
condition doesn't break the validator.

https://github.com/user-attachments/assets/049f7424-00c6-4bb2-ab89-2ce158ac4c4e

#### Notes
In the video it can be seen that a banner flashes when saving. It is a
bug that already happened before this one. I've opened [an
issue](elastic#197810) to address it.

(cherry picked from commit 2f7f8e3)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 7, 2024
@SoniaSanzV
Allow empty spaces un Gsub processor (elastic#197815)
da56aca 
Closes [elastic#191920](elastic#191920)

## Summary
In the pattern field of the GSUB processor, we were validating that the
field is not empty. But for this case we must allow spaces as values. To
fix this, I've added a second parameter `trimString` to the `emptyField`
validator. If the parameter is set to true by default so the behavior of
the validator doesn't change in all the fields that already use it. But
when the parameter is set to false, as in this case, the entry value
string is not trimmed, so it only validate to false if the field is
actually empty. I also added some unit tests to make sure that this new
condition doesn't break the validator.

https://github.com/user-attachments/assets/049f7424-00c6-4bb2-ab89-2ce158ac4c4e

#### Notes
In the video it can be seen that a banner flashes when saving. It is a
bug that already happened before this one. I've opened [an
issue](elastic#197810) to address it.

(cherry picked from commit 2f7f8e3)
kibanamachine added a commit that referenced this issue Nov 7, 2024
@kibanamachine @SoniaSanzV
[8.x] Allow empty spaces un Gsub processor (#197815) (#199293)
37e030a 
# Backport

This will backport the following commits from `main` to `8.x`:
- [Allow empty spaces un Gsub processor
(#197815)](#197815)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sonia Sanz
Vivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-07T11:09:06Z","message":"Allow
empty spaces un Gsub processor (#197815)\n\nCloses
[#191920](https://github.com/elastic/kibana/issues/191920)\r\n\r\n##
Summary\r\nIn the pattern field of the GSUB processor, we were
validating that the\r\nfield is not empty. But for this case we must
allow spaces as values. To\r\nfix this, I've added a second parameter
`trimString` to the `emptyField`\r\nvalidator. If the parameter is set
to true by default so the behavior of\r\nthe validator doesn't change in
all the fields that already use it. But\r\nwhen the parameter is set to
false, as in this case, the entry value\r\nstring is not trimmed, so it
only validate to false if the field is\r\nactually empty. I also added
some unit tests to make sure that this new\r\ncondition doesn't break
the
validator.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/049f7424-00c6-4bb2-ab89-2ce158ac4c4e\r\n\r\n\r\n\r\n####
Notes\r\nIn the video it can be seen that a banner flashes when saving.
It is a\r\nbug that already happened before this one. I've opened
[an\r\nissue](#197810) to
address
it.","sha":"2f7f8e34db1fe38cc3a587a753533992398df691","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","v9.0.0","Feature:Ingest Node
Pipelines","backport:prev-major","v8.17.0"],"title":"Allow empty spaces
un Gsub
processor","number":197815,"url":"https://github.com/elastic/kibana/pull/197815","mergeCommit":{"message":"Allow
empty spaces un Gsub processor (#197815)\n\nCloses
[#191920](https://github.com/elastic/kibana/issues/191920)\r\n\r\n##
Summary\r\nIn the pattern field of the GSUB processor, we were
validating that the\r\nfield is not empty. But for this case we must
allow spaces as values. To\r\nfix this, I've added a second parameter
`trimString` to the `emptyField`\r\nvalidator. If the parameter is set
to true by default so the behavior of\r\nthe validator doesn't change in
all the fields that already use it. But\r\nwhen the parameter is set to
false, as in this case, the entry value\r\nstring is not trimmed, so it
only validate to false if the field is\r\nactually empty. I also added
some unit tests to make sure that this new\r\ncondition doesn't break
the
validator.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/049f7424-00c6-4bb2-ab89-2ce158ac4c4e\r\n\r\n\r\n\r\n####
Notes\r\nIn the video it can be seen that a banner flashes when saving.
It is a\r\nbug that already happened before this one. I've opened
[an\r\nissue](#197810) to
address
it.","sha":"2f7f8e34db1fe38cc3a587a753533992398df691"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197815","number":197815,"mergeCommit":{"message":"Allow
empty spaces un Gsub processor (#197815)\n\nCloses
[#191920](https://github.com/elastic/kibana/issues/191920)\r\n\r\n##
Summary\r\nIn the pattern field of the GSUB processor, we were
validating that the\r\nfield is not empty. But for this case we must
allow spaces as values. To\r\nfix this, I've added a second parameter
`trimString` to the `emptyField`\r\nvalidator. If the parameter is set
to true by default so the behavior of\r\nthe validator doesn't change in
all the fields that already use it. But\r\nwhen the parameter is set to
false, as in this case, the entry value\r\nstring is not trimmed, so it
only validate to false if the field is\r\nactually empty. I also added
some unit tests to make sure that this new\r\ncondition doesn't break
the
validator.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/049f7424-00c6-4bb2-ab89-2ce158ac4c4e\r\n\r\n\r\n\r\n####
Notes\r\nIn the video it can be seen that a banner flashes when saving.
It is a\r\nbug that already happened before this one. I've opened
[an\r\nissue](#197810) to
address
it.","sha":"2f7f8e34db1fe38cc3a587a753533992398df691"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sonia Sanz Vivas <[email protected]>
mbondyra pushed a commit to mbondyra/kibana that referenced this issue Nov 8, 2024
@SoniaSanzV @mbondyra
Allow empty spaces un Gsub processor (elastic#197815)
62ba1fc 
Closes [elastic#191920](elastic#191920)

## Summary
In the pattern field of the GSUB processor, we were validating that the
field is not empty. But for this case we must allow spaces as values. To
fix this, I've added a second parameter `trimString` to the `emptyField`
validator. If the parameter is set to true by default so the behavior of
the validator doesn't change in all the fields that already use it. But
when the parameter is set to false, as in this case, the entry value
string is not trimmed, so it only validate to false if the field is
actually empty. I also added some unit tests to make sure that this new
condition doesn't break the validator.


https://github.com/user-attachments/assets/049f7424-00c6-4bb2-ab89-2ce158ac4c4e



#### Notes
In the video it can be seen that a banner flashes when saving. It is a
bug that already happened before this one. I've opened [an
issue](elastic#197810) to address it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SoniaSanzV SoniaSanzV

Labels
bug Fixes for quality problems that affect the customer experience Feature:Ingest Node Pipelines Ingest node pipelines management good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow empty spaces un Gsub processor SoniaSanzV/kibana
5 participants
@sabarasaba @alisonelizabeth @philippkahr @elasticmachine @SoniaSanzV