Validate max number of node connections #196908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoniaSanzV
added
Feature:CCR and Remote Clusters
Team:Kibana Management
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
mattkime
reviewed
Oct 20, 2024
| @@ -33261,6 +33261,7 @@ | |||
| "xpack.remoteClusters.form.errors.illegalCharacters": "从名称中删除{characterListLength, plural, other {字符}} {characterList}。", | |||
| "xpack.remoteClusters.form.errors.illegalSpace": "名称中不允许使用空格。", | |||
| "xpack.remoteClusters.form.errors.nameMissing": "“名称”必填。", | |||
| "xpack.remoteClusters.form.errors.maxValue": "此数字必须等于或小于 {maxValue}。", | |||
There was a problem hiding this comment.
How do we have the translations already?
There was a problem hiding this comment.
i reused the ones from Ingest_pipelines ("xpack.ingestPipelines.pipelineEditor.communityId.seedMaxNumberError"). I forgot to mention it in the description of the PR.
mattkime
reviewed
Oct 20, 2024
| import React from 'react'; | ||
| import { FormattedMessage } from '@kbn/i18n-react'; | ||
|
|
||
| export const MAX_NODE_CONNECTIONS = 2147483647; |
There was a problem hiding this comment.
It would be good to find a central place to keep this so it can also be referenced from tests
There was a problem hiding this comment.
It could also be written (2 ** 31) - 1 instead of the calculated value, up to you.
There was a problem hiding this comment.
Agree about the file to place the constant. I'll find it.
About how to write the value, I decided to write the calculated value because I thought it was a better reference for manual testing, but it can also be specified in a comment.
mattkime
reviewed
Oct 20, 2024
| // Show errors if there is a general form error or local errors. | ||
| const areFormErrorsVisible = Boolean(areErrorsVisible && seedsError); | ||
| const showErrors = areFormErrorsVisible || localSeedErrors.length !== 0; | ||
| const errors = | ||
| const showLocalSheedErrors = areFormErrorsVisible || localSeedErrors.length !== 0; |
There was a problem hiding this comment.
Suggested change
| const showLocalSheedErrors = areFormErrorsVisible || localSeedErrors.length !== 0; | |
| const showLocalSeedErrors = areFormErrorsVisible || localSeedErrors.length !== 0; |
There was a problem hiding this comment.
Right, this typo needs to be corrected.
mattkime
reviewed
Oct 20, 2024
| @@ -107,8 +109,8 @@ export const SniffConnection: FunctionComponent<Props> = ({ | |||
| }} | |||
| /> | |||
| } | |||
| isInvalid={showErrors} | |||
| error={errors} | |||
| isInvalid={showLocalSheedErrors} | |||
There was a problem hiding this comment.
Suggested change
| isInvalid={showLocalSheedErrors} | |
| isInvalid={showLocalSeedErrors} |
mattkime
reviewed
Oct 20, 2024
| @@ -125,7 +127,7 @@ export const SniffConnection: FunctionComponent<Props> = ({ | |||
| onFieldsChange({ seeds: options.map(({ label }) => label) }) | |||
| } | |||
| onSearchChange={onSeedsInputChange} | |||
| isInvalid={showErrors} | |||
| isInvalid={showLocalSheedErrors} | |||
There was a problem hiding this comment.
Suggested change
| isInvalid={showLocalSheedErrors} | |
| isInvalid={showLocalSeedErrors} |
mattkime
approved these changes
Oct 20, 2024
SoniaSanzV
force-pushed
the
remoteClusters/maxSeedValidation_#110155
branch
from
2fcb0c3 to
76e46b7
Compare
SoniaSanzV
force-pushed
the
remoteClusters/maxSeedValidation_#110155
branch
from
76e46b7 to
d101881
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
cc @SoniaSanzV |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11444394688 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 21, 2024
#Closes [elastic#110155](elastic#110155) ## Summary Currently Elastic Search has a limitation of 2^31-1 (2147483647) maximum node connections. This PR adds this hardcoded value and is used to validate that the input does not exceed this value and, therefore, the user does not have to wait for the server to return the error to know that they have entered a number that is too high. ES does not have an API to query the number, that's why it is hardcoded. <img width="1500" alt="Screenshot 2024-10-18 at 17 13 14" src="https://github.com/user-attachments/assets/c18a4756-df76-4e0e-ba31-5118208f686d"> (cherry picked from commit 860e445)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 21, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Validate max number of node connections (#196908)](#196908) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sonia Sanz Vivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-21T16:21:02Z","message":"Validate max number of node connections (#196908)\n\n#Closes [#110155](https://github.com/elastic/kibana/issues/110155)\r\n\r\n## Summary\r\nCurrently Elastic Search has a limitation of 2^31-1 (2147483647) maximum\r\nnode connections. This PR adds this hardcoded value and is used to\r\nvalidate that the input does not exceed this value and, therefore, the\r\nuser does not have to wait for the server to return the error to know\r\nthat they have entered a number that is too high. ES does not have an\r\nAPI to query the number, that's why it is hardcoded.\r\n\r\n<img width=\"1500\" alt=\"Screenshot 2024-10-18 at 17 13 14\"\r\nsrc=\"https://github.com/user-attachments/assets/c18a4756-df76-4e0e-ba31-5118208f686d\">","sha":"860e445c7d6a7d5bb92a638e5ac5cb888f881ffc","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:CCR and Remote Clusters","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"Validate max number of node connections","number":196908,"url":"https://github.com/elastic/kibana/pull/196908","mergeCommit":{"message":"Validate max number of node connections (#196908)\n\n#Closes [#110155](https://github.com/elastic/kibana/issues/110155)\r\n\r\n## Summary\r\nCurrently Elastic Search has a limitation of 2^31-1 (2147483647) maximum\r\nnode connections. This PR adds this hardcoded value and is used to\r\nvalidate that the input does not exceed this value and, therefore, the\r\nuser does not have to wait for the server to return the error to know\r\nthat they have entered a number that is too high. ES does not have an\r\nAPI to query the number, that's why it is hardcoded.\r\n\r\n<img width=\"1500\" alt=\"Screenshot 2024-10-18 at 17 13 14\"\r\nsrc=\"https://github.com/user-attachments/assets/c18a4756-df76-4e0e-ba31-5118208f686d\">","sha":"860e445c7d6a7d5bb92a638e5ac5cb888f881ffc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196908","number":196908,"mergeCommit":{"message":"Validate max number of node connections (#196908)\n\n#Closes [#110155](https://github.com/elastic/kibana/issues/110155)\r\n\r\n## Summary\r\nCurrently Elastic Search has a limitation of 2^31-1 (2147483647) maximum\r\nnode connections. This PR adds this hardcoded value and is used to\r\nvalidate that the input does not exceed this value and, therefore, the\r\nuser does not have to wait for the server to return the error to know\r\nthat they have entered a number that is too high. ES does not have an\r\nAPI to query the number, that's why it is hardcoded.\r\n\r\n<img width=\"1500\" alt=\"Screenshot 2024-10-18 at 17 13 14\"\r\nsrc=\"https://github.com/user-attachments/assets/c18a4756-df76-4e0e-ba31-5118208f686d\">","sha":"860e445c7d6a7d5bb92a638e5ac5cb888f881ffc"}}]}] BACKPORT--> Co-authored-by: Sonia Sanz Vivas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Closes #110155
Summary
Currently Elastic Search has a limitation of 2^31-1 (2147483647) maximum node connections. This PR adds this hardcoded value and is used to validate that the input does not exceed this value and, therefore, the user does not have to wait for the server to return the error to know that they have entered a number that is too high. ES does not have an API to query the number, that's why it is hardcoded.