[Remote Clusters] Error Callout Has Wrong Icon and Color #110155
Assignees
Labels
design
enhancement
New value added to drive a business result
Feature:CCR and Remote Clusters
good first issue
low hanging fruit
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Comments
cuff-links
added
design
Feature:CCR and Remote Clusters
Team:Kibana Management
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
alisonelizabeth
removed
the
Team:Kibana Management
alisonelizabeth
added
good first issue
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
|
This is reported on an older version, so we will need to triage if still valid. In this case, we should be using the |
|
I checked and this still happens. I'll fix it. I'm wondering if we should also add a Max node connections validation when the number is introduced (not sure if we have that info or that complete depends on the backend). Probable will be better to open another issue if we decide to add the validation |
|
@SoniaSanzV I agree that validation should be added as the error message in the screen shot isn't very helpful. |
SoniaSanzV
added a commit
to SoniaSanzV/kibana
that referenced
this issue
Oct 14, 2024
SoniaSanzV
added a commit
that referenced
this issue
Oct 15, 2024
Closes [110155](#110155) ## Summary When the remote cluster creation has an error the banner displayed was a warning instead of an error. ### How to reproduce? 1.) Navigate to Remote Clusters 2.) Create a new Remote Cluster 3.) Add information for a cluster except set the max number of connections to 999999999999999999 4.) Try to save. ### Testing No testing since this doesn't change any functionality. <img width="1243" alt="110155" src="https://github.com/user-attachments/assets/802aa9f3-f70a-44da-a135-8187ada2e78a">
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 15, 2024
Closes [110155](elastic#110155) ## Summary When the remote cluster creation has an error the banner displayed was a warning instead of an error. ### How to reproduce? 1.) Navigate to Remote Clusters 2.) Create a new Remote Cluster 3.) Add information for a cluster except set the max number of connections to 999999999999999999 4.) Try to save. ### Testing No testing since this doesn't change any functionality. <img width="1243" alt="110155" src="https://github.com/user-attachments/assets/802aa9f3-f70a-44da-a135-8187ada2e78a"> (cherry picked from commit ded2740)
SoniaSanzV
added a commit
that referenced
this issue
Oct 21, 2024
#Closes [#110155](#110155) ## Summary Currently Elastic Search has a limitation of 2^31-1 (2147483647) maximum node connections. This PR adds this hardcoded value and is used to validate that the input does not exceed this value and, therefore, the user does not have to wait for the server to return the error to know that they have entered a number that is too high. ES does not have an API to query the number, that's why it is hardcoded. <img width="1500" alt="Screenshot 2024-10-18 at 17 13 14" src="https://github.com/user-attachments/assets/c18a4756-df76-4e0e-ba31-5118208f686d">
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 21, 2024
#Closes [elastic#110155](elastic#110155) ## Summary Currently Elastic Search has a limitation of 2^31-1 (2147483647) maximum node connections. This PR adds this hardcoded value and is used to validate that the input does not exceed this value and, therefore, the user does not have to wait for the server to return the error to know that they have entered a number that is too high. ES does not have an API to query the number, that's why it is hardcoded. <img width="1500" alt="Screenshot 2024-10-18 at 17 13 14" src="https://github.com/user-attachments/assets/c18a4756-df76-4e0e-ba31-5118208f686d"> (cherry picked from commit 860e445)
kibanamachine
added a commit
that referenced
this issue
Oct 21, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Validate max number of node connections (#196908)](#196908) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sonia Sanz Vivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-21T16:21:02Z","message":"Validate max number of node connections (#196908)\n\n#Closes [#110155](https://github.com/elastic/kibana/issues/110155)\r\n\r\n## Summary\r\nCurrently Elastic Search has a limitation of 2^31-1 (2147483647) maximum\r\nnode connections. This PR adds this hardcoded value and is used to\r\nvalidate that the input does not exceed this value and, therefore, the\r\nuser does not have to wait for the server to return the error to know\r\nthat they have entered a number that is too high. ES does not have an\r\nAPI to query the number, that's why it is hardcoded.\r\n\r\n<img width=\"1500\" alt=\"Screenshot 2024-10-18 at 17 13 14\"\r\nsrc=\"https://github.com/user-attachments/assets/c18a4756-df76-4e0e-ba31-5118208f686d\">","sha":"860e445c7d6a7d5bb92a638e5ac5cb888f881ffc","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:CCR and Remote Clusters","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"Validate max number of node connections","number":196908,"url":"https://github.com/elastic/kibana/pull/196908","mergeCommit":{"message":"Validate max number of node connections (#196908)\n\n#Closes [#110155](https://github.com/elastic/kibana/issues/110155)\r\n\r\n## Summary\r\nCurrently Elastic Search has a limitation of 2^31-1 (2147483647) maximum\r\nnode connections. This PR adds this hardcoded value and is used to\r\nvalidate that the input does not exceed this value and, therefore, the\r\nuser does not have to wait for the server to return the error to know\r\nthat they have entered a number that is too high. ES does not have an\r\nAPI to query the number, that's why it is hardcoded.\r\n\r\n<img width=\"1500\" alt=\"Screenshot 2024-10-18 at 17 13 14\"\r\nsrc=\"https://github.com/user-attachments/assets/c18a4756-df76-4e0e-ba31-5118208f686d\">","sha":"860e445c7d6a7d5bb92a638e5ac5cb888f881ffc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196908","number":196908,"mergeCommit":{"message":"Validate max number of node connections (#196908)\n\n#Closes [#110155](https://github.com/elastic/kibana/issues/110155)\r\n\r\n## Summary\r\nCurrently Elastic Search has a limitation of 2^31-1 (2147483647) maximum\r\nnode connections. This PR adds this hardcoded value and is used to\r\nvalidate that the input does not exceed this value and, therefore, the\r\nuser does not have to wait for the server to return the error to know\r\nthat they have entered a number that is too high. ES does not have an\r\nAPI to query the number, that's why it is hardcoded.\r\n\r\n<img width=\"1500\" alt=\"Screenshot 2024-10-18 at 17 13 14\"\r\nsrc=\"https://github.com/user-attachments/assets/c18a4756-df76-4e0e-ba31-5118208f686d\">","sha":"860e445c7d6a7d5bb92a638e5ac5cb888f881ffc"}}]}] BACKPORT--> Co-authored-by: Sonia Sanz Vivas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Environment
Kibana: 7.15.0 BC1
Elasticsearch 7.15.0 BC1
Browsers: All Browsers
Steps to reproduce:
1.) Navigate to Remote Clusters
2.) Create a new Remote Cluster
3.) Add information for a cluster except set the max number of connections to 999999999999999999
4.) Try to save.
Expected Result
The callout that shows the parsing error should be red with an alert icon.
Actual Result
The callout is yellow with an x icon. (See Image)
The text was updated successfully, but these errors were encountered: