[Share] Add loading state to link_content #196809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kowalczyk-krzysztof
added
bug
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Dosant
approved these changes
Oct 18, 2024
| @@ -112,6 +114,7 @@ export const LinkContent = ({ | |||
| copyToClipboard(urlToCopy); | |||
| setUrl(urlToCopy); | |||
| setTextCopied(true); | |||
| setIsLoading(false); | |||
There was a problem hiding this comment.
not for this pr, but looks like this funciton could benefit from error handling logic. wonder what happens if create short url request fails
💚 Build Succeeded
Metrics [docs]Page load bundle
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11401762911 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2024
## Summary This PR adds a loading state to `Copy Link` button in share modal. Fixes: elastic#194641 (cherry picked from commit 32dec20)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 18, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Share] Add loading state to link_content (#196809)](#196809) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Krzysztof Kowalczyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T10:09:54Z","message":"[Share] Add loading state to link_content (#196809)\n\n## Summary\r\n\r\nThis PR adds a loading state to `Copy Link` button in share modal.\r\n\r\nFixes: #194641","sha":"32dec20719f12277234d99953370a4060d4ebaac","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Feature:SharingURLs","release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor"],"title":"[Share] Add loading state to link_content","number":196809,"url":"https://github.com/elastic/kibana/pull/196809","mergeCommit":{"message":"[Share] Add loading state to link_content (#196809)\n\n## Summary\r\n\r\nThis PR adds a loading state to `Copy Link` button in share modal.\r\n\r\nFixes: #194641","sha":"32dec20719f12277234d99953370a4060d4ebaac"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196809","number":196809,"mergeCommit":{"message":"[Share] Add loading state to link_content (#196809)\n\n## Summary\r\n\r\nThis PR adds a loading state to `Copy Link` button in share modal.\r\n\r\nFixes: #194641","sha":"32dec20719f12277234d99953370a4060d4ebaac"}}]}] BACKPORT--> Co-authored-by: Krzysztof Kowalczyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a loading state to
Copy Linkbutton in share modal.Fixes: #194641