Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Share] Make Share this search "Copy Link" Action Visible #194641

Closed
nicpenning opened this issue Oct 1, 2024 · 7 comments · Fixed by #196809
Closed

[Share] Make Share this search "Copy Link" Action Visible #194641

nicpenning opened this issue Oct 1, 2024 · 7 comments · Fixed by #196809
Assignees
@kowalczyk-krzysztof
Labels
Feature:SharingURLs Short URLs and Share URL features good first issue low hanging fruit papercut Small "burr" in the product that we should fix. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@nicpenning
Copy link

Describe the feature:

When using the "Share this search" feature and clicking copy link, it doesn't appear to do anything then the text pops up over Text Copied but it is easy to miss if you are not paying attention and there is no loading bar/animation showing what is happening. Sometimes it takes a few seconds or so before the Text Copied shows up. I even had a user say nothing happens when they click the link.

Image

Describe a specific use case for the feature:
Create an animation to show the user that the link is being created and make it easier to see what the link has been copied. Maybe even show the link to the left of the button when it does populate? Just an idea.
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 1, 2024
@marius-dr marius-dr added Feature:SharingURLs Short URLs and Share URL features Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Oct 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 8, 2024
@petrklapka petrklapka added the good first issue low hanging fruit label Oct 14, 2024
@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Oct 17, 2024
@kowalczyk-krzysztof
Copy link
Member

@ek-so Is there any pattern for this?

@Dosant
Copy link
Contributor

Dosant commented Oct 17, 2024

@ek-so Is there any pattern for this?

I think it is usually loading state on a button https://eui.elastic.co/#/navigation/button#loading-state

@kowalczyk-krzysztof
Copy link
Member

@ek-so Is there any pattern for this?

I think it is usually loading state on a button https://eui.elastic.co/#/navigation/button#loading-state

That makes sense but I've seen a tooltip being used (in fact, it's in the same Share modal):

Image

@Dosant
Copy link
Contributor

Dosant commented Oct 17, 2024

@kowalczyk-krzysztof I think the problem here is that we send a request to genereate a link and then add it to clipboard. it could take a bit of time and there is no feedback while it is loading. If we add loading state to that button and then show the tooltip (I assume we already show it) it should solve the issue

Copied but it is easy to miss if you are not paying attention and there is no loading bar/animation showing what is happening. Sometimes it takes a few seconds or so before the Text Copied shows up. I even had a user say nothing happens when they click the link.

@kowalczyk-krzysztof
Copy link
Member

@Dosant Ah, right. I misunderstood the issue. There is a tooltip already on this button when it finishes but you're right, there's no loading state. So I guess I'll add that.

@petrklapka petrklapka added the papercut Small "burr" in the product that we should fix. label Oct 17, 2024
@ek-so
Copy link
Contributor

ek-so commented Oct 18, 2024

Hey both, thank you! This is indeed a pattern used across kibana now, so I believe we're good to go with it too 🙌 Just to clarify: the button is loading, then only when the link is ready, user sees "copied" hint, right?

@kowalczyk-krzysztof kowalczyk-krzysztof mentioned this issue Oct 18, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 18, 2024
@kowalczyk-krzysztof
[Share] Add loading state to link_content (elastic#196809)
838ff5c 
## Summary

This PR adds a loading state to `Copy Link` button in share modal.

Fixes: elastic#194641
(cherry picked from commit 32dec20)
kibanamachine added a commit that referenced this issue Oct 18, 2024
@kibanamachine @kowalczyk-krzysztof
[8.x] [Share] Add loading state to link_content (#196809) (#196833)
10a9161 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Share] Add loading state to link_content
(#196809)](#196809)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T10:09:54Z","message":"[Share]
Add loading state to link_content (#196809)\n\n## Summary\r\n\r\nThis PR
adds a loading state to `Copy Link` button in share modal.\r\n\r\nFixes:
#194641","sha":"32dec20719f12277234d99953370a4060d4ebaac","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Feature:SharingURLs","release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor"],"title":"[Share]
Add loading state to
link_content","number":196809,"url":"https://github.com/elastic/kibana/pull/196809","mergeCommit":{"message":"[Share]
Add loading state to link_content (#196809)\n\n## Summary\r\n\r\nThis PR
adds a loading state to `Copy Link` button in share modal.\r\n\r\nFixes:
#194641","sha":"32dec20719f12277234d99953370a4060d4ebaac"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196809","number":196809,"mergeCommit":{"message":"[Share]
Add loading state to link_content (#196809)\n\n## Summary\r\n\r\nThis PR
adds a loading state to `Copy Link` button in share modal.\r\n\r\nFixes:
#194641","sha":"32dec20719f12277234d99953370a4060d4ebaac"}}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kowalczyk-krzysztof kowalczyk-krzysztof

Labels
Feature:SharingURLs Short URLs and Share URL features good first issue low hanging fruit papercut Small "burr" in the product that we should fix. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Share] Add loading state to link_content kowalczyk-krzysztof/kibana
7 participants
@marius-dr @nicpenning @Dosant @elasticmachine @ek-so @kowalczyk-krzysztof @petrklapka