Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] fix: updating dashboard - initial save button state is "disabled" (#196137) #196661

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…astic#196137)

## Summary

This PR fixes [[Dashboard] User can click on update dashboard even
without changing
anything](elastic#187800) issue.

## Change

- When the flyout is open, the initial state of the button is
`disabled`.
- When there is a change made, the `disabled` state is removed.

![Screenshot 2024-10-14 at 15 21
28](https://github.com/user-attachments/assets/7f4a6234-959b-4779-bb4b-3f8bc221b3f2)

![Screenshot 2024-10-14 at 15 21
55](https://github.com/user-attachments/assets/24349b06-d6ee-4749-8981-d192eda8fd9d)

(cherry picked from commit 0ead257)
@kibanamachine kibanamachine merged commit bd287d8 into elastic:8.x Oct 17, 2024
25 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 637.4KB 637.6KB +213.0B
eventAnnotationListing 226.7KB 226.9KB +213.0B
filesManagement 120.4KB 120.6KB +213.0B
graph 413.0KB 413.2KB +213.0B
maps 3.0MB 3.0MB +213.0B
visualizations 316.6KB 316.8KB +213.0B
total +1.2KB

cc @paulinashakirova

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants