[Dashboard] User can click on update dashboard even without changing anything #187800
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Dashboard
Dashboard related features
good first issue
low hanging fruit
impact:needs-assessment
Product and/or Engineering needs to evaluate the impact of the change.
loe:needs-research
This issue requires some research before it can be worked on or estimated
SharedUX/fix-it-week
Bugs that have been groomed and queued up for the team's next fix it week
Team:SharedUX
Team label for AppEx-SharedUX (formerly Global Experience)
Comments
bhavyarm
added
bug
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
kibanamachine
added
loe:needs-research
|
cc @Dosant |
Dosant
added
the
SharedUX/fix-it-week
paulinashakirova
added a commit
that referenced
this issue
Oct 17, 2024
…96137) ## Summary This PR fixes [[Dashboard] User can click on update dashboard even without changing anything](#187800) issue. ## Change - When the flyout is open, the initial state of the button is `disabled`. - When there is a change made, the `disabled` state is removed.  
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 17, 2024
…astic#196137) ## Summary This PR fixes [[Dashboard] User can click on update dashboard even without changing anything](elastic#187800) issue. ## Change - When the flyout is open, the initial state of the button is `disabled`. - When there is a change made, the `disabled` state is removed.   (cherry picked from commit 0ead257)
kibanamachine
added a commit
that referenced
this issue
Oct 17, 2024
…sabled" (#196137) (#196661) # Backport This will backport the following commits from `main` to `8.x`: - [fix: updating dashboard - initial save button state is "disabled" (#196137)](#196137) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paulina Shakirova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T10:39:42Z","message":"fix: updating dashboard - initial save button state is \"disabled\" (#196137)\n\n## Summary\r\n\r\nThis PR fixes [[Dashboard] User can click on update dashboard even\r\nwithout changing\r\nanything](#187800) issue.\r\n\r\n## Change\r\n\r\n- When the flyout is open, the initial state of the button is\r\n`disabled`.\r\n- When there is a change made, the `disabled` state is removed.\r\n\r\n\r\n\r\n","sha":"0ead257ff4912218775a70484ac5754b4b3baa31","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:SharedUX","backport:prev-minor"],"title":"fix: updating dashboard - initial save button state is \"disabled\"","number":196137,"url":"https://github.com/elastic/kibana/pull/196137","mergeCommit":{"message":"fix: updating dashboard - initial save button state is \"disabled\" (#196137)\n\n## Summary\r\n\r\nThis PR fixes [[Dashboard] User can click on update dashboard even\r\nwithout changing\r\nanything](#187800) issue.\r\n\r\n## Change\r\n\r\n- When the flyout is open, the initial state of the button is\r\n`disabled`.\r\n- When there is a change made, the `disabled` state is removed.\r\n\r\n\r\n\r\n","sha":"0ead257ff4912218775a70484ac5754b4b3baa31"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196137","number":196137,"mergeCommit":{"message":"fix: updating dashboard - initial save button state is \"disabled\" (#196137)\n\n## Summary\r\n\r\nThis PR fixes [[Dashboard] User can click on update dashboard even\r\nwithout changing\r\nanything](#187800) issue.\r\n\r\n## Change\r\n\r\n- When the flyout is open, the initial state of the button is\r\n`disabled`.\r\n- When there is a change made, the `disabled` state is removed.\r\n\r\n\r\n\r\n","sha":"0ead257ff4912218775a70484ac5754b4b3baa31"}}]}] BACKPORT--> Co-authored-by: Paulina Shakirova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kibana version: 8.15.0 BC1
Browser version: chrome latest
Browser OS version: OS X
Original install method (e.g. download page, yum, from source, etc.): from staging
Describe the bug: User can click on "Update dashboard" button even without making any changes and this one puts that user as having updated the dashboard.
update_dashboard.mp4
The text was updated successfully, but these errors were encountered: