[deploy-fix@1728886420] [Onboarding] only update the index details page when plugin is enabled (#196077) #196136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elastic#196077) ## Summary The index details page is always updated even when the plugin is disabled. Using the pluginEnabled conditional to only update when enabled. ### How to replicate 1. disable uisetting for search indices plugin 2. go to index management and click on a index detail Expected: see the old index detail page actual: goes to the new index detail url but does not render the search detail page (as plugin disabled) ### Checklist Delete any items that are not applicable to this PR. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed (cherry picked from commit efab00b)
2 tasks
sphilipse
approved these changes
Oct 14, 2024
💚 Build Succeeded
Metrics [docs]Page load bundle
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintodeploy-fix@1728886420:Questions ?
Please refer to the Backport tool documentation