[Onboarding] only update the index details page when plugin is enabled #196077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemcelroy
added
backport:prev-minor
TattdCodeMonkey
approved these changes
Oct 14, 2024
sphilipse
approved these changes
Oct 14, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11326979817 |
💚 Build Succeeded
Metrics [docs]Page load bundle
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2024
elastic#196077) ## Summary The index details page is always updated even when the plugin is disabled. Using the pluginEnabled conditional to only update when enabled. ### How to replicate 1. disable uisetting for search indices plugin 2. go to index management and click on a index detail Expected: see the old index detail page actual: goes to the new index detail url but does not render the search detail page (as plugin disabled) ### Checklist Delete any items that are not applicable to this PR. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed (cherry picked from commit efab00b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
joemcelroy
added a commit
to joemcelroy/kibana
that referenced
this pull request
Oct 14, 2024
elastic#196077) ## Summary The index details page is always updated even when the plugin is disabled. Using the pluginEnabled conditional to only update when enabled. ### How to replicate 1. disable uisetting for search indices plugin 2. go to index management and click on a index detail Expected: see the old index detail page actual: goes to the new index detail url but does not render the search detail page (as plugin disabled) ### Checklist Delete any items that are not applicable to this PR. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed (cherry picked from commit efab00b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2024
…enabled (#196077) (#196121) # Backport This will backport the following commits from `main` to `8.x`: - [[Onboarding] only update the index details page when plugin is enabled (#196077)](#196077) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Joe McElroy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T11:53:25Z","message":"[Onboarding] only update the index details page when plugin is enabled (#196077)\n\n## Summary\r\n\r\nThe index details page is always updated even when the plugin is\r\ndisabled. Using the pluginEnabled conditional to only update when\r\nenabled.\r\n\r\n### How to replicate\r\n1. disable uisetting for search indices plugin\r\n2. go to index management and click on a index detail\r\n\r\nExpected: see the old index detail page\r\nactual: goes to the new index detail url but does not render the search\r\ndetail page (as plugin disabled)\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"efab00b36ede744916f924c6a7965dd93624493b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Onboarding] only update the index details page when plugin is enabled","number":196077,"url":"https://github.com/elastic/kibana/pull/196077","mergeCommit":{"message":"[Onboarding] only update the index details page when plugin is enabled (#196077)\n\n## Summary\r\n\r\nThe index details page is always updated even when the plugin is\r\ndisabled. Using the pluginEnabled conditional to only update when\r\nenabled.\r\n\r\n### How to replicate\r\n1. disable uisetting for search indices plugin\r\n2. go to index management and click on a index detail\r\n\r\nExpected: see the old index detail page\r\nactual: goes to the new index detail url but does not render the search\r\ndetail page (as plugin disabled)\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"efab00b36ede744916f924c6a7965dd93624493b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196077","number":196077,"mergeCommit":{"message":"[Onboarding] only update the index details page when plugin is enabled (#196077)\n\n## Summary\r\n\r\nThe index details page is always updated even when the plugin is\r\ndisabled. Using the pluginEnabled conditional to only update when\r\nenabled.\r\n\r\n### How to replicate\r\n1. disable uisetting for search indices plugin\r\n2. go to index management and click on a index detail\r\n\r\nExpected: see the old index detail page\r\nactual: goes to the new index detail url but does not render the search\r\ndetail page (as plugin disabled)\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"efab00b36ede744916f924c6a7965dd93624493b"}}]}] BACKPORT--> Co-authored-by: Joe McElroy <[email protected]>
pheyos
pushed a commit
that referenced
this pull request
Oct 14, 2024
…ge when plugin is enabled (#196077) (#196136) # Backport This will backport the following commits from `main` to `deploy-fix@1728886420`: - [[Onboarding] only update the index details page when plugin is enabled (#196077)](#196077) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Joe McElroy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T11:53:25Z","message":"[Onboarding] only update the index details page when plugin is enabled (#196077)\n\n## Summary\r\n\r\nThe index details page is always updated even when the plugin is\r\ndisabled. Using the pluginEnabled conditional to only update when\r\nenabled.\r\n\r\n### How to replicate\r\n1. disable uisetting for search indices plugin\r\n2. go to index management and click on a index detail\r\n\r\nExpected: see the old index detail page\r\nactual: goes to the new index detail url but does not render the search\r\ndetail page (as plugin disabled)\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"efab00b36ede744916f924c6a7965dd93624493b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"number":196077,"url":"https://github.com/elastic/kibana/pull/196077","mergeCommit":{"message":"[Onboarding] only update the index details page when plugin is enabled (#196077)\n\n## Summary\r\n\r\nThe index details page is always updated even when the plugin is\r\ndisabled. Using the pluginEnabled conditional to only update when\r\nenabled.\r\n\r\n### How to replicate\r\n1. disable uisetting for search indices plugin\r\n2. go to index management and click on a index detail\r\n\r\nExpected: see the old index detail page\r\nactual: goes to the new index detail url but does not render the search\r\ndetail page (as plugin disabled)\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"efab00b36ede744916f924c6a7965dd93624493b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196077","number":196077,"mergeCommit":{"message":"[Onboarding] only update the index details page when plugin is enabled (#196077)\n\n## Summary\r\n\r\nThe index details page is always updated even when the plugin is\r\ndisabled. Using the pluginEnabled conditional to only update when\r\nenabled.\r\n\r\n### How to replicate\r\n1. disable uisetting for search indices plugin\r\n2. go to index management and click on a index detail\r\n\r\nExpected: see the old index detail page\r\nactual: goes to the new index detail url but does not render the search\r\ndetail page (as plugin disabled)\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"efab00b36ede744916f924c6a7965dd93624493b"}},{"url":"https://github.com/elastic/kibana/pull/196121","number":196121,"branch":"8.x","state":"OPEN"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The index details page is always updated even when the plugin is disabled. Using the pluginEnabled conditional to only update when enabled.
How to replicate
Expected: see the old index detail page
actual: goes to the new index detail url but does not render the search detail page (as plugin disabled)
Checklist
Delete any items that are not applicable to this PR.