fix: [Stateful: Home page] Most Ingest your content section buttons have duplicated actions on them #196079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave duplicated actions on them Closes: elastic#194932
alexwizp
added
v9.0.0
backport:prev-minor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
efegurkan
approved these changes
Oct 15, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11346228794 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 15, 2024
…ave duplicated actions on them (elastic#196079) Closes: elastic#194932 ## Summary User reaches the same button two times when navigating using only keyboard and it can get confusing. Also for the user using screen reader it is also confusing if reached element is button or link. Better for element to get focus only one time when navigating in sequence from one element to another and for the user only to hear one announcement of the element, button or link (but not button link). ## What was changed?: 1. Removed extra `EuiLinkTo` wrapper 2. `EuiButton` was replaced to `EuiButtonTo` ## Screen <img width="1792" alt="image" src="https://github.com/user-attachments/assets/597eb7f0-dd7b-4c14-bccd-d91dc3bdcbcf"> (cherry picked from commit 5ed6981)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 15, 2024
…tons have duplicated actions on them (#196079) (#196301) # Backport This will backport the following commits from `main` to `8.x`: - [fix: [Stateful: Home page] Most Ingest your content section buttons have duplicated actions on them (#196079)](#196079) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-15T12:39:10Z","message":"fix: [Stateful: Home page] Most Ingest your content section buttons have duplicated actions on them (#196079)\n\nCloses: #194932\r\n\r\n## Summary\r\n\r\nUser reaches the same button two times when navigating using only\r\nkeyboard and it can get confusing. Also for the user using screen reader\r\nit is also confusing if reached element is button or link. Better for\r\nelement to get focus only one time when navigating in sequence from one\r\nelement to another and for the user only to hear one announcement of the\r\nelement, button or link (but not button link).\r\n\r\n## What was changed?:\r\n\r\n1. Removed extra `EuiLinkTo` wrapper \r\n2. `EuiButton` was replaced to `EuiButtonTo`\r\n\r\n## Screen \r\n\r\n<img width=\"1792\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/597eb7f0-dd7b-4c14-bccd-d91dc3bdcbcf\">","sha":"5ed698182887e18d2aa6c4b6782cc636a45a1472","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"fix: [Stateful: Home page] Most Ingest your content section buttons have duplicated actions on them","number":196079,"url":"https://github.com/elastic/kibana/pull/196079","mergeCommit":{"message":"fix: [Stateful: Home page] Most Ingest your content section buttons have duplicated actions on them (#196079)\n\nCloses: #194932\r\n\r\n## Summary\r\n\r\nUser reaches the same button two times when navigating using only\r\nkeyboard and it can get confusing. Also for the user using screen reader\r\nit is also confusing if reached element is button or link. Better for\r\nelement to get focus only one time when navigating in sequence from one\r\nelement to another and for the user only to hear one announcement of the\r\nelement, button or link (but not button link).\r\n\r\n## What was changed?:\r\n\r\n1. Removed extra `EuiLinkTo` wrapper \r\n2. `EuiButton` was replaced to `EuiButtonTo`\r\n\r\n## Screen \r\n\r\n<img width=\"1792\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/597eb7f0-dd7b-4c14-bccd-d91dc3bdcbcf\">","sha":"5ed698182887e18d2aa6c4b6782cc636a45a1472"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196079","number":196079,"mergeCommit":{"message":"fix: [Stateful: Home page] Most Ingest your content section buttons have duplicated actions on them (#196079)\n\nCloses: #194932\r\n\r\n## Summary\r\n\r\nUser reaches the same button two times when navigating using only\r\nkeyboard and it can get confusing. Also for the user using screen reader\r\nit is also confusing if reached element is button or link. Better for\r\nelement to get focus only one time when navigating in sequence from one\r\nelement to another and for the user only to hear one announcement of the\r\nelement, button or link (but not button link).\r\n\r\n## What was changed?:\r\n\r\n1. Removed extra `EuiLinkTo` wrapper \r\n2. `EuiButton` was replaced to `EuiButtonTo`\r\n\r\n## Screen \r\n\r\n<img width=\"1792\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/597eb7f0-dd7b-4c14-bccd-d91dc3bdcbcf\">","sha":"5ed698182887e18d2aa6c4b6782cc636a45a1472"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #194932
Summary
User reaches the same button two times when navigating using only keyboard and it can get confusing. Also for the user using screen reader it is also confusing if reached element is button or link. Better for element to get focus only one time when navigating in sequence from one element to another and for the user only to hear one announcement of the element, button or link (but not button link).
What was changed?:
EuiLinkTowrapperEuiButtonwas replaced toEuiButtonToScreen