Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stateful: Home page] Most Ingest your content section buttons have duplicated actions on them #194932

Closed
L1nBra opened this issue Oct 4, 2024 · 2 comments · Fixed by #196079
Closed

[Stateful: Home page] Most Ingest your content section buttons have duplicated actions on them #194932

L1nBra opened this issue Oct 4, 2024 · 2 comments · Fixed by #196079
Assignees
@alexwizp
Labels
defect-level-3 Moderate UX disruption or potentially confusing Project:Accessibility Team:Search WCAG A

Comments

@L1nBra
Copy link

L1nBra commented Oct 4, 2024 •
edited
Loading

Description
User reaches the same button two times when navigating using only keyboard and it can get confusing. Also for the user using screen reader it is also confusing if reached element is button or link. Better for element to get focus only one time when navigating in sequence from one element to another and for the user only to hear one announcement of the element, button or link (but not button link).

Preconditions
Stateful Home page (Overview) is opened.

Steps to reproduce

1.Using only keyboard Navigate to Manage button (by pressing Tab key).
2.Press Tab key.
3.Press Tab key.

NVDA screenshot
Image
Screenshot of elements with the same issue
Image

Actual Result

  • At first focus is on the button and text Create API index is underlined in bold. After pressing Tab one more time focus is on the same button, text in the button is underlined but not in bold anymore.

Expected Result

  • After Manage button the next element which gets active is Create Api index. Then Crawl Url.

Notes
Same behavior with elements:

  • Crawl URL
  • Create a connector
  • Browse clients

These elements are also pronounced as button link and two times identically when user uses Tab key while navigating through them. It should be either button or link, but not both.

Meta Issue

Kibana Version: 8.16.0-SNAPSHOT

OS: Windows 11 Pro

Browser: Chrome Version 129.0.6668.70 (Official Build) (64-bit)

Screen reader: NVDA

WCAG or Vendor Guidance (optional)

Related to: https://github.com/elastic/search-team/issues/8256
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 4, 2024
@L1nBra L1nBra added the defect-level-3 Moderate UX disruption or potentially confusing label Oct 4, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 10, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 10, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 10, 2024
@L1nBra
Copy link
Author

L1nBra commented Oct 11, 2024

Same behavior observed on

  • Indices page for New index (when there are no indices), Create a new index (when there are already created indices)buttons
    UI elements
    Image
    Image
    NVDA Speech viewer
    Image

@alexwizp alexwizp self-assigned this Oct 14, 2024
alexwizp added a commit to alexwizp/kibana that referenced this issue Oct 14, 2024
@alexwizp
fix: [Stateful: Home page] Most Ingest your content section buttons h…
1577942 
…ave duplicated actions on them

Closes: elastic#194932
@alexwizp alexwizp mentioned this issue Oct 14, 2024
Merged
alexwizp added a commit to alexwizp/kibana that referenced this issue Oct 14, 2024
@alexwizp
Merge branch 'main' into elastic#194932
b49702c
alexwizp added a commit to alexwizp/kibana that referenced this issue Oct 15, 2024
@alexwizp
Merge branch 'main' into elastic#194932
ecd77c5
alexwizp added a commit that referenced this issue Oct 15, 2024
@alexwizp
fix: [Stateful: Home page] Most Ingest your content section buttons h…
5ed6981 
…ave duplicated actions on them (#196079)

Closes: #194932

## Summary

User reaches the same button two times when navigating using only
keyboard and it can get confusing. Also for the user using screen reader
it is also confusing if reached element is button or link. Better for
element to get focus only one time when navigating in sequence from one
element to another and for the user only to hear one announcement of the
element, button or link (but not button link).

## What was changed?:

1. Removed extra `EuiLinkTo` wrapper 
2. `EuiButton` was replaced to `EuiButtonTo`

## Screen 

<img width="1792" alt="image"
src="https://github.com/user-attachments/assets/597eb7f0-dd7b-4c14-bccd-d91dc3bdcbcf">
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 15, 2024
@alexwizp
fix: [Stateful: Home page] Most Ingest your content section buttons h…
83c0e14 
…ave duplicated actions on them (elastic#196079)

Closes: elastic#194932

## Summary

User reaches the same button two times when navigating using only
keyboard and it can get confusing. Also for the user using screen reader
it is also confusing if reached element is button or link. Better for
element to get focus only one time when navigating in sequence from one
element to another and for the user only to hear one announcement of the
element, button or link (but not button link).

## What was changed?:

1. Removed extra `EuiLinkTo` wrapper
2. `EuiButton` was replaced to `EuiButtonTo`

## Screen

<img width="1792" alt="image"
src="https://github.com/user-attachments/assets/597eb7f0-dd7b-4c14-bccd-d91dc3bdcbcf">

(cherry picked from commit 5ed6981)
kibanamachine added a commit that referenced this issue Oct 15, 2024
@kibanamachine @alexwizp
[8.x] fix: [Stateful: Home page] Most Ingest your content section but…
ebfc4d9 
…tons have duplicated actions on them (#196079) (#196301)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Stateful: Home page] Most Ingest your content section buttons
have duplicated actions on them
(#196079)](#196079)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-15T12:39:10Z","message":"fix:
[Stateful: Home page] Most Ingest your content section buttons have
duplicated actions on them (#196079)\n\nCloses: #194932\r\n\r\n##
Summary\r\n\r\nUser reaches the same button two times when navigating
using only\r\nkeyboard and it can get confusing. Also for the user using
screen reader\r\nit is also confusing if reached element is button or
link. Better for\r\nelement to get focus only one time when navigating
in sequence from one\r\nelement to another and for the user only to hear
one announcement of the\r\nelement, button or link (but not button
link).\r\n\r\n## What was changed?:\r\n\r\n1. Removed extra `EuiLinkTo`
wrapper \r\n2. `EuiButton` was replaced to `EuiButtonTo`\r\n\r\n##
Screen \r\n\r\n<img width=\"1792\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/597eb7f0-dd7b-4c14-bccd-d91dc3bdcbcf\">","sha":"5ed698182887e18d2aa6c4b6782cc636a45a1472","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"fix:
[Stateful: Home page] Most Ingest your content section buttons have
duplicated actions on
them","number":196079,"url":"https://github.com/elastic/kibana/pull/196079","mergeCommit":{"message":"fix:
[Stateful: Home page] Most Ingest your content section buttons have
duplicated actions on them (#196079)\n\nCloses: #194932\r\n\r\n##
Summary\r\n\r\nUser reaches the same button two times when navigating
using only\r\nkeyboard and it can get confusing. Also for the user using
screen reader\r\nit is also confusing if reached element is button or
link. Better for\r\nelement to get focus only one time when navigating
in sequence from one\r\nelement to another and for the user only to hear
one announcement of the\r\nelement, button or link (but not button
link).\r\n\r\n## What was changed?:\r\n\r\n1. Removed extra `EuiLinkTo`
wrapper \r\n2. `EuiButton` was replaced to `EuiButtonTo`\r\n\r\n##
Screen \r\n\r\n<img width=\"1792\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/597eb7f0-dd7b-4c14-bccd-d91dc3bdcbcf\">","sha":"5ed698182887e18d2aa6c4b6782cc636a45a1472"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196079","number":196079,"mergeCommit":{"message":"fix:
[Stateful: Home page] Most Ingest your content section buttons have
duplicated actions on them (#196079)\n\nCloses: #194932\r\n\r\n##
Summary\r\n\r\nUser reaches the same button two times when navigating
using only\r\nkeyboard and it can get confusing. Also for the user using
screen reader\r\nit is also confusing if reached element is button or
link. Better for\r\nelement to get focus only one time when navigating
in sequence from one\r\nelement to another and for the user only to hear
one announcement of the\r\nelement, button or link (but not button
link).\r\n\r\n## What was changed?:\r\n\r\n1. Removed extra `EuiLinkTo`
wrapper \r\n2. `EuiButton` was replaced to `EuiButtonTo`\r\n\r\n##
Screen \r\n\r\n<img width=\"1792\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/597eb7f0-dd7b-4c14-bccd-d91dc3bdcbcf\">","sha":"5ed698182887e18d2aa6c4b6782cc636a45a1472"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
@L1nBra L1nBra mentioned this issue Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
defect-level-3 Moderate UX disruption or potentially confusing Project:Accessibility Team:Search WCAG A
Projects
None yet
Milestone
No milestone
3 participants
@elasticmachine @alexwizp @L1nBra