Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Data visualizer: Add icons for semantic text, sparse vector and dense vector #196069

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

rbrtj
Copy link
Contributor

@rbrtj rbrtj commented Oct 14, 2024

Summary

Added support for semantic_text, sparse_vector and dense_vector in the Data visualizer and Field Statistics.
For #192161

Before After
image image
image image

@rbrtj rbrtj added release_note:enhancement :ml Feature:File and Index Data Viz ML file and index data visualizer v9.0.0 Team:ML Team label for ML (also use :ml) v8.16.0 backport:version Backport to applied version labels labels Oct 14, 2024
@rbrtj rbrtj requested review from peteharverson and qn895 October 14, 2024 09:31
@rbrtj rbrtj self-assigned this Oct 14, 2024
@rbrtj rbrtj requested a review from a team as a code owner October 14, 2024 09:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@@ -47,6 +47,9 @@ export const SUPPORTED_FIELD_TYPES = {
NESTED: 'nested',
STRING: 'string',
TEXT: 'text',
SEMANTIC_TEXT: 'semantic_text',
DENSE_VECTOR: 'dense_vector',
SPARSE_VECTOR: 'sparse_vector',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qn895 @rbrtj do you know if we should make the messaging consistent in Field Statistics with the message in the sidebar field list?

Screenshot 2024-10-14 at 12 10 21

Sidebar:
Screenshot 2024-10-14 at 12 12 34

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created separate issue to enhance the information displayed in the expanded row: #196177

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #15 / threatMatchRowRenderer #renderRow rendered when indicator matches are more than MAX rendered

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 613.8KB 614.0KB +139.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataVisualizer 24.4KB 24.5KB +141.0B

cc @rbrtj

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qn895
Copy link
Member

qn895 commented Oct 15, 2024

LGTM 🎉

@rbrtj rbrtj merged commit ac5b14b into elastic:main Oct 15, 2024
21 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11341649705

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 15, 2024
…r and dense vector (#196069) (#196238)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Data visualizer: Add icons for semantic text, sparse vector and
dense vector (#196069)](#196069)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-15T07:52:06Z","message":"[ML]
Data visualizer: Add icons for semantic text, sparse vector and dense
vector (#196069)\n\n## Summary\r\n\r\nAdded support for `semantic_text`,
`sparse_vector` and `dense_vector` in\r\nthe Data visualizer and Field
Statistics.\r\nFor
[#192161](https://github.com/elastic/kibana/issues/192161)\r\n\r\n\r\n|
Before | After |\r\n| ------------- | -------------
|\r\n|\r\n![image](https://github.com/user-attachments/assets/d87de954-bae0-46d3-9934-e6e6a6424ee0)\r\n|\r\n![image](https://github.com/user-attachments/assets/a6fced39-e227-43ea-9062-9add27aad8fd)\r\n|\r\n|\r\n![image](https://github.com/user-attachments/assets/4c8005e3-439f-4dfc-898b-8158835d803f)\r\n|\r\n![image](https://github.com/user-attachments/assets/a9d501cc-84f9-4394-9ffb-a6fa62269cde)\r\n|","sha":"ac5b14b1254219f79dddd5da0ab9c1ff8d1ea0c1","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Feature:File
and Index Data
Viz","v9.0.0","Team:ML","v8.16.0","backport:version"],"title":"[ML] Data
visualizer: Add icons for semantic text, sparse vector and dense
vector","number":196069,"url":"https://github.com/elastic/kibana/pull/196069","mergeCommit":{"message":"[ML]
Data visualizer: Add icons for semantic text, sparse vector and dense
vector (#196069)\n\n## Summary\r\n\r\nAdded support for `semantic_text`,
`sparse_vector` and `dense_vector` in\r\nthe Data visualizer and Field
Statistics.\r\nFor
[#192161](https://github.com/elastic/kibana/issues/192161)\r\n\r\n\r\n|
Before | After |\r\n| ------------- | -------------
|\r\n|\r\n![image](https://github.com/user-attachments/assets/d87de954-bae0-46d3-9934-e6e6a6424ee0)\r\n|\r\n![image](https://github.com/user-attachments/assets/a6fced39-e227-43ea-9062-9add27aad8fd)\r\n|\r\n|\r\n![image](https://github.com/user-attachments/assets/4c8005e3-439f-4dfc-898b-8158835d803f)\r\n|\r\n![image](https://github.com/user-attachments/assets/a9d501cc-84f9-4394-9ffb-a6fa62269cde)\r\n|","sha":"ac5b14b1254219f79dddd5da0ab9c1ff8d1ea0c1"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196069","number":196069,"mergeCommit":{"message":"[ML]
Data visualizer: Add icons for semantic text, sparse vector and dense
vector (#196069)\n\n## Summary\r\n\r\nAdded support for `semantic_text`,
`sparse_vector` and `dense_vector` in\r\nthe Data visualizer and Field
Statistics.\r\nFor
[#192161](https://github.com/elastic/kibana/issues/192161)\r\n\r\n\r\n|
Before | After |\r\n| ------------- | -------------
|\r\n|\r\n![image](https://github.com/user-attachments/assets/d87de954-bae0-46d3-9934-e6e6a6424ee0)\r\n|\r\n![image](https://github.com/user-attachments/assets/a6fced39-e227-43ea-9062-9add27aad8fd)\r\n|\r\n|\r\n![image](https://github.com/user-attachments/assets/4c8005e3-439f-4dfc-898b-8158835d803f)\r\n|\r\n![image](https://github.com/user-attachments/assets/a9d501cc-84f9-4394-9ffb-a6fa62269cde)\r\n|","sha":"ac5b14b1254219f79dddd5da0ab9c1ff8d1ea0c1"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:File and Index Data Viz ML file and index data visualizer :ml release_note:enhancement Team:ML Team label for ML (also use :ml) v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants