[APM][Otel] Use fields instead of _source on APM queries
#195242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
crespocarlos
added
apm
apm:opentelemetry
crespocarlos
requested review from
jennypavlova,
AlexanderWert,
felixbarny,
rmyz,
MiriamAparicio,
miloszmarcinkowski and
dgieselaar
x-pack/plugins/observability_solution/apm_data_access/server/utils/unflatten_known_fields.ts
Show resolved
Hide resolved
rmyz
reviewed
Oct 7, 2024
...bility_solution/apm/server/routes/errors/get_error_groups/get_error_group_main_statistics.ts
Show resolved
Hide resolved
...bility_solution/apm/server/routes/errors/get_error_groups/get_error_group_main_statistics.ts
Show resolved
Hide resolved
...servability_solution/apm/server/routes/errors/get_error_groups/get_error_group_sample_ids.ts
Show resolved
Hide resolved
x-pack/plugins/observability_solution/apm/server/routes/services/get_service_metadata_icons.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/apm/server/routes/traces/get_trace_items.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/apm_data_access/server/utils/unflatten_known_fields.ts
Show resolved
Hide resolved
rmyz
reviewed
Oct 7, 2024
|
/ci |
This was referenced Oct 7, 2024
💔 Build FailedFailed CI StepsHistory
To update your PR or re-run it, just comment with: |
dgieselaar
reviewed
Oct 7, 2024
dgieselaar
reviewed
Oct 7, 2024
x-pack/packages/observability/observability_utils/object/unflatten_object.ts
Show resolved
Hide resolved
dgieselaar
reviewed
Oct 7, 2024
x-pack/plugins/observability_solution/apm_data_access/server/utils/unflatten_known_fields.ts
Show resolved
Hide resolved
miloszmarcinkowski
approved these changes
Oct 7, 2024
dgieselaar
reviewed
Oct 7, 2024
...k/plugins/observability_solution/apm_data_access/server/utils/unflatten_known_fields.test.ts
Outdated
Show resolved
Hide resolved
dgieselaar
reviewed
Oct 7, 2024
...k/plugins/observability_solution/apm_data_access/server/utils/unflatten_known_fields.test.ts
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
[APM][Otel] Errors: Add fallback to span id if the parent id is undefined
|
@elasticmachine merge upstream |
…an-error-type-result-in-error-details-page-crashing [APM][Otel] Errors without an error type result in error details page crashing
…ith-mobile-services [APM][Otel] Fix an error with mobile services
This reverts commit 4134daa.
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
|
crespocarlos
changed the title
fields instead of _source on APM queriesfields instead of _source on APM queries
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11343408262 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 15, 2024
…#195242) closes elastic#192606 ## Summary v2 based on the work done in this PR elastic#192608 and the suggestion from Dario elastic#194424 This PR replaces the _source usage in APM queries with fields to support Otel data. The idea is to get rid of existing UI errors we have and make sure that otel data is shown correctly in the UI. One way to check it is using the [e2e PoC](https://github.com/elastic/otel-apm-e2e-poc/blob/main/README.md). --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Jenny <[email protected]> (cherry picked from commit 7235ed0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 15, 2024
…0; on APM queries (#195242) (#196265) # Backport This will backport the following commits from `main` to `8.x`: - [[APM][Otel] Use `fields` instead of `_source` on APM queries (#195242)](#195242) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-15T09:38:44Z","message":"[APM][Otel] Use `fields` instead of `_source` on APM queries (#195242)\n\ncloses https://github.com/elastic/kibana/issues/192606\r\n\r\n## Summary\r\n\r\nv2 based on the work done in this PR\r\nhttps://github.com//pull/192608 and the suggestion from\r\nDario https://github.com/elastic/kibana/pull/194424\r\n\r\nThis PR replaces the _source usage in APM queries with fields to support\r\nOtel data. The idea is to get rid of existing UI errors we have and make\r\nsure that otel data is shown correctly in the UI.\r\n\r\nOne way to check it is using the [e2e\r\nPoC](https://github.com/elastic/otel-apm-e2e-poc/blob/main/README.md).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Jenny <[email protected]>","sha":"7235ed0425100bbf04ff157d0af7980875473c99","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","apm","apm:opentelemetry","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[APM][Otel] Use `fields` instead of `_source` on APM queries","number":195242,"url":"https://github.com/elastic/kibana/pull/195242","mergeCommit":{"message":"[APM][Otel] Use `fields` instead of `_source` on APM queries (#195242)\n\ncloses https://github.com/elastic/kibana/issues/192606\r\n\r\n## Summary\r\n\r\nv2 based on the work done in this PR\r\nhttps://github.com//pull/192608 and the suggestion from\r\nDario https://github.com/elastic/kibana/pull/194424\r\n\r\nThis PR replaces the _source usage in APM queries with fields to support\r\nOtel data. The idea is to get rid of existing UI errors we have and make\r\nsure that otel data is shown correctly in the UI.\r\n\r\nOne way to check it is using the [e2e\r\nPoC](https://github.com/elastic/otel-apm-e2e-poc/blob/main/README.md).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Jenny <[email protected]>","sha":"7235ed0425100bbf04ff157d0af7980875473c99"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195242","number":195242,"mergeCommit":{"message":"[APM][Otel] Use `fields` instead of `_source` on APM queries (#195242)\n\ncloses https://github.com/elastic/kibana/issues/192606\r\n\r\n## Summary\r\n\r\nv2 based on the work done in this PR\r\nhttps://github.com//pull/192608 and the suggestion from\r\nDario https://github.com/elastic/kibana/pull/194424\r\n\r\nThis PR replaces the _source usage in APM queries with fields to support\r\nOtel data. The idea is to get rid of existing UI errors we have and make\r\nsure that otel data is shown correctly in the UI.\r\n\r\nOne way to check it is using the [e2e\r\nPoC](https://github.com/elastic/otel-apm-e2e-poc/blob/main/README.md).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Jenny <[email protected]>","sha":"7235ed0425100bbf04ff157d0af7980875473c99"}}]}] BACKPORT--> Co-authored-by: Carlos Crespo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #192606
Summary
v2 based on the work done in this PR #192608 and the suggestion from Dario #194424
This PR replaces the _source usage in APM queries with fields to support Otel data. The idea is to get rid of existing UI errors we have and make sure that otel data is shown correctly in the UI.
One way to check it is using the e2e PoC.