[APM][Otel] Errors: Add fallback to span id if the parent id is undefined #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennypavlova
commented
Oct 11, 2024
| @@ -129,7 +131,7 @@ export async function getErrorSampleDetails({ | |||
|
|
|||
| const errorFromFields = unflattenKnownApmEventFields(hit.fields, requiredFields); | |||
|
|
|||
| const transactionId = errorFromFields.transaction?.id; | |||
| const transactionId = errorFromFields.transaction?.id ?? errorFromFields.span?.id; | |||
There was a problem hiding this comment.
This is needed because the otel errors don't have transaction.id but they have span.id (for APM those 2 are the same based on my testing with the PoC data/otel demo)
|
Thanks! |
crespocarlos
merged commit 7def09a
into
crespocarlos:192606-move-source-to-fields
1 check passed
This was referenced Oct 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes elastic#195731
follows elastic#195796
Summary
This PR fixes a bug with error correlations not displayed correctly in the APM waterfall when using Otel native data. In Otel native data
parent.idis never defined so in this case we need to fallback tospan.id