Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inventory][ECO] Return metadata values #195204

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[Inventory][ECO] Return metadata values #195204

merged 2 commits into from
Oct 9, 2024

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Oct 7, 2024 •
edited by kibanamachine
Loading

#194131

Use entity.identityFields instead of host, container and service specific ones. Get the first environment available.

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) v8.16.0 labels Oct 7, 2024
@cauemarcondes cauemarcondes requested review from a team as code owners October 7, 2024 09:49
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Oct 7, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
inventory 238 237 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observabilityShared 487 488 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 222.8KB 222.7KB -55.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityShared 72.3KB 72.3KB +83.0B
Unknown metric groups

API count

id before after diff
observabilityShared 492 493 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 8, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: fc1edb3
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-195204-fc1edb348253

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group6.ts / discover/esql discover esql view switch modal should not show switch modal when switching to a data view while a saved search is open

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
inventory 238 237 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observabilityShared 487 488 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 222.8KB 222.7KB -55.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityShared 72.3KB 72.3KB +83.0B
Unknown metric groups

API count

id before after diff
observabilityShared 492 493 +1

History

@cauemarcondes cauemarcondes merged commit 9975fd6 into elastic:main Oct 9, 2024
25 checks passed
@cauemarcondes cauemarcondes deleted the inventory-service-link branch October 9, 2024 07:43
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11250470290

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 9, 2024
@cauemarcondes
[Inventory][ECO] Return metadata values (elastic#195204)
71fcca5 
elastic#194131

Use `entity.identityFields` instead of host, container and service
specific ones. Get the first environment available.

(cherry picked from commit 9975fd6)
@kibanamachine kibanamachine mentioned this pull request Oct 9, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 9, 2024
@kibanamachine @cauemarcondes
[8.x] [Inventory][ECO] Return metadata values (#195204) (#195538)
128dcb6 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inventory][ECO] Return metadata values
(#195204)](#195204)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T07:43:52Z","message":"[Inventory][ECO]
Return metadata values
(#195204)\n\nhttps://github.com//issues/194131\r\n\r\nUse
`entity.identityFields` instead of host, container and
service\r\nspecific ones. Get the first environment
available.","sha":"9975fd63d38a4a6baa27ec34c32d49dab53ec854","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","v8.16.0"],"title":"[Inventory][ECO]
Return metadata
values","number":195204,"url":"https://github.com/elastic/kibana/pull/195204","mergeCommit":{"message":"[Inventory][ECO]
Return metadata values
(#195204)\n\nhttps://github.com//issues/194131\r\n\r\nUse
`entity.identityFields` instead of host, container and
service\r\nspecific ones. Get the first environment
available.","sha":"9975fd63d38a4a6baa27ec34c32d49dab53ec854"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195204","number":195204,"mergeCommit":{"message":"[Inventory][ECO]
Return metadata values
(#195204)\n\nhttps://github.com//issues/194131\r\n\r\nUse
`entity.identityFields` instead of host, container and
service\r\nspecific ones. Get the first environment
available.","sha":"9975fd63d38a4a6baa27ec34c32d49dab53ec854"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Cauê Marcondes <[email protected]>
@cauemarcondes cauemarcondes mentioned this pull request Oct 9, 2024
Merged
cauemarcondes added a commit that referenced this pull request Oct 9, 2024
@cauemarcondes
[Inventory] Fixing entity links (#195625)
d2644ff 
Regression from #195204
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 9, 2024
@cauemarcondes
[Inventory] Fixing entity links (elastic#195625)
4575367 
Regression from elastic#195204

(cherry picked from commit d2644ff)
@cauemarcondes cauemarcondes linked an issue Oct 15, 2024 that may be closed by this pull request
[Inventory][ECO] Return metadata values #194131
Closed
@cauemarcondes cauemarcondes mentioned this pull request Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Inventory][ECO] Return metadata values
5 participants
@cauemarcondes @kibana-ci @elasticmachine @kibanamachine @crespocarlos