Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inventory][ECO] Return metadata values #194131

Closed
cauemarcondes opened this issue Sep 26, 2024 · 2 comments · Fixed by #195204
Closed

[Inventory][ECO] Return metadata values #194131

cauemarcondes opened this issue Sep 26, 2024 · 2 comments · Fixed by #195204
Assignees
@cauemarcondes
Labels
Feature:EntitiesInventory Observability entities inventory feature Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture

Comments

@cauemarcondes
Copy link
Contributor

On this issue #192676 we want to link Entity types to their specific pages (APM/Host/Container).

On the Inventory table we use the entity.displayName field on the Entity name column. But for Service type entities this value might be formated like service.name:service.environement.

On this PR we are adding a temporary solution, where we split the name by : and pass it to APM.

A better approach would be using the entity.identityFields and get the values from the metadata.
@cauemarcondes cauemarcondes added Feature:EntitiesInventory Observability entities inventory feature needs-refinement A reason and acceptance criteria need to be defined for this issue Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture labels Sep 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@cauemarcondes cauemarcondes mentioned this issue Sep 26, 2024
Merged
@cauemarcondes cauemarcondes mentioned this issue Oct 7, 2024
Merged
@cauemarcondes cauemarcondes assigned cauemarcondes and unassigned smith Oct 7, 2024
cauemarcondes added a commit that referenced this issue Oct 9, 2024
@cauemarcondes
[Inventory][ECO] Return metadata values (#195204)
9975fd6 
#194131

Use `entity.identityFields` instead of host, container and service
specific ones. Get the first environment available.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 9, 2024
@cauemarcondes
[Inventory][ECO] Return metadata values (elastic#195204)
71fcca5 
elastic#194131

Use `entity.identityFields` instead of host, container and service
specific ones. Get the first environment available.

(cherry picked from commit 9975fd6)
kibanamachine added a commit that referenced this issue Oct 9, 2024
@kibanamachine @cauemarcondes
[8.x] [Inventory][ECO] Return metadata values (#195204) (#195538)
128dcb6 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inventory][ECO] Return metadata values
(#195204)](#195204)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T07:43:52Z","message":"[Inventory][ECO]
Return metadata values
(#195204)\n\nhttps://github.com//issues/194131\r\n\r\nUse
`entity.identityFields` instead of host, container and
service\r\nspecific ones. Get the first environment
available.","sha":"9975fd63d38a4a6baa27ec34c32d49dab53ec854","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","v8.16.0"],"title":"[Inventory][ECO]
Return metadata
values","number":195204,"url":"https://github.com/elastic/kibana/pull/195204","mergeCommit":{"message":"[Inventory][ECO]
Return metadata values
(#195204)\n\nhttps://github.com//issues/194131\r\n\r\nUse
`entity.identityFields` instead of host, container and
service\r\nspecific ones. Get the first environment
available.","sha":"9975fd63d38a4a6baa27ec34c32d49dab53ec854"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195204","number":195204,"mergeCommit":{"message":"[Inventory][ECO]
Return metadata values
(#195204)\n\nhttps://github.com//issues/194131\r\n\r\nUse
`entity.identityFields` instead of host, container and
service\r\nspecific ones. Get the first environment
available.","sha":"9975fd63d38a4a6baa27ec34c32d49dab53ec854"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Cauê Marcondes <[email protected]>
@crespocarlos crespocarlos removed the needs-refinement A reason and acceptance criteria need to be defined for this issue label Oct 10, 2024
@cauemarcondes cauemarcondes linked a pull request Oct 15, 2024 that will close this issue
[Inventory][ECO] Return metadata values #195204
Merged
@cauemarcondes
Copy link
Contributor Author

closed by #195204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cauemarcondes cauemarcondes

Labels
Feature:EntitiesInventory Observability entities inventory feature Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Inventory][ECO] Return metadata values cauemarcondes/kibana
4 participants
@smith @crespocarlos @elasticmachine @cauemarcondes