Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Dataset Quality] Implement _ignored root cause identification flow (#192370) #194910

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…lastic#192370)

## Summary

Closes - elastic#192471
Closes - elastic#191055

The PR adds Flyout to the Degraded Fields inside the Dataset Quality
Details page where the Root Cause of the Degraded Field is diagnosed.

## Pending Items

- [x] API Tests for 1 new and 2 old API modifications
- [x] E2E Tests for the Flyout

## How to test this

NOTE (Below guide is for Stateful, you can do the same for serverless)

- Checkout the PR using - `gh pr checkout 192370`

1. Start the FTR server using the command below

```
 yarn test:ftr:server --config ./x-pack/test/functional/apps/dataset_quality/config.ts
 ```

 2. Go to the following path - `x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts`
 3. Comment out the 2 `after` blocks present at Line - 54-56 and 414-416
 4. Run the FTR runner  using the command below

 ```
yarn test:ftr:runner --config ./x-pack/test/functional/apps/dataset_quality/config.ts --include ./x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts
```

Let the test run and go green

5. Navigate to `http://localhost:5620/app/management/data/data_quality/`
username - `test_user` and password - `changeme`

6. Select the `degraded.dataset.rca` dataset

You will have an environment ready to test the flyout different
scenarios

## Demo

## Field Limit and Ignore above isse

![Field Limit
Issue](https://github.com/user-attachments/assets/5908f1a8-ed85-455b-8f61-894b2fc6bb1c)

## Warning about not current quality issue

![Current Quality
Issue](https://github.com/user-attachments/assets/1dd6278f-75f8-4715-bd83-8ac9784afbf7)

## Blocker

There is an Elasticsearch issue on Serverless, which becomes a blocker
for merging this PR

elastic/elasticsearch-serverless#2815
(cherry picked from commit 0d19367)
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #5 / FilesTable renders single result count properly

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/deeplinks-observability 50 51 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataQuality 28.1KB 28.2KB +104.0B
datasetQuality 220.4KB 230.2KB +9.7KB
total +9.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataQuality 8.0KB 8.0KB +35.0B
datasetQuality 18.4KB 18.5KB +59.0B
total +94.0B
Unknown metric groups

API count

id before after diff
@kbn/deeplinks-observability 62 63 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @achyutjhunjhunwala

@kibanamachine kibanamachine merged commit 29be4a5 into elastic:8.x Oct 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants