[Dataset Quality] Implement _ignored root cause identification flow #192370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achyutjhunjhunwala
added
release_note:feature
|
@simianhacker As discussed over Slack, this is the PR where i had to skip the Alerting test. To add a bit more context, as part of this PR, we are calculating current number of fields present in mapping and comparing it against limits to see if its a Limit Overflow issue which cause a field to be ignored or not. |
…everting the API logic and skiping proper code in kbn-data-forge for alerting tests
|
@achyutjhunjhunwala I pushed some fixes and un-skipped the burn rate rule. |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11176012600 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 4, 2024
…lastic#192370) ## Summary Closes - elastic#192471 Closes - elastic#191055 The PR adds Flyout to the Degraded Fields inside the Dataset Quality Details page where the Root Cause of the Degraded Field is diagnosed. ## Pending Items - [x] API Tests for 1 new and 2 old API modifications - [x] E2E Tests for the Flyout ## How to test this NOTE (Below guide is for Stateful, you can do the same for serverless) - Checkout the PR using - `gh pr checkout 192370` 1. Start the FTR server using the command below ``` yarn test:ftr:server --config ./x-pack/test/functional/apps/dataset_quality/config.ts ``` 2. Go to the following path - `x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts` 3. Comment out the 2 `after` blocks present at Line - 54-56 and 414-416 4. Run the FTR runner using the command below ``` yarn test:ftr:runner --config ./x-pack/test/functional/apps/dataset_quality/config.ts --include ./x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts ``` Let the test run and go green 5. Navigate to `http://localhost:5620/app/management/data/data_quality/` username - `test_user` and password - `changeme` 6. Select the `degraded.dataset.rca` dataset You will have an environment ready to test the flyout different scenarios ## Demo ## Field Limit and Ignore above isse  ## Warning about not current quality issue  ## Blocker There is an Elasticsearch issue on Serverless, which becomes a blocker for merging this PR elastic/elasticsearch-serverless#2815 (cherry picked from commit 0d19367)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 4, 2024
…flow (#192370) (#194910) # Backport This will backport the following commits from `main` to `8.x`: - [[Dataset Quality] Implement _ignored root cause identification flow (#192370)](#192370) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Achyut Jhunjhunwala","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-04T07:41:55Z","message":"[Dataset Quality] Implement _ignored root cause identification flow (#192370)\n\n## Summary\r\n\r\nCloses - https://github.com/elastic/kibana/issues/192471\r\nCloses - https://github.com/elastic/kibana/issues/191055\r\n\r\nThe PR adds Flyout to the Degraded Fields inside the Dataset Quality\r\nDetails page where the Root Cause of the Degraded Field is diagnosed.\r\n\r\n## Pending Items\r\n\r\n- [x] API Tests for 1 new and 2 old API modifications\r\n- [x] E2E Tests for the Flyout\r\n\r\n## How to test this\r\n\r\nNOTE (Below guide is for Stateful, you can do the same for serverless)\r\n\r\n- Checkout the PR using - `gh pr checkout 192370`\r\n\r\n1. Start the FTR server using the command below\r\n\r\n```\r\n yarn test:ftr:server --config ./x-pack/test/functional/apps/dataset_quality/config.ts\r\n ```\r\n \r\n 2. Go to the following path - `x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts`\r\n 3. Comment out the 2 `after` blocks present at Line - 54-56 and 414-416\r\n 4. Run the FTR runner using the command below\r\n \r\n ```\r\nyarn test:ftr:runner --config ./x-pack/test/functional/apps/dataset_quality/config.ts --include ./x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts\r\n```\r\n\r\nLet the test run and go green\r\n\r\n5. Navigate to `http://localhost:5620/app/management/data/data_quality/`\r\nusername - `test_user` and password - `changeme`\r\n\r\n6. Select the `degraded.dataset.rca` dataset\r\n\r\nYou will have an environment ready to test the flyout different\r\nscenarios\r\n\r\n## Demo\r\n\r\n## Field Limit and Ignore above isse\r\n\r\n\r\n\r\n## Warning about not current quality issue\r\n\r\n\r\n\r\n## Blocker\r\n\r\nThere is an Elasticsearch issue on Serverless, which becomes a blocker\r\nfor merging this PR\r\n\r\nhttps://github.com/elastic/elasticsearch-serverless/issues/2815","sha":"0d19367fdfad5526b5220dfdf18b4991fe6b3abd","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["v9.0.0","release_note:feature","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs","Feature:Dataset Health"],"title":"[Dataset Quality] Implement _ignored root cause identification flow","number":192370,"url":"https://github.com/elastic/kibana/pull/192370","mergeCommit":{"message":"[Dataset Quality] Implement _ignored root cause identification flow (#192370)\n\n## Summary\r\n\r\nCloses - https://github.com/elastic/kibana/issues/192471\r\nCloses - https://github.com/elastic/kibana/issues/191055\r\n\r\nThe PR adds Flyout to the Degraded Fields inside the Dataset Quality\r\nDetails page where the Root Cause of the Degraded Field is diagnosed.\r\n\r\n## Pending Items\r\n\r\n- [x] API Tests for 1 new and 2 old API modifications\r\n- [x] E2E Tests for the Flyout\r\n\r\n## How to test this\r\n\r\nNOTE (Below guide is for Stateful, you can do the same for serverless)\r\n\r\n- Checkout the PR using - `gh pr checkout 192370`\r\n\r\n1. Start the FTR server using the command below\r\n\r\n```\r\n yarn test:ftr:server --config ./x-pack/test/functional/apps/dataset_quality/config.ts\r\n ```\r\n \r\n 2. Go to the following path - `x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts`\r\n 3. Comment out the 2 `after` blocks present at Line - 54-56 and 414-416\r\n 4. Run the FTR runner using the command below\r\n \r\n ```\r\nyarn test:ftr:runner --config ./x-pack/test/functional/apps/dataset_quality/config.ts --include ./x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts\r\n```\r\n\r\nLet the test run and go green\r\n\r\n5. Navigate to `http://localhost:5620/app/management/data/data_quality/`\r\nusername - `test_user` and password - `changeme`\r\n\r\n6. Select the `degraded.dataset.rca` dataset\r\n\r\nYou will have an environment ready to test the flyout different\r\nscenarios\r\n\r\n## Demo\r\n\r\n## Field Limit and Ignore above isse\r\n\r\n\r\n\r\n## Warning about not current quality issue\r\n\r\n\r\n\r\n## Blocker\r\n\r\nThere is an Elasticsearch issue on Serverless, which becomes a blocker\r\nfor merging this PR\r\n\r\nhttps://github.com/elastic/elasticsearch-serverless/issues/2815","sha":"0d19367fdfad5526b5220dfdf18b4991fe6b3abd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192370","number":192370,"mergeCommit":{"message":"[Dataset Quality] Implement _ignored root cause identification flow (#192370)\n\n## Summary\r\n\r\nCloses - https://github.com/elastic/kibana/issues/192471\r\nCloses - https://github.com/elastic/kibana/issues/191055\r\n\r\nThe PR adds Flyout to the Degraded Fields inside the Dataset Quality\r\nDetails page where the Root Cause of the Degraded Field is diagnosed.\r\n\r\n## Pending Items\r\n\r\n- [x] API Tests for 1 new and 2 old API modifications\r\n- [x] E2E Tests for the Flyout\r\n\r\n## How to test this\r\n\r\nNOTE (Below guide is for Stateful, you can do the same for serverless)\r\n\r\n- Checkout the PR using - `gh pr checkout 192370`\r\n\r\n1. Start the FTR server using the command below\r\n\r\n```\r\n yarn test:ftr:server --config ./x-pack/test/functional/apps/dataset_quality/config.ts\r\n ```\r\n \r\n 2. Go to the following path - `x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts`\r\n 3. Comment out the 2 `after` blocks present at Line - 54-56 and 414-416\r\n 4. Run the FTR runner using the command below\r\n \r\n ```\r\nyarn test:ftr:runner --config ./x-pack/test/functional/apps/dataset_quality/config.ts --include ./x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts\r\n```\r\n\r\nLet the test run and go green\r\n\r\n5. Navigate to `http://localhost:5620/app/management/data/data_quality/`\r\nusername - `test_user` and password - `changeme`\r\n\r\n6. Select the `degraded.dataset.rca` dataset\r\n\r\nYou will have an environment ready to test the flyout different\r\nscenarios\r\n\r\n## Demo\r\n\r\n## Field Limit and Ignore above isse\r\n\r\n\r\n\r\n## Warning about not current quality issue\r\n\r\n\r\n\r\n## Blocker\r\n\r\nThere is an Elasticsearch issue on Serverless, which becomes a blocker\r\nfor merging this PR\r\n\r\nhttps://github.com/elastic/elasticsearch-serverless/issues/2815","sha":"0d19367fdfad5526b5220dfdf18b4991fe6b3abd"}}]}] BACKPORT--> Co-authored-by: Achyut Jhunjhunwala <[email protected]>
tiansivive
pushed a commit
to tiansivive/kibana
that referenced
this pull request
Oct 7, 2024
…lastic#192370) ## Summary Closes - elastic#192471 Closes - elastic#191055 The PR adds Flyout to the Degraded Fields inside the Dataset Quality Details page where the Root Cause of the Degraded Field is diagnosed. ## Pending Items - [x] API Tests for 1 new and 2 old API modifications - [x] E2E Tests for the Flyout ## How to test this NOTE (Below guide is for Stateful, you can do the same for serverless) - Checkout the PR using - `gh pr checkout 192370` 1. Start the FTR server using the command below ``` yarn test:ftr:server --config ./x-pack/test/functional/apps/dataset_quality/config.ts ``` 2. Go to the following path - `x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts` 3. Comment out the 2 `after` blocks present at Line - 54-56 and 414-416 4. Run the FTR runner using the command below ``` yarn test:ftr:runner --config ./x-pack/test/functional/apps/dataset_quality/config.ts --include ./x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts ``` Let the test run and go green 5. Navigate to `http://localhost:5620/app/management/data/data_quality/` username - `test_user` and password - `changeme` 6. Select the `degraded.dataset.rca` dataset You will have an environment ready to test the flyout different scenarios ## Demo ## Field Limit and Ignore above isse  ## Warning about not current quality issue  ## Blocker There is an Elasticsearch issue on Serverless, which becomes a blocker for merging this PR elastic/elasticsearch-serverless#2815
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes - #192471
Closes - #191055
The PR adds Flyout to the Degraded Fields inside the Dataset Quality Details page where the Root Cause of the Degraded Field is diagnosed.
Pending Items
How to test this
NOTE (Below guide is for Stateful, you can do the same for serverless)
gh pr checkout 192370x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.tsafterblocks present at Line - 54-56 and 414-416Let the test run and go green
Navigate to
http://localhost:5620/app/management/data/data_quality/username -
test_userand password -changemeSelect the
degraded.dataset.rcadatasetYou will have an environment ready to test the flyout different scenarios
Demo
Field Limit and Ignore above isse
Warning about not current quality issue
Blocker
There is an Elasticsearch issue on Serverless, which becomes a blocker for merging this PR
https://github.com/elastic/elasticsearch-serverless/issues/2815