Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Fix system index label in Stack Monitoring screen #194839

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

consulthys
Copy link
Contributor

Closes #194838

Summary

This PR wraps up the change made in #76946 (issue #77492)

The change was about relabeling the "Show system indices" toggle showing below to "Filter for system indices", but when no indices show up, the warning message still contains the old text, i.e. "Show system indices"

Image

Image

Checklist

@consulthys consulthys added backport Team:Monitoring Stack Monitoring team release_note:skip Skip the PR/issue when compiling release notes Feature:Stack Monitoring labels Oct 3, 2024
@consulthys consulthys self-assigned this Oct 3, 2024
@consulthys consulthys requested a review from a team as a code owner October 3, 2024 13:33
@consulthys consulthys changed the title Fix system index label in Stack Monitoring screen [Monitoring] Fix system index label in Stack Monitoring screen Oct 3, 2024
Copy link

@sachin-frayne sachin-frayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@consulthys consulthys enabled auto-merge (squash) October 3, 2024 15:01
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 533.3KB 533.3KB +6.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @consulthys

@consulthys consulthys merged commit 49e0c36 into main Oct 3, 2024
26 checks passed
@consulthys consulthys deleted the stack-mon-fix-system-index-label branch October 3, 2024 15:21
@kibanamachine kibanamachine added v9.0.0 backport:skip This commit does not require backporting labels Oct 3, 2024
@consulthys consulthys removed the backport:skip This commit does not require backporting label Oct 3, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 3, 2024
tiansivive pushed a commit to tiansivive/kibana that referenced this pull request Oct 7, 2024
…ic#194839)

Closes elastic#194838

## Summary

This PR wraps up the change made in
elastic#76946 (issue
elastic#77492)

The change was about relabeling the "Show system indices" toggle showing
below to "Filter for system indices", but when no indices show up, the
warning message still contains the old text, i.e. "Show system indices"


![Image](https://github.com/user-attachments/assets/9c3003a8-5689-4d3a-8175-8e707d1ec40a)


![Image](https://github.com/user-attachments/assets/cfdd9ba1-d87d-47ae-afb9-4fa81473230d)

### Checklist

- [X] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [X] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [X] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting backport Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes Team:Monitoring Stack Monitoring team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Monitoring] Fix "Show system indices" description
4 participants