Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Fix "Show system indices" description #194838

Closed
consulthys opened this issue Oct 3, 2024 · 0 comments · Fixed by #194839
Closed

[Monitoring] Fix "Show system indices" description #194838

consulthys opened this issue Oct 3, 2024 · 0 comments · Fixed by #194839
Assignees
@consulthys
Labels
Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes Team:Monitoring Stack Monitoring team

Comments

@consulthys
Copy link
Contributor

Issue #77492 (PR #76946) introduced a few UI updates to fix some confusing labels.

One of those changes happened in the Stack Monitoring UI and was about relabeling the "Show system indices" toggle showing below to "Filter for system indices"

Image

However, when no indices show up, the warning message still contains the old text, i.e. "Show system indices"

Image
@consulthys consulthys added backport Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes Team:Monitoring Stack Monitoring team labels Oct 3, 2024
@consulthys consulthys self-assigned this Oct 3, 2024
@consulthys consulthys mentioned this issue Oct 3, 2024
Merged
3 tasks
tiansivive pushed a commit to tiansivive/kibana that referenced this issue Oct 7, 2024
@consulthys @tiansivive
[Monitoring] Fix system index label in Stack Monitoring screen (elast…
6fedec4 
…ic#194839)

Closes elastic#194838

## Summary

This PR wraps up the change made in
elastic#76946 (issue
elastic#77492)

The change was about relabeling the "Show system indices" toggle showing
below to "Filter for system indices", but when no indices show up, the
warning message still contains the old text, i.e. "Show system indices"


![Image](https://github.com/user-attachments/assets/9c3003a8-5689-4d3a-8175-8e707d1ec40a)


![Image](https://github.com/user-attachments/assets/cfdd9ba1-d87d-47ae-afb9-4fa81473230d)

### Checklist

- [X] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [X] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [X] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@consulthys consulthys

Labels
Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes Team:Monitoring Stack Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Monitoring] Fix system index label in Stack Monitoring screen elastic/kibana
1 participant
@consulthys