Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL][Lens] Fixes the filter out legend action #194374

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Sep 30, 2024

Summary

Closes #194373

Fixes the filter out legend action

Checklist

@stratoula stratoula added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana labels Sep 30, 2024
@stratoula stratoula marked this pull request as ready for review September 30, 2024 06:52
@stratoula stratoula requested review from a team as code owners September 30, 2024 06:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 419.2KB 419.4KB +192.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested by merging with #193820 and it now works as expected 🙏

@stratoula
Copy link
Contributor Author

stratoula commented Sep 30, 2024

Thanx no need to merge with the open PR 🤔 This is also reproducible in main. Anywayz thanx for the review! (you just needed to create an ordinal chart with stats by :)

@stratoula stratoula merged commit abffb37 into elastic:main Sep 30, 2024
32 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11103394856

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 30, 2024
## Summary

Closes elastic#194373

Fixes the filter out legend action

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit abffb37)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 30, 2024
…4398)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL][Lens] Fixes the filter out legend action
(#194374)](#194374)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-30T09:33:36Z","message":"[ES|QL][Lens]
Fixes the filter out legend action (#194374)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/194373\r\n\r\nFixes the filter
out legend action\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"abffb37ead4f4dec159e91742e4380a36cefdf10","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","v9.0.0","backport:prev-minor","Feature:ES|QL","v8.16.0"],"title":"[ES|QL][Lens]
Fixes the filter out legend
action","number":194374,"url":"https://github.com/elastic/kibana/pull/194374","mergeCommit":{"message":"[ES|QL][Lens]
Fixes the filter out legend action (#194374)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/194373\r\n\r\nFixes the filter
out legend action\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"abffb37ead4f4dec159e91742e4380a36cefdf10"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194374","number":194374,"mergeCommit":{"message":"[ES|QL][Lens]
Fixes the filter out legend action (#194374)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/194373\r\n\r\nFixes the filter
out legend action\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"abffb37ead4f4dec159e91742e4380a36cefdf10"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ES|QL][Lens] Legend filter out filter works like filter in
5 participants