-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL][Lens] Fixes the filter out legend action #194374
Conversation
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
💚 Build Succeeded
Metrics [docs]Page load bundle
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested by merging with #193820 and it now works as expected 🙏
Thanx no need to merge with the open PR 🤔 This is also reproducible in main. Anywayz thanx for the review! (you just needed to create an ordinal chart with stats by :) |
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11103394856 |
## Summary Closes elastic#194373 Fixes the filter out legend action ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit abffb37)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…4398) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL][Lens] Fixes the filter out legend action (#194374)](#194374) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-30T09:33:36Z","message":"[ES|QL][Lens] Fixes the filter out legend action (#194374)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/194373\r\n\r\nFixes the filter out legend action\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"abffb37ead4f4dec159e91742e4380a36cefdf10","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","v9.0.0","backport:prev-minor","Feature:ES|QL","v8.16.0"],"title":"[ES|QL][Lens] Fixes the filter out legend action","number":194374,"url":"https://github.com/elastic/kibana/pull/194374","mergeCommit":{"message":"[ES|QL][Lens] Fixes the filter out legend action (#194374)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/194373\r\n\r\nFixes the filter out legend action\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"abffb37ead4f4dec159e91742e4380a36cefdf10"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194374","number":194374,"mergeCommit":{"message":"[ES|QL][Lens] Fixes the filter out legend action (#194374)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/194373\r\n\r\nFixes the filter out legend action\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"abffb37ead4f4dec159e91742e4380a36cefdf10"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <[email protected]>
Summary
Closes #194373
Fixes the filter out legend action
Checklist