Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Spaces] Filtering out features that do not have space scope" #194329

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Revert "[Spaces] Filtering out features that do not have space scope" #194329

merged 2 commits into from
Sep 30, 2024

Conversation

elena-shostak
Copy link
Contributor

@elena-shostak elena-shostak commented Sep 27, 2024 •
edited by kibanamachine
Loading

Reverts #194157

@elena-shostak elena-shostak added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Security/Spaces Platform Security - Spaces feature backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Sep 27, 2024
@elena-shostak elena-shostak requested a review from a team as a code owner September 27, 2024 17:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@elena-shostak elena-shostak added the release_note:skip Skip the PR/issue when compiling release notes label Sep 27, 2024
@elena-shostak elena-shostak enabled auto-merge (squash) September 27, 2024 17:04
@elena-shostak
Copy link
Contributor Author

@elasticmachine merge upstream

@elena-shostak elena-shostak merged commit 65014d1 into main Sep 30, 2024
21 checks passed
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
spaces 256.8KB 256.6KB -205.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elena-shostak elena-shostak deleted the revert-194157-194134-space-features branch September 30, 2024 09:53
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11103702005

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 30, 2024
@elena-shostak
Revert "[Spaces] Filtering out features that do not have space scope" (…
6c76871 
…elastic#194329)

Reverts elastic#194157

(cherry picked from commit 65014d1)
@kibanamachine kibanamachine mentioned this pull request Sep 30, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 30, 2024
@kibanamachine @elena-shostak
[8.x] Revert "[Spaces] Filtering out features that do not have s…
a5b2d04 
…pace scope" (#194329) (#194401)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Revert "[Spaces] Filtering out features that do not have space
scope" (#194329)](#194329)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Elena
Shostak","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-30T09:53:04Z","message":"Revert
\"[Spaces] Filtering out features that do not have space scope\"
(#194329)\n\nReverts
#194157","sha":"65014d1b6aba514ae29bb66f9ff2f869f8526d0a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","Feature:Security/Spaces","release_note:skip","v9.0.0","backport:prev-minor"],"title":"Revert
\"[Spaces] Filtering out features that do not have space
scope\"","number":194329,"url":"https://github.com/elastic/kibana/pull/194329","mergeCommit":{"message":"Revert
\"[Spaces] Filtering out features that do not have space scope\"
(#194329)\n\nReverts
#194157","sha":"65014d1b6aba514ae29bb66f9ff2f869f8526d0a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194329","number":194329,"mergeCommit":{"message":"Revert
\"[Spaces] Filtering out features that do not have space scope\"
(#194329)\n\nReverts
#194157","sha":"65014d1b6aba514ae29bb66f9ff2f869f8526d0a"}}]}]
BACKPORT-->

Co-authored-by: Elena Shostak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiddharthMantri SiddharthMantri SiddharthMantri approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Security/Spaces Platform Security - Spaces feature release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elena-shostak @elasticmachine @kibana-ci @kibanamachine @SiddharthMantri