[Spaces] Filtering out features that do not have space scope #194157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elena-shostak
added
Team:Security
|
Pinging @elastic/kibana-security (Team:Security) |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11058338116 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2024
…#194157) ## Summary Filtering out features that do not have space scope in `create_space_page` ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios __Fixes: https://github.com/elastic/kibana/issues/194134__ ## Release Note Filtering out features that do not have space scope in `create_space_page` (cherry picked from commit f8416b8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2024
…194157) (#194212) # Backport This will backport the following commits from `main` to `8.x`: - [[Spaces] Filtering out features that do not have space scope (#194157)](#194157) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Elena Shostak","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T18:44:11Z","message":"[Spaces] Filtering out features that do not have space scope (#194157)\n\n## Summary\r\n\r\nFiltering out features that do not have space scope in\r\n`create_space_page`\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n__Fixes: https://github.com/elastic/kibana/issues/194134__\r\n\r\n## Release Note\r\nFiltering out features that do not have space scope in\r\n`create_space_page`","sha":"f8416b892744ced1864404670a51e501237446c3","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Security","Feature:Security/Spaces","v9.0.0","backport:prev-minor"],"title":"[Spaces] Filtering out features that do not have space scope","number":194157,"url":"https://github.com/elastic/kibana/pull/194157","mergeCommit":{"message":"[Spaces] Filtering out features that do not have space scope (#194157)\n\n## Summary\r\n\r\nFiltering out features that do not have space scope in\r\n`create_space_page`\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n__Fixes: https://github.com/elastic/kibana/issues/194134__\r\n\r\n## Release Note\r\nFiltering out features that do not have space scope in\r\n`create_space_page`","sha":"f8416b892744ced1864404670a51e501237446c3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194157","number":194157,"mergeCommit":{"message":"[Spaces] Filtering out features that do not have space scope (#194157)\n\n## Summary\r\n\r\nFiltering out features that do not have space scope in\r\n`create_space_page`\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n__Fixes: https://github.com/elastic/kibana/issues/194134__\r\n\r\n## Release Note\r\nFiltering out features that do not have space scope in\r\n`create_space_page`","sha":"f8416b892744ced1864404670a51e501237446c3"}}]}] BACKPORT--> Co-authored-by: Elena Shostak <[email protected]>
elena-shostak
added a commit
that referenced
this pull request
Sep 30, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 30, 2024
…elastic#194329) Reverts elastic#194157 (cherry picked from commit 65014d1)
kibanamachine
added a commit
that referenced
this pull request
Sep 30, 2024
…pace scope" (#194329) (#194401) # Backport This will backport the following commits from `main` to `8.x`: - [Revert "[Spaces] Filtering out features that do not have space scope" (#194329)](#194329) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Elena Shostak","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-30T09:53:04Z","message":"Revert \"[Spaces] Filtering out features that do not have space scope\" (#194329)\n\nReverts #194157","sha":"65014d1b6aba514ae29bb66f9ff2f869f8526d0a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","Feature:Security/Spaces","release_note:skip","v9.0.0","backport:prev-minor"],"title":"Revert \"[Spaces] Filtering out features that do not have space scope\"","number":194329,"url":"https://github.com/elastic/kibana/pull/194329","mergeCommit":{"message":"Revert \"[Spaces] Filtering out features that do not have space scope\" (#194329)\n\nReverts #194157","sha":"65014d1b6aba514ae29bb66f9ff2f869f8526d0a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194329","number":194329,"mergeCommit":{"message":"Revert \"[Spaces] Filtering out features that do not have space scope\" (#194329)\n\nReverts #194157","sha":"65014d1b6aba514ae29bb66f9ff2f869f8526d0a"}}]}] BACKPORT--> Co-authored-by: Elena Shostak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Filtering out features that do not have space scope in
create_space_pageChecklist
Fixes: #194134
Release Note
Filtering out features that do not have space scope in
create_space_page