-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Automatic import] readme input types templates #194308
base: main
Are you sure you want to change the base?
[Automatic import] readme input types templates #194308
Conversation
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A handful of nits as I read through initially.
x-pack/plugins/integration_assistant/server/templates/package_readme.md.njk
Outdated
Show resolved
Hide resolved
x-pack/plugins/integration_assistant/server/templates/readme/setup/cel.md.njk
Outdated
Show resolved
Hide resolved
x-pack/plugins/integration_assistant/server/templates/readme/setup/aws-cloudwatch.md.njk
Outdated
Show resolved
Hide resolved
x-pack/plugins/integration_assistant/server/templates/readme/setup/aws-s3.md.njk
Outdated
Show resolved
Hide resolved
x-pack/plugins/integration_assistant/server/templates/readme/setup/azure-blob-storage.md.njk
Outdated
Show resolved
Hide resolved
x-pack/plugins/integration_assistant/server/templates/readme/setup/http_endpoint.md.njk
Outdated
Show resolved
Hide resolved
...k/plugins/integration_assistant/server/templates/readme/troubleshooting/http_endpoint.md.njk
Outdated
Show resolved
Hide resolved
Hey all - we're trying to standardize some documentation templates for certain inputs supported by Automatic Import. We would appreciate a quick review from a CODEOWNER for each input listed, if possible. 🙏 @elastic/security-service-integrations: @elastic/obs-cloud-monitoring: |
Co-authored-by: Eric Beahan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the sources for these docs?
The event hub docs seem to come from https://github.com/elastic/integrations/blob/main/packages/azure/_dev/build/docs/README.md. I'm not familiar with these CloudWatch and S3 docs.
Do these docs focus on the (Filebeat) input or the (Elastic Agent) integration?
Is this a one-time import, or is it a sync that will happen regularly?
x-pack/plugins/integration_assistant/server/templates/package_readme.md.njk
Outdated
Show resolved
Hide resolved
x-pack/plugins/integration_assistant/server/templates/package_readme.md.njk
Outdated
Show resolved
Hide resolved
x-pack/plugins/integration_assistant/server/templates/package_readme.md.njk
Outdated
Show resolved
Hide resolved
x-pack/plugins/integration_assistant/server/templates/package_readme.md.njk
Outdated
Show resolved
Hide resolved
x-pack/plugins/integration_assistant/server/templates/package_readme.md.njk
Outdated
Show resolved
Hide resolved
x-pack/plugins/integration_assistant/server/templates/readme/setup/aws-s3.md.njk
Outdated
Show resolved
Hide resolved
x-pack/plugins/integration_assistant/server/templates/readme/setup/aws-s3.md.njk
Outdated
Show resolved
Hide resolved
x-pack/plugins/integration_assistant/server/templates/readme/setup/aws-s3.md.njk
Outdated
Show resolved
Hide resolved
x-pack/plugins/integration_assistant/server/templates/readme/setup/cel.md.njk
Outdated
Show resolved
Hide resolved
x-pack/plugins/integration_assistant/server/templates/readme/setup/gcp-pubsub.md.njk
Outdated
Show resolved
Hide resolved
Co-authored-by: Dan Kortschak <[email protected]>
…etup/cel.md.njk Co-authored-by: Dan Kortschak <[email protected]>
The documentation comes from the multiple Readme files from the different integrations in the integrations repo.
The templates will be used by automatic import when generating new integrations by users |
Do these docs focus on the (Filebeat) input or the (Elastic Agent) integration? |
the Elastic Agent integration |
Discussed a bit with @haetamoudi offline. Looking at the list, my guidance is as follows:
The Fleet UX points to the SSL docs, so I think it's an ok approach here to do the same: |
Summary
Enhance
Readme
with documentation specific to Input types.For now the templates under
x-pack/plugins/integration_assistant/server/templates/readme/setup/*
are not used anywhere. The goal of the PR is to complete those templates, we will integrate them into thereadme
in a follow up PR