Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Enable more inputs in Filebeat. #17909

Merged
merged 2 commits into from
Apr 23, 2020

Conversation

ph
Copy link
Contributor

@ph ph commented Apr 22, 2020

Enable S3, Azureeventhub, cloudfoundry, httpjson, netflow, o365audit

We were missing a number of x-pack specific inputs

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ph ph requested a review from michalpristas April 22, 2020 18:30
@ph ph self-assigned this Apr 22, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

ph added 2 commits April 22, 2020 14:33
Enable S3, Azureeventhub, cloudfoundry, httpjson, netflow, o365audit

We were missing a number of x-pack specific inputs
@ph ph force-pushed the elastic-agent/missing-input-type branch from 97bf20e to cccef85 Compare April 22, 2020 18:34
@ph
Copy link
Contributor Author

ph commented Apr 22, 2020

@ruflin this should fix the issues that @alakahakai is having.
This add support for netflow and other as types defined at the input level.

@ph ph requested a review from ruflin April 22, 2020 18:35
@ph ph added the needs_backport PR is waiting to be backported to other branches. label Apr 22, 2020
@ph
Copy link
Contributor Author

ph commented Apr 22, 2020

If I remember correctly the netflow integration package had a configuration similar to this.

- inputs:
  - type: log
    streams:
       -  type: netflow

This was working, but by accident, when the configuration was merged the las type keys was used and send directly to the filebeat process.

Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Long term we need to think about how me can make sure these stay up-to-date.

@ph
Copy link
Contributor Author

ph commented Apr 23, 2020

@ruflin Yes, but at the same time, I do not want them to be auto enabled :)

@ph ph merged commit cd5fefd into elastic:master Apr 23, 2020
ph added a commit to ph/beats that referenced this pull request Apr 23, 2020
* [Elastic Agent] Enable more inputs in Filebeat.

Enable S3, Azureeventhub, cloudfoundry, httpjson, netflow, o365audit

We were missing a number of x-pack specific inputs

(cherry picked from commit cd5fefd)
@ph ph added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 23, 2020
ph added a commit that referenced this pull request Apr 24, 2020
* [Elastic Agent] Enable more inputs in Filebeat.

Enable S3, Azureeventhub, cloudfoundry, httpjson, netflow, o365audit

We were missing a number of x-pack specific inputs

(cherry picked from commit cd5fefd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants