[visualize embeddable] fix panel disappears from dashboard when canceling edit after dashboard save #193914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling edit after dashboard save
|
/ci |
nreese
commented
Sep 24, 2024
| ? parentApi.timeRange$.getValue() | ||
| : {}; | ||
| const customTimeRange = customTimeRange$.getValue(); | ||
| const parentApiContext = parentApi.getAppContext(); |
There was a problem hiding this comment.
This is the fix for the visualize embeddable. Calling getAppContext in the onEdit callback
nreese
added
release_note:fix
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
nickpeihl
approved these changes
Sep 25, 2024
mbondyra
approved these changes
Sep 26, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2024
…ling edit after dashboard save (elastic#193914) Part of elastic#193905. Broke work into separate PRs to backport map embeddable changes to 8.15. Resolves issue for Visualize embeddable and dashboard empty screen. The problem is that Visualize embeddable is using a stale result from `parentApi.getAppContext`. Dashboard's `getAppContext` changes the `getCurrentPath` when the dashboard has a saved object id. By using the stale results, `getCurrentPath` returned `#/create` instead of `#/view/`. The fix is to get a current version of `getAppContext` when required. ### Test steps 1. create new dashboard 2. Click "Add panel" (problem also exists when using "Add from library") 3. Select "Aggregation based" 4. In editor, click "Save and return" 5. Save dashboard 6. Click "Edit" in panel context menu 7. In editor, click "Cancel" 8. Ensure visualize panel is still displayed in dashboard (cherry picked from commit d6c8840)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2024
… canceling edit after dashboard save (#193914) (#194152) # Backport This will backport the following commits from `main` to `8.x`: - [[visualize embeddable] fix panel disappears from dashboard when canceling edit after dashboard save (#193914)](#193914) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T13:47:04Z","message":"[visualize embeddable] fix panel disappears from dashboard when canceling edit after dashboard save (#193914)\n\nPart of #193905. Broke work into\r\nseparate PRs to backport map embeddable changes to 8.15.\r\n\r\nResolves issue for Visualize embeddable and dashboard empty screen. The\r\nproblem is that Visualize embeddable is using a stale result from\r\n`parentApi.getAppContext`. Dashboard's `getAppContext` changes the\r\n`getCurrentPath` when the dashboard has a saved object id. By using the\r\nstale results, `getCurrentPath` returned `#/create` instead of\r\n`#/view/`. The fix is to get a current version of `getAppContext` when\r\nrequired.\r\n\r\n### Test steps\r\n1. create new dashboard\r\n2. Click \"Add panel\" (problem also exists when using \"Add from library\")\r\n3. Select \"Aggregation based\"\r\n4. In editor, click \"Save and return\"\r\n5. Save dashboard\r\n6. Click \"Edit\" in panel context menu\r\n7. In editor, click \"Cancel\"\r\n8. Ensure visualize panel is still displayed in dashboard","sha":"d6c8840a561484bee74dbcb335290c879e82d370","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","project:embeddableRebuild","v8.16.0","backport:version"],"title":"[visualize embeddable] fix panel disappears from dashboard when canceling edit after dashboard save","number":193914,"url":"https://github.com/elastic/kibana/pull/193914","mergeCommit":{"message":"[visualize embeddable] fix panel disappears from dashboard when canceling edit after dashboard save (#193914)\n\nPart of #193905. Broke work into\r\nseparate PRs to backport map embeddable changes to 8.15.\r\n\r\nResolves issue for Visualize embeddable and dashboard empty screen. The\r\nproblem is that Visualize embeddable is using a stale result from\r\n`parentApi.getAppContext`. Dashboard's `getAppContext` changes the\r\n`getCurrentPath` when the dashboard has a saved object id. By using the\r\nstale results, `getCurrentPath` returned `#/create` instead of\r\n`#/view/`. The fix is to get a current version of `getAppContext` when\r\nrequired.\r\n\r\n### Test steps\r\n1. create new dashboard\r\n2. Click \"Add panel\" (problem also exists when using \"Add from library\")\r\n3. Select \"Aggregation based\"\r\n4. In editor, click \"Save and return\"\r\n5. Save dashboard\r\n6. Click \"Edit\" in panel context menu\r\n7. In editor, click \"Cancel\"\r\n8. Ensure visualize panel is still displayed in dashboard","sha":"d6c8840a561484bee74dbcb335290c879e82d370"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193914","number":193914,"mergeCommit":{"message":"[visualize embeddable] fix panel disappears from dashboard when canceling edit after dashboard save (#193914)\n\nPart of #193905. Broke work into\r\nseparate PRs to backport map embeddable changes to 8.15.\r\n\r\nResolves issue for Visualize embeddable and dashboard empty screen. The\r\nproblem is that Visualize embeddable is using a stale result from\r\n`parentApi.getAppContext`. Dashboard's `getAppContext` changes the\r\n`getCurrentPath` when the dashboard has a saved object id. By using the\r\nstale results, `getCurrentPath` returned `#/create` instead of\r\n`#/view/`. The fix is to get a current version of `getAppContext` when\r\nrequired.\r\n\r\n### Test steps\r\n1. create new dashboard\r\n2. Click \"Add panel\" (problem also exists when using \"Add from library\")\r\n3. Select \"Aggregation based\"\r\n4. In editor, click \"Save and return\"\r\n5. Save dashboard\r\n6. Click \"Edit\" in panel context menu\r\n7. In editor, click \"Cancel\"\r\n8. Ensure visualize panel is still displayed in dashboard","sha":"d6c8840a561484bee74dbcb335290c879e82d370"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #193905. Broke work into separate PRs to backport map embeddable changes to 8.15.
Resolves issue for Visualize embeddable and dashboard empty screen. The problem is that Visualize embeddable is using a stale result from
parentApi.getAppContext. Dashboard'sgetAppContextchanges thegetCurrentPathwhen the dashboard has a saved object id. By using the stale results,getCurrentPathreturned#/createinstead of#/view/. The fix is to get a current version ofgetAppContextwhen required.Test steps