[Inventory][ECO] Entities page search bar #193546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ventory-entities-list-2
…ventory-entities-list-2
…ventory-entities-list-2
…kibana into inventory-entities-list-2
…inventory-entities-search
…kibana into inventory-entities-search
kpatticha
reviewed
Sep 20, 2024
x-pack/plugins/observability_solution/inventory/server/routes/entities/get_entity_types.ts
Outdated
Show resolved
Hide resolved
kpatticha
approved these changes
Sep 20, 2024
...gins/observability_solution/inventory/public/components/search_bar/entity_types_controls.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/inventory/public/components/search_bar/index.tsx
Outdated
Show resolved
Hide resolved
|
oh I just noticed that the search bar is using padding and it's not aligning with the table. Can you please 🙏 take a look |
…nts/search_bar/entity_types_controls.tsx Co-authored-by: Carlos Crespo <[email protected]>
…kibana into inventory-entities-search
jloleysens
approved these changes
Sep 23, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
cauemarcondes
added a commit
to cauemarcondes/kibana
that referenced
this pull request
Sep 23, 2024
closes elastic#192329 https://github.com/user-attachments/assets/eb4e7aa6-14dd-48fb-a076-98ceec9cb335 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Carlos Crespo <[email protected]> (cherry picked from commit 6a0fa96)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
weizijun
added a commit
to weizijun/kibana
that referenced
this pull request
Sep 23, 2024
* main: (176 commits) [ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (elastic#193420) Bump maximum supported package spec version to 3.2 (elastic#193574) [ES|QL] new pattern for `SORT` autocomplete (elastic#193595) [Inventory][ECO] Entities page search bar (elastic#193546) [Synthetics] Remove extra overview route (elastic#192449) [Obs Alerts table] Fix error on clicking alert reason message (elastic#193693) [Migrations] Remove tests that are not applicable in 9.x (elastic#193699) [EDR Workflows] Set Agent Tamper Protection to false on policy unassignment (elastic#193017) [Inventory][ECO] Enable elastic entity model from inventory (elastic#193557) [EDR Workflows] The host isolation exception tab is hidden on the basic license if no artifacts (elastic#192562) [Entity Analytics] Ensuring definition transforms are managed (elastic#193408) [Automatic Import] Do not remove message field for unstructured logs (elastic#193678) [Fleet] Add missing permissions for connector package (elastic#193573) [Fleet] using @kbn/config-schema part 2 (outputs and other apis) (elastic#193326) [Migrations] Provide testing archives + tooling for migrations integration tests (elastic#193328) [ES|QL] Renames the textbased editor to esql editor (elastic#193521) [ES|QL] Update function metadata (elastic#193662) [Security Solution][Entity Analytics] Scoping the entity store to spaces (elastic#193303) [Docs] Update Sharing docs (elastic#190318) [ML] AIOps: Move Log Rate Analysis results callout to help popover. (elastic#192243) ... # Conflicts: # x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.test.tsx # x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.tsx
cauemarcondes
added a commit
that referenced
this pull request
Sep 23, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Inventory][ECO] Entities page search bar (#193546)](#193546) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cauê Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T13:59:15Z","message":"[Inventory][ECO] Entities page search bar (#193546)\n\ncloses https://github.com/elastic/kibana/issues/192329\r\n\r\n\r\nhttps://github.com/user-attachments/assets/eb4e7aa6-14dd-48fb-a076-98ceec9cb335\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Carlos Crespo <[email protected]>","sha":"6a0fa96141086644bc8756a37babe43204e6c076","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","v8.16.0"],"number":193546,"url":"https://github.com/elastic/kibana/pull/193546","mergeCommit":{"message":"[Inventory][ECO] Entities page search bar (#193546)\n\ncloses https://github.com/elastic/kibana/issues/192329\r\n\r\n\r\nhttps://github.com/user-attachments/assets/eb4e7aa6-14dd-48fb-a076-98ceec9cb335\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Carlos Crespo <[email protected]>","sha":"6a0fa96141086644bc8756a37babe43204e6c076"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193546","number":193546,"mergeCommit":{"message":"[Inventory][ECO] Entities page search bar (#193546)\n\ncloses https://github.com/elastic/kibana/issues/192329\r\n\r\n\r\nhttps://github.com/user-attachments/assets/eb4e7aa6-14dd-48fb-a076-98ceec9cb335\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Carlos Crespo <[email protected]>","sha":"6a0fa96141086644bc8756a37babe43204e6c076"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #192329
search.bar.mp4